All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix print order in show_free_areas()
@ 2017-03-24 17:48 Alexander Polakov
  2017-04-03 22:11 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Polakov @ 2017-03-24 17:48 UTC (permalink / raw)
  To: linux-mm

Better seen in context: https://github.com/torvalds/linux/blob/master/m
m/page_alloc.c#L4500

Signed-off-by: Alexander Polyakov <apolyakov@beget.com>

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 8afb60c..7b528c7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4398,13 +4398,13 @@ void show_free_areas(unsigned int filter)
A 			K(node_page_state(pgdat, NR_FILE_MAPPED)),
A 			K(node_page_state(pgdat, NR_FILE_DIRTY)),
A 			K(node_page_state(pgdat, NR_WRITEBACK)),
+			K(node_page_state(pgdat, NR_SHMEM)),
A #ifdef CONFIG_TRANSPARENT_HUGEPAGE
A 			K(node_page_state(pgdat, NR_SHMEM_THPS) *
HPAGE_PMD_NR),
A 			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
A 					* HPAGE_PMD_NR),
A 			K(node_page_state(pgdat, NR_ANON_THPS) *
HPAGE_PMD_NR),
A #endif
-			K(node_page_state(pgdat, NR_SHMEM)),
A 			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
A 			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
A 			node_page_state(pgdat, NR_PAGES_SCANNED),

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix print order in show_free_areas()
  2017-03-24 17:48 [PATCH] Fix print order in show_free_areas() Alexander Polakov
@ 2017-04-03 22:11 ` Andrew Morton
  2017-04-04 14:19   ` Mel Gorman
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2017-04-03 22:11 UTC (permalink / raw)
  To: Alexander Polakov; +Cc: linux-mm, Mel Gorman

On Fri, 24 Mar 2017 20:48:50 +0300 Alexander Polakov <apolyakov@beget.ru> wrote:

> Better seen in context: https://github.com/torvalds/linux/blob/master/m
> m/page_alloc.c#L4500
> 
> Signed-off-by: Alexander Polyakov <apolyakov@beget.com>

--- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
+++ a/mm/page_alloc.c
@@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
 			K(node_page_state(pgdat, NR_FILE_MAPPED)),
 			K(node_page_state(pgdat, NR_FILE_DIRTY)),
 			K(node_page_state(pgdat, NR_WRITEBACK)),
+			K(node_page_state(pgdat, NR_SHMEM)),
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 			K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
 			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
 					* HPAGE_PMD_NR),
 			K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
 #endif
-			K(node_page_state(pgdat, NR_SHMEM)),
 			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
 			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
 			node_page_state(pgdat, NR_PAGES_SCANNED),
_

huh.  It looks like this has been broken for nearly a year, by

: commit 11fb998986a72aa7e997d96d63d52582a01228c5
: Author:     Mel Gorman <mgorman@techsingularity.net>
: AuthorDate: Thu Jul 28 15:46:20 2016 -0700
: Commit:     Linus Torvalds <torvalds@linux-foundation.org>
: CommitDate: Thu Jul 28 16:07:41 2016 -0700
: 
:     mm: move most file-based accounting to the node

I'm surprised nobody noticed until now.

btw, your email client is messing up the patches: tabs are getting
mangled and wordwrapping is added.  Please fix that up for next time.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix print order in show_free_areas()
  2017-04-03 22:11 ` Andrew Morton
@ 2017-04-04 14:19   ` Mel Gorman
  0 siblings, 0 replies; 3+ messages in thread
From: Mel Gorman @ 2017-04-04 14:19 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Alexander Polakov, linux-mm

On Mon, Apr 03, 2017 at 03:11:11PM -0700, Andrew Morton wrote:
> On Fri, 24 Mar 2017 20:48:50 +0300 Alexander Polakov <apolyakov@beget.ru> wrote:
> 
> > Better seen in context: https://github.com/torvalds/linux/blob/master/m
> > m/page_alloc.c#L4500
> > 
> > Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
> 
> --- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
> +++ a/mm/page_alloc.c
> @@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
>  			K(node_page_state(pgdat, NR_FILE_MAPPED)),
>  			K(node_page_state(pgdat, NR_FILE_DIRTY)),
>  			K(node_page_state(pgdat, NR_WRITEBACK)),
> +			K(node_page_state(pgdat, NR_SHMEM)),
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>  			K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
>  					* HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
>  #endif
> -			K(node_page_state(pgdat, NR_SHMEM)),
>  			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
>  			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
>  			node_page_state(pgdat, NR_PAGES_SCANNED),
> _
> 
> huh.  It looks like this has been broken for nearly a year, by
> 
> : commit 11fb998986a72aa7e997d96d63d52582a01228c5
> : Author:     Mel Gorman <mgorman@techsingularity.net>
> : AuthorDate: Thu Jul 28 15:46:20 2016 -0700
> : Commit:     Linus Torvalds <torvalds@linux-foundation.org>
> : CommitDate: Thu Jul 28 16:07:41 2016 -0700
> : 
> :     mm: move most file-based accounting to the node
> 

Yes, this was careless. Thanks for catching it Alexander.

> I'm surprised nobody noticed until now.
> 

Probably because vmstat was not affected which is consumed more often
than the output from sysrq or an oom kill message.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-04 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 17:48 [PATCH] Fix print order in show_free_areas() Alexander Polakov
2017-04-03 22:11 ` Andrew Morton
2017-04-04 14:19   ` Mel Gorman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.