From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasesh Mody Subject: [PATCH v4 47/62] net/qede/base: add macro for unsupported command Date: Mon, 27 Mar 2017 23:52:17 -0700 Message-ID: <1490683952-24919-48-git-send-email-rasesh.mody@cavium.com> References: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Rasesh Mody To: , Return-path: Received: from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com [67.231.148.157]) by dpdk.org (Postfix) with ESMTP id E3A85CFBC for ; Tue, 28 Mar 2017 08:55:13 +0200 (CEST) In-Reply-To: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a macro for unsupported management FW command Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c | 6 ++---- drivers/net/qede/base/mcp_public.h | 1 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index 6c5b5db..15f3ea0 100644 --- a/drivers/net/qede/base/ecore_mcp.c +++ b/drivers/net/qede/base/ecore_mcp.c @@ -1424,8 +1424,7 @@ ecore_mcp_mdump_get_config(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, if (rc != ECORE_SUCCESS) return rc; - /* A zero response implies that the mdump command is not supported */ - if (!mcp_resp) + if (mcp_resp == FW_MSG_CODE_UNSUPPORTED) return ECORE_NOTIMPL; if (mcp_resp != FW_MSG_CODE_OK) { @@ -2832,8 +2831,7 @@ static enum _ecore_status_t ecore_mcp_resource_cmd(struct ecore_hwfn *p_hwfn, if (rc != ECORE_SUCCESS) return rc; - /* A zero response implies that the resource command is not supported */ - if (!*p_mcp_resp) + if (*p_mcp_resp == FW_MSG_CODE_UNSUPPORTED) return ECORE_NOTIMPL; if (*p_mcp_param == RESOURCE_OPCODE_UNKNOWN_CMD) { diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index 17971a4..8d65390 100644 --- a/drivers/net/qede/base/mcp_public.h +++ b/drivers/net/qede/base/mcp_public.h @@ -1489,6 +1489,7 @@ struct public_drv_mb { u32 fw_mb_header; #define FW_MSG_CODE_MASK 0xffff0000 +#define FW_MSG_CODE_UNSUPPORTED 0x00000000 #define FW_MSG_CODE_DRV_LOAD_ENGINE 0x10100000 #define FW_MSG_CODE_DRV_LOAD_PORT 0x10110000 #define FW_MSG_CODE_DRV_LOAD_FUNCTION 0x10120000 -- 1.7.10.3