[PATCH] libxslt: Add PACKAGECONFIG support

[PATCH] libxslt: Add PACKAGECONFIG support

[Vedang Patel]

Some options like python bindings, debug support, crypto are hardcoded
inside the recipe. Change that to make those option configurable using
PACKAGECONFIG.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 meta/recipes-support/libxslt/libxslt_1.1.29.bb | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
index be747e608d9d..d362118aa307 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
+++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
 
 BINCONFIG = "${bindir}/xslt-config"
 
-inherit autotools pkgconfig binconfig-disabled lib_package
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
 
 # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
 do_configure_prepend () {
@@ -33,7 +33,12 @@ do_configure_prepend () {
 	touch ${S}/doc/xsltproc.1
 }
 
-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
+PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"
+PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
+PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"
+PACKAGECONFIG[libxslt-mem-debug] = "--with-mem-debug, --without-mem-debug"
+PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"
+
 # older versions of this recipe had ${PN}-utils
 RPROVIDES_${PN}-bin += "${PN}-utils"
 RCONFLICTS_${PN}-bin += "${PN}-utils"
-- 
2.7.3

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 2126 bytes --]

On 21 March 2017 at 02:31, Vedang Patel <vedang.patel@intel.com> wrote:

> Some options like python bindings, debug support, crypto are hardcoded
> inside the recipe. Change that to make those option configurable using
> PACKAGECONFIG.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
>  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> index be747e608d9d..d362118aa307 100644
> --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
>
>  BINCONFIG = "${bindir}/xslt-config"
>
> -inherit autotools pkgconfig binconfig-disabled lib_package
> +inherit autotools pkgconfig binconfig-disabled lib_package
> distutils-common-base
>
>  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the
> header
>  do_configure_prepend () {
> @@ -33,7 +33,12 @@ do_configure_prepend () {
>         touch ${S}/doc/xsltproc.1
>  }
>
> -EXTRA_OECONF = "--without-python --without-debug --without-mem-debug
> --without-crypto"
> +PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"
>

You change all the defaults, is this on purpose? It should be noted in the
commit message in any case.



> +PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION},
> --without-python"
> +PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"
> +PACKAGECONFIG[libxslt-mem-debug] = "--with-mem-debug,
> --without-mem-debug"
> +PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"
> +
>  # older versions of this recipe had ${PN}-utils
>  RPROVIDES_${PN}-bin += "${PN}-utils"
>  RCONFLICTS_${PN}-bin += "${PN}-utils"
> --
> 2.7.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3465 bytes --]

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Patel, Vedang]

[-- Attachment #1: Type: text/plain, Size: 2847 bytes --]

Hi Jussi,

On Tue, 2017-03-21 at 08:36 +0000, Kukkonen, Jussi wrote:
On 21 March 2017 at 02:31, Vedang Patel <vedang.patel@intel.com<mailto:vedang.patel@intel.com>> wrote:
Some options like python bindings, debug support, crypto are hardcoded
inside the recipe. Change that to make those option configurable using
PACKAGECONFIG.

Signed-off-by: Vedang Patel <vedang.patel@intel.com<mailto:vedang.patel@intel.com>>
---
 meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb> | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb> b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
index be747e608d9d..d362118aa307 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
+++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"

 BINCONFIG = "${bindir}/xslt-config"

-inherit autotools pkgconfig binconfig-disabled lib_package
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base

 # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
 do_configure_prepend () {
@@ -33,7 +33,12 @@ do_configure_prepend () {
        touch ${S}/doc/xsltproc.1
 }

-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
+PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"


You change all the defaults, is this on purpose? It should be noted in the commit message in any case.

Can you elabore on your concern? I am not exactly following it.

the configs won't be enabled unless the corresponding features are explicitly enabled in the image. I am using libxslt- prefix to make sure someone does not inadvertently enables the features by using the generic flags (python, debug, ... ).

I do see a bug here, In the first line, python should be replaced with libxslt-python. I will fix it in the next version of this patch.

Thanks,
Vedang Patel
Software Engineer
Intel Corporation

+PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
+PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"
+PACKAGECONFIG[libxslt-mem-debug] = "--with-mem-debug, --without-mem-debug"
+PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"
+
 # older versions of this recipe had ${PN}-utils
 RPROVIDES_${PN}-bin += "${PN}-utils"
 RCONFLICTS_${PN}-bin += "${PN}-utils"
--
2.7.3

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-core



[-- Attachment #2: Type: text/html, Size: 4558 bytes --]

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On 22 March 2017 at 20:17, Patel, Vedang <vedang.patel@intel.com> wrote:

> Can you elabore on your concern? I am not exactly following it.
>
> the configs won't be enabled unless the corresponding features are
> explicitly enabled in the image. I am using libxslt- prefix to make sure
> someone does not inadvertently enables the features by using the generic
> flags (python, debug, ... ).
>

No, you're changing the default to enable all the things that were
previously disabled.

Also you don't need to prefix the names as they're recipe-specific already.

I suggest that you re-read the PACKAGECONFIG section in the manual and
resubmit the patch.

Ross

[-- Attachment #2: Type: text/html, Size: 1257 bytes --]

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Patel, Vedang]

Hi Ross,

On Wed, 2017-03-22 at 20:19 +0000, Burton, Ross wrote:
> 
> On 22 March 2017 at 20:17, Patel, Vedang <vedang.patel@intel.com>
> wrote:
> > Can you elabore on your concern? I am not exactly following it.
> > 
> > the configs won't be enabled unless the corresponding features are
> > explicitly enabled in the image. I am using libxslt- prefix to make
> > sure someone does not inadvertently enables the features by using
> > the generic flags (python, debug, ... ). 
> > 
> No, you're changing the default to enable all the things that were
> previously disabled.
> 
> Also you don't need to prefix the names as they're recipe-specific
> already.
> 
> I suggest that you re-read the PACKAGECONFIG section in the manual
> and resubmit the patch.

I got my mistake. Setting PACKAGECONFIG enabled all the features by
default. Also, should I be including python as runtime dependency when
--with-python is used?

Thanks,
Vedang Patel
Software Engineer
Intel Corporation
> 
> Ross

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On 22 March 2017 at 22:16, Patel, Vedang <vedang.patel@intel.com> wrote:

> I got my mistake. Setting PACKAGECONFIG enabled all the features by
> default. Also, should I be including python as runtime dependency when
> --with-python is used?
>

No, the rdepends will happen magically.  You might want to package the
python module separately though.

Ross

[-- Attachment #2: Type: text/html, Size: 779 bytes --]

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Patel, Vedang]

On Wed, 2017-03-22 at 22:18 +0000, Burton, Ross wrote:
> 
> On 22 March 2017 at 22:16, Patel, Vedang <vedang.patel@intel.com>
> wrote:
> > I got my mistake. Setting PACKAGECONFIG enabled all the features by
> > default. Also, should I be including python as runtime dependency
> > when
> > --with-python is used?
> > 
> No, the rdepends will happen magically.  You might want to package
> the python module separately though.
Thanks Ross for the inputs. I will submit a new patch soon.

Also, I am planning to drop the other 3 features (debug, mem-debug and
crypto) as I have not really tested them.

Thanks,
Vedang
> 
> Ross

[PATCH v2] libxslt: Add PACKAGECONFIG support for python

[Vedang Patel]

Add support to enable python bindings for libxslt using PACKAGECONFIG.
This will include --with-python argument while compiling the package.
The support is disabled by default.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
index be747e608d9d..1e00306207c5 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
+++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
 
 BINCONFIG = "${bindir}/xslt-config"
 
-inherit autotools pkgconfig binconfig-disabled lib_package
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
 
 # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
 do_configure_prepend () {
@@ -33,7 +33,9 @@ do_configure_prepend () {
 	touch ${S}/doc/xsltproc.1
 }
 
-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
+EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"
+PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
+
 # older versions of this recipe had ${PN}-utils
 RPROVIDES_${PN}-bin += "${PN}-utils"
 RCONFLICTS_${PN}-bin += "${PN}-utils"
-- 
2.7.3

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 4317 bytes --]

On 22 March 2017 at 22:17, Patel, Vedang <vedang.patel@intel.com> wrote:
>
> Hi Jussi,
>

Hi Vedang,

If you can make your email client use ">" for quoting that would be great
(so it's possible to see who's talking even in plain text).

PACKAGECONFIG comments below.

> On Tue, 2017-03-21 at 08:36 +0000, Kukkonen, Jussi wrote:
> On 21 March 2017 at 02:31, Vedang Patel <vedang.patel@intel.com<mailto:
vedang.patel@intel.com>> wrote:
> Some options like python bindings, debug support, crypto are hardcoded
> inside the recipe. Change that to make those option configurable using
> PACKAGECONFIG.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com<mailto:
vedang.patel@intel.com>>
> ---
>  meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
| 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<
http://libxslt_1.1.29.bb> b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<
http://libxslt_1.1.29.bb>
> index be747e608d9d..d362118aa307 100644
> --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<
http://libxslt_1.1.29.bb>
> +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<
http://libxslt_1.1.29.bb>
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
>
>  BINCONFIG = "${bindir}/xslt-config"
>
> -inherit autotools pkgconfig binconfig-disabled lib_package
> +inherit autotools pkgconfig binconfig-disabled lib_package
distutils-common-base
>
>  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the
header
>  do_configure_prepend () {
> @@ -33,7 +33,12 @@ do_configure_prepend () {
>         touch ${S}/doc/xsltproc.1
>  }
>
> -EXTRA_OECONF = "--without-python --without-debug --without-mem-debug
--without-crypto"
> +PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"
>
>
> You change all the defaults, is this on purpose? It should be noted in
the commit message in any case.
>
> Can you elabore on your concern? I am not exactly following it.
>
> the configs won't be enabled unless the corresponding features are
explicitly enabled in the image. I am using libxslt- prefix to make sure
someone does not inadvertently enables the features by using the generic
flags (python, debug, ... ).
>There seems to be some confusion here.

I think there's some confusion here about PACKAGECONFIG and image features:
PACKAGECONFIG is completely recipe specific -- it only controls this
recipe. There's no need to use a naming prefix as these variables are only
visible inside the recipe. Changing them from outside (like local.conf) is
possible but requires a syntax like
    PACKAGECONFIG_pn-libxslt = "python crypto"
so there's no need to fear namespace mixups.

Second, this line:
    PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug
libxslt-crypto"
sets he default value of libxslt PACKAGECONFIG. Meaning that these options
will be given to configure:
    "--with-python=<ver> --with-debug --with-mem-debug --with-crypto"
Currently the EXTRA_OECONF line explicitly disables all these so this looks
like a change in defaults.

If in doubt (or I didn't make sense) you should run "bitbake -cconfigure
libxslt" with both versions and check what ends up in the configure options
in $WORKDIR/temp/log.do_configure.

Cheers,
  Jussi



> I do see a bug here, In the first line, python should be replaced with
libxslt-python. I will fix it in the next version of this patch.
>
> Thanks,
> Vedang Patel
> Software Engineer
> Intel Corporation
>
> +PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION},
--without-python"
> +PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"
> +PACKAGECONFIG[libxslt-mem-debug] = "--with-mem-debug,
--without-mem-debug"
> +PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"
> +
>  # older versions of this recipe had ${PN}-utils
>  RPROVIDES_${PN}-bin += "${PN}-utils"
>  RCONFLICTS_${PN}-bin += "${PN}-utils"
> --
> 2.7.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org<mailto:
Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 6036 bytes --]

Re: [PATCH] libxslt: Add PACKAGECONFIG support

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On 23 March 2017 at 09:37, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:

> On 22 March 2017 at 22:17, Patel, Vedang <vedang.patel@intel.com> wrote:
> >
> > Hi Jussi,
> >
>
> Hi Vedang,
>
>
... and somehow I only received the rest of the discussion (where all my
points were already handled) now: carry on, sorry for spam.

Jussi

[-- Attachment #2: Type: text/html, Size: 803 bytes --]

Re: [PATCH v2] libxslt: Add PACKAGECONFIG support for python

[Randy Witt]

Hi Patel,

On 03/22/2017 06:05 PM, Vedang Patel wrote:
> Add support to enable python bindings for libxslt using PACKAGECONFIG.
> This will include --with-python argument while compiling the package.
> The support is disabled by default.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
>  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> index be747e608d9d..1e00306207c5 100644
> --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
>
>  BINCONFIG = "${bindir}/xslt-config"
>
> -inherit autotools pkgconfig binconfig-disabled lib_package
> +inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
>
>  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
>  do_configure_prepend () {
> @@ -33,7 +33,9 @@ do_configure_prepend () {
>  	touch ${S}/doc/xsltproc.1
>  }
>
> -EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
> +EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"
> +PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
> +
You kept "libxslt-python", and I think you meant to change it to "python".

>  # older versions of this recipe had ${PN}-utils
>  RPROVIDES_${PN}-bin += "${PN}-utils"
>  RCONFLICTS_${PN}-bin += "${PN}-utils"
>

Re: [PATCH v2] libxslt: Add PACKAGECONFIG support for python

[Patel, Vedang]

On Thu, 2017-03-23 at 12:55 -0700, Randy Witt wrote:
> Hi Patel,
> 
> On 03/22/2017 06:05 PM, Vedang Patel wrote:
> > 
> > Add support to enable python bindings for libxslt using
> > PACKAGECONFIG.
> > This will include --with-python argument while compiling the
> > package.
> > The support is disabled by default.
> > 
> > Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> > ---
> >  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > index be747e608d9d..1e00306207c5 100644
> > --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
> > 
> >  BINCONFIG = "${bindir}/xslt-config"
> > 
> > -inherit autotools pkgconfig binconfig-disabled lib_package
> > +inherit autotools pkgconfig binconfig-disabled lib_package
> > distutils-common-base
> > 
> >  # We don't DEPEND on binutils for ansidecl.h so ensure we don't
> > use the header
> >  do_configure_prepend () {
> > @@ -33,7 +33,9 @@ do_configure_prepend () {
> >  	touch ${S}/doc/xsltproc.1
> >  }
> > 
> > -EXTRA_OECONF = "--without-python --without-debug --without-mem-
> > debug --without-crypto"
> > +EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> > crypto"
> > +PACKAGECONFIG[libxslt-python] = "--with-
> > python=${PYTHON_BASE_VERSION}, --without-python"
> > +
> You kept "libxslt-python", and I think you meant to change it to
> "python".
> 
Yeah I totally missed that... Will fix it in the next version.

-Vedang
> > 
> >  # older versions of this recipe had ${PN}-utils
> >  RPROVIDES_${PN}-bin += "${PN}-utils"
> >  RCONFLICTS_${PN}-bin += "${PN}-utils"
> > 

[PATCH] libxslt: Add PACKAGECONFIG support for python

[Vedang Patel]

Add support to enable python bindings for libxslt using PACKAGECONFIG.
This will include --with-python argument while compiling the package.
The support is disabled by default.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
index be747e608d9d..707f2f97b7fc 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
+++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
 
 BINCONFIG = "${bindir}/xslt-config"
 
-inherit autotools pkgconfig binconfig-disabled lib_package
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
 
 # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
 do_configure_prepend () {
@@ -33,7 +33,9 @@ do_configure_prepend () {
 	touch ${S}/doc/xsltproc.1
 }
 
-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
+EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"
+PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
+
 # older versions of this recipe had ${PN}-utils
 RPROVIDES_${PN}-bin += "${PN}-utils"
 RCONFLICTS_${PN}-bin += "${PN}-utils"
-- 
2.7.3

Re: [PATCH] libxslt: Add PACKAGECONFIG support for python

[Andre McCurdy]

 On Thu, Mar 23, 2017 at 5:00 PM, Vedang Patel <vedang.patel@intel.com> wrote:
> Add support to enable python bindings for libxslt using PACKAGECONFIG.
> This will include --with-python argument while compiling the package.
> The support is disabled by default.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
>  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> index be747e608d9d..707f2f97b7fc 100644
> --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
>
>  BINCONFIG = "${bindir}/xslt-config"
>
> -inherit autotools pkgconfig binconfig-disabled lib_package
> +inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
>
>  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
>  do_configure_prepend () {
> @@ -33,7 +33,9 @@ do_configure_prepend () {
>         touch ${S}/doc/xsltproc.1
>  }
>
> -EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
> +EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"
> +PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"

The more conventional way to order these lines would be:

  PACKAGECONFIG ?= ""
  PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION},
--without-python"

  EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"

The python PACKAGECONFIG option probably needs to include a dependency
on python.

>  # older versions of this recipe had ${PN}-utils
>  RPROVIDES_${PN}-bin += "${PN}-utils"
>  RCONFLICTS_${PN}-bin += "${PN}-utils"
> --
> 2.7.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] libxslt: Add PACKAGECONFIG support for python

[Patel, Vedang]

Hi Andre, Ross,

On Thu, 2017-03-23 at 18:39 -0700, Andre McCurdy wrote:
>  On Thu, Mar 23, 2017 at 5:00 PM, Vedang Patel <vedang.patel@intel.co
> m> wrote:
> > 
> > Add support to enable python bindings for libxslt using
> > PACKAGECONFIG.
> > This will include --with-python argument while compiling the
> > package.
> > The support is disabled by default.
> > 
> > Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> > ---
> >  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > index be747e608d9d..707f2f97b7fc 100644
> > --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
> > 
> >  BINCONFIG = "${bindir}/xslt-config"
> > 
> > -inherit autotools pkgconfig binconfig-disabled lib_package
> > +inherit autotools pkgconfig binconfig-disabled lib_package
> > distutils-common-base
> > 
> >  # We don't DEPEND on binutils for ansidecl.h so ensure we don't
> > use the header
> >  do_configure_prepend () {
> > @@ -33,7 +33,9 @@ do_configure_prepend () {
> >         touch ${S}/doc/xsltproc.1
> >  }
> > 
> > -EXTRA_OECONF = "--without-python --without-debug --without-mem-
> > debug --without-crypto"
> > +EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> > crypto"
> > +PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION}, --
> > without-python"
> The more conventional way to order these lines would be:
> 
>   PACKAGECONFIG ?= ""
>   PACKAGECONFIG[python] = "--with-python=${PYTHON_BASE_VERSION},
> --without-python"
> 
>   EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> crypto"
> 
> The python PACKAGECONFIG option probably needs to include a
> dependency
> on python.
> 
I will make the proposed changes in the arrangement of the statements.

Regarding the python dependency, the feedback from Andre is the
opposite of what Ross gave me in one of the previous emails where he
told not to include the python dependency in PACKAGECONFIG. He asked to
make sure that the python module is packaged seperately. (Just FYI:
 Here, libxslt has a hard dependency on python-2.7.)

Also, the --with-python argument will only adding python bindings to
libxslt. Is it a good idea  to move that to a subpackage? If so, can
you point me to a good example for that

Thanks,
Vedang Patel
Software Engineer
Intel Corporation
> > 
> >  # older versions of this recipe had ${PN}-utils
> >  RPROVIDES_${PN}-bin += "${PN}-utils"
> >  RCONFLICTS_${PN}-bin += "${PN}-utils"
> > --
> > 2.7.3
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core