All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, Jyri Sarha <jsarha@ti.com>
Subject: [PATCHv4 03/29] drm/omap: remove divider constraint from hsdiv
Date: Thu, 30 Mar 2017 14:15:03 +0300	[thread overview]
Message-ID: <1490872529-23084-4-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1490872529-23084-1-git-send-email-tomi.valkeinen@ti.com>

The driver only uses even dividers for hsdiv when pclk >= 100MHz, as odd
dividers can create uneven duty cycle. However, while this holds true
for some dividers like DISPC's LCK and PCK dividers, it is not actually
true for hsdiv.

hsdiv always produces even duty cycle, so the constraint can be removed.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/omapdrm/dss/dpi.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c
index e75162d26ac0..e0b0c5c24c55 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
@@ -170,14 +170,6 @@ static bool dpi_calc_hsdiv_cb(int m_dispc, unsigned long dispc,
 {
 	struct dpi_clk_calc_ctx *ctx = data;
 
-	/*
-	 * Odd dividers give us uneven duty cycle, causing problem when level
-	 * shifted. So skip all odd dividers when the pixel clock is on the
-	 * higher side.
-	 */
-	if (m_dispc > 1 && m_dispc % 2 != 0 && ctx->pck_min >= 100000000)
-		return false;
-
 	ctx->pll_cinfo.mX[ctx->clkout_idx] = m_dispc;
 	ctx->pll_cinfo.clkout[ctx->clkout_idx] = dispc;
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-03-30 11:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 11:15 [PATCHv4 00/29] drm/omap: miscallaneous improvements Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 01/29] drm/omap: work-around for errata i886 Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 02/29] drm/omap: refactor CRTC HW property setup Tomi Valkeinen
2017-03-30 11:15 ` Tomi Valkeinen [this message]
2017-03-30 11:15 ` [PATCHv4 04/29] drm/omap: decrease min width & height Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 05/29] drm/omap: improve DPI clock selection on DRA7xx Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 06/29] drm/omap: Add support for render nodes Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 07/29] drm/omap: fix HDMI sync polarities Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 08/29] drm/omap: add omapdss-base.ko Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 09/29] drm/omap: move dss_initialized to omapdss-base Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 10/29] drm/omap: output: use dev_err instead of DSSERR Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 11/29] drm/omap: display: don't use dsi_get_pixel_size() Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 12/29] drm/omap: move display, dss-of, output to omapdss-base Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 13/29] drm/omap: move dispc related dss-feat funcs to dispc Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 14/29] drm/omap: add dispc_ops Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 15/29] drm/omap: fill dispc_ops Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 16/29] drm/omap: use dispc_ops Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 17/29] drm/omap: remove all EXPORT_SYMBOLs from dispc.c Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 18/29] drm/omap: remove unused dispc_wb_enable & dispc_wb_is_enabled Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 19/29] drm/omap: fix replication logic Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 20/29] drm/omap: dss: Functions to check components in the display/output list Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 21/29] drm/omap: dss: Support for detecting display stack readiness Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 22/29] drm/omap: Use omapdss_stack_is_ready() to check that the display stack is up Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 23/29] drm/omap: display: Add displays in sorted order to the panel_list Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 24/29] drm/omap: poll only connectors where the connect/disconnect can be checked Tomi Valkeinen
     [not found] ` <1490872529-23084-1-git-send-email-tomi.valkeinen-l0cyMroinI0@public.gmane.org>
2017-03-30 11:15   ` [PATCHv4 25/29] drm/omap: displays: panel-dpi: Support for handling backlight devices Tomi Valkeinen
     [not found]     ` <1490872529-23084-26-git-send-email-tomi.valkeinen-l0cyMroinI0@public.gmane.org>
2017-04-03 15:58       ` Rob Herring
2017-03-30 11:15 ` [PATCHv4 26/29] drm/omap: dispc: improve debug print of display flags Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 27/29] drm/omap: fix display SYNC/DE flags Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 28/29] drm/omap: use drm_atomic_helper_shutdown() Tomi Valkeinen
2017-03-30 11:15 ` [PATCHv4 29/29] drm/omap: fix crash on module unload Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490872529-23084-4-git-send-email-tomi.valkeinen@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.