All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>, Li Qiang <liqiang6-s@360.cn>,
	Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset()
Date: Fri, 31 Mar 2017 13:27:31 +0200	[thread overview]
Message-ID: <149095965106.26233.18168802196576430962.stgit@bahia.lan> (raw)
In-Reply-To: <149095959109.26233.3201018420228514740.stgit@bahia>

We don't need to wait for the PDU active list to be empty: virtfs_reset()
already takes care of that.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/9pfs/9p.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 86ed9065c4e2..16ef6bd5bd8c 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -3601,6 +3601,7 @@ static void coroutine_fn virtfs_co_reset(void *opaque)
     VirtfsCoResetData *data = opaque;
 
     virtfs_reset(&data->pdu);
+    assert(QLIST_EMPTY(&data->pdu.s->active_list));
     data->done = true;
 }
 
@@ -3609,10 +3610,6 @@ void v9fs_reset(V9fsState *s)
     VirtfsCoResetData data = { .pdu = { .s = s }, .done = false };
     Coroutine *co;
 
-    while (!QLIST_EMPTY(&s->active_list)) {
-        aio_poll(qemu_get_aio_context(), true);
-    }
-
     co = qemu_coroutine_create(virtfs_co_reset, &data);
     qemu_coroutine_enter(co);
 

  parent reply	other threads:[~2017-03-31 11:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 11:26 [Qemu-devel] [for-2.9 PATCH 0/3] 9pfs: fix 9p session reset Greg Kurz
2017-03-31 11:27 ` [Qemu-devel] [for-2.9 PATCH 1/3] 9pfs: clear migration blocker at " Greg Kurz
2017-04-01  1:32   ` 李强
2017-03-31 11:27 ` [Qemu-devel] [for-2.9 PATCH 2/3] 9pfs: cancel active PDUs in virtfs_reset() Greg Kurz
2017-04-01  1:38   ` 李强
2017-03-31 11:27 ` Greg Kurz [this message]
2017-04-01  1:39   ` [Qemu-devel] [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset() 李强

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149095965106.26233.18168802196576430962.stgit@bahia.lan \
    --to=groug@kaod.org \
    --cc=eblake@redhat.com \
    --cc=liqiang6-s@360.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.