From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbdDADdy (ORCPT ); Fri, 31 Mar 2017 23:33:54 -0400 Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:48268 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751050AbdDADdx (ORCPT ); Fri, 31 Mar 2017 23:33:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3871:4321:5007:7903:8603:8660:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13148:13230:13311:13357:13439:14659:14721:21080:21434:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: stove76_5b675a0590917 X-Filterd-Recvd-Size: 1429 Message-ID: <1491017626.27353.31.camel@perches.com> Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning From: Joe Perches To: Chewie Lin Cc: Randy Dunlap , greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 31 Mar 2017 20:33:46 -0700 In-Reply-To: <20170401031851.GA9149@Cassini.Home> References: <20170401015919.9181-1-linsh@oregonstate.edu> <20170401015919.9181-2-linsh@oregonstate.edu> <861e5179-270f-ce93-4d9c-9732945bf8c1@infradead.org> <1491014709.27353.29.camel@perches.com> <20170401031851.GA9149@Cassini.Home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote: > These are good points, but any feedback on the dev_warn() call itself? > I was trying to fix the checkpatch warning on my first try. Using "%s" with a long string is generally inefficient. Compare the compiled object size of printf("%s is %d\n", "Long string", 1); to printf("Long string is %d\n", 1);