All of lore.kernel.org
 help / color / mirror / Atom feed
From: eric.gao at rock-chips.com <eric.gao@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] system halt when we enable bucks of PMIC rk808
Date: Sat,  1 Apr 2017 22:30:41 +0800	[thread overview]
Message-ID: <1491057047-703-2-git-send-email-eric.gao@rock-chips.com> (raw)
In-Reply-To: <1491057047-703-1-git-send-email-eric.gao@rock-chips.com>

From: "eric.gao" <eric.gao@rock-chips.com>

if we enable PMIC rk808,the system will halt at very early stage
,log is shown as bellow.

INFO:    plat_rockchip_pmu_init(1211): pd status 3e
INFO:    BL31: Initializing runtime services
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9
time 44561b, 0 (<<----Just stop here)

It's caused by the absence of "{ }" in file rk3399/syscon_rk3399.c
,which will lead to memory overflow like below.According to Sysmap
file ,we can find the function buck_get_value of rk808 is just follow
the compatible struct, the pointer "of_match" point to "buck_get_value",
but it is not a struct and don't have member of compatible, In this
case,system crash. So,on the face, it looks like that rk808 is guilty.
but he is really innocent.

while (of_match->compatible) { <<----------
    if (!strcmp(of_match->compatible, compat)) {
    *of_idp = of_match;
    return 0;
    }
    of_match++;
}

Signed-off-by: eric.gao <eric.gao@rock-chips.com>
---

 arch/arm/mach-rockchip/rk3399/syscon_rk3399.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-rockchip/rk3399/syscon_rk3399.c b/arch/arm/mach-rockchip/rk3399/syscon_rk3399.c
index d32985b..74d4552 100644
--- a/arch/arm/mach-rockchip/rk3399/syscon_rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/syscon_rk3399.c
@@ -14,6 +14,7 @@ static const struct udevice_id rk3399_syscon_ids[] = {
 	{ .compatible = "rockchip,rk3399-pmugrf", .data = ROCKCHIP_SYSCON_PMUGRF },
 	{ .compatible = "rockchip,rk3399-pmusgrf", .data = ROCKCHIP_SYSCON_PMUSGRF },
 	{ .compatible = "rockchip,rk3399-cic", .data = ROCKCHIP_SYSCON_CIC },
+	{ }
 };
 
 U_BOOT_DRIVER(syscon_rk3399) = {
-- 
1.9.1

  reply	other threads:[~2017-04-01 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 14:30 [U-Boot] [PATCH 0/7] Enable MIPI dsi display for rk3399 eric.gao at rock-chips.com
2017-04-01 14:30 ` eric.gao at rock-chips.com [this message]
2017-04-01 14:42 eric.gao at rock-chips.com
2017-04-01 14:42 ` [U-Boot] [PATCH 1/7] system halt when we enable bucks of PMIC rk808 eric.gao at rock-chips.com
2017-04-06  3:44   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491057047-703-2-git-send-email-eric.gao@rock-chips.com \
    --to=eric.gao@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.