[Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension

[Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension

[Peter Maydell]

Commit 001ebaca7b11 fixed some unintended sign extension issues
spotted by Coverity (CID 1005402, 1005403), but didn't catch
all of them. Fix the rest, so we behave consistently whether
'long' is 32 bit or 64 bit.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 disas/cris.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/disas/cris.c b/disas/cris.c
index 30217f1..2dd56de 100644
--- a/disas/cris.c
+++ b/disas/cris.c
@@ -2048,7 +2048,7 @@ print_with_operands (const struct cris_opcode *opcodep,
 	  {
 	    /* We're looking at [pc+], i.e. we need to output an immediate
 	       number, where the size can depend on different things.  */
-	    long number;
+	    int32_t number;
 	    int signedp
 	      = ((*cs == 'z' && (insn & 0x20))
 		 || opcodep->match == BDAP_QUICK_OPCODE);
@@ -2290,7 +2290,7 @@ print_with_operands (const struct cris_opcode *opcodep,
 
 		    if ((prefix_insn & 0x400) && (prefix_insn & 15) == 15)
 		      {
-			long number;
+			int32_t number;
 			unsigned int nbytes;
 
 			/* It's a value.  Get its size.  */
-- 
2.7.4

Re: [Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension

[Edgar E. Iglesias]

On Fri, Mar 31, 2017 at 03:31:11PM +0100, Peter Maydell wrote:
> Commit 001ebaca7b11 fixed some unintended sign extension issues
> spotted by Coverity (CID 1005402, 1005403), but didn't catch
> all of them. Fix the rest, so we behave consistently whether
> 'long' is 32 bit or 64 bit.

Thanks!
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  disas/cris.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/disas/cris.c b/disas/cris.c
> index 30217f1..2dd56de 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -2048,7 +2048,7 @@ print_with_operands (const struct cris_opcode *opcodep,
>  	  {
>  	    /* We're looking at [pc+], i.e. we need to output an immediate
>  	       number, where the size can depend on different things.  */
> -	    long number;
> +	    int32_t number;
>  	    int signedp
>  	      = ((*cs == 'z' && (insn & 0x20))
>  		 || opcodep->match == BDAP_QUICK_OPCODE);
> @@ -2290,7 +2290,7 @@ print_with_operands (const struct cris_opcode *opcodep,
>  
>  		    if ((prefix_insn & 0x400) && (prefix_insn & 15) == 15)
>  		      {
> -			long number;
> +			int32_t number;
>  			unsigned int nbytes;
>  
>  			/* It's a value.  Get its size.  */
> -- 
> 2.7.4
> 

Re: [Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1490970671-20560-1-git-send-email-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1ab4529 disas/cris.c: Avoid unintentional sign extension

=== OUTPUT BEGIN ===
Checking PATCH 1/1: disas/cris.c: Avoid unintentional sign extension...
ERROR: code indent should never use tabs
#24: FILE: disas/cris.c:2051:
+^I    int32_t number;$

ERROR: code indent should never use tabs
#33: FILE: disas/cris.c:2293:
+^I^I^Iint32_t number;$

total: 2 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

Re: [Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension

[Peter Maydell]

On 31 March 2017 at 16:59, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> On Fri, Mar 31, 2017 at 03:31:11PM +0100, Peter Maydell wrote:
>> Commit 001ebaca7b11 fixed some unintended sign extension issues
>> spotted by Coverity (CID 1005402, 1005403), but didn't catch
>> all of them. Fix the rest, so we behave consistently whether
>> 'long' is 32 bit or 64 bit.
>
> Thanks!
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>

Applied to master; thanks.

-- PMM