Re: [Qemu-devel] [PATCH v4] Allow setting NUMA distance for different NUMA nodes

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1491042326-24335-1-git-send-email-he.chen@linux.intel.com
Subject: [Qemu-devel] [PATCH v4] Allow setting NUMA distance for different NUMA nodes

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
78dd9f1 Allow setting NUMA distance for different NUMA nodes

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Allow setting NUMA distance for different NUMA nodes...
WARNING: line over 80 characters
#173: FILE: numa.c:215:
+static void numa_distance_parse(NumaDistOptions *dist, QemuOpts *opts, Error **errp)

ERROR: braces {} are necessary for all arms of this statement
#234: FILE: numa.c:344:
+            if (numa_info[src].present &&
[...]

ERROR: braces {} are necessary for all arms of this statement
#240: FILE: numa.c:350:
+    if (!have_distance)
[...]

total: 2 errors, 1 warnings, 236 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org