* [PATCH] staging: rtl8712: fixed multiple line derefence issue
@ 2017-03-29 18:33 Prasant Jalan
2017-04-03 4:13 ` Prasant Jalan
0 siblings, 1 reply; 4+ messages in thread
From: Prasant Jalan @ 2017-03-29 18:33 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, geliangtang, raphael.beamonte,
vijaikumar.kanagarajan, jrdr.linux, devel, linux-kernel,
Prasant Jalan
Checkpatch emits WARNING: Avoid multiple line dereference.
Trivial indentation improvement helps fix the checkpatch warning.
Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index de88819..10edf00 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt *pkt,
if (padapter->pwrctrlpriv.pwr_mode !=
padapter->registrypriv.power_mgnt) {
del_timer_sync(&pmlmepriv->dhcp_timer);
- r8712_set_ps_mode(padapter, padapter->registrypriv.
- power_mgnt, padapter->registrypriv.smart_ps);
+ r8712_set_ps_mode(padapter,
+ padapter->registrypriv.power_mgnt,
+ padapter->registrypriv.smart_ps);
}
}
}
@@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
&pframe[10], 6);
}
if (pqospriv->qos_option == 1)
- priority[0] = (u8)pxmitframe->
- attrib.priority;
+ priority[0] = (u8)pxmitframe->attrib.priority;
r8712_secmicappend(&micdata, &priority[0], 4);
payload = pframe;
for (curfragnum = 0; curfragnum < pattrib->nr_frags;
curfragnum++) {
payload = (u8 *)RND4((addr_t)(payload));
- payload = payload + pattrib->
- hdrlen + pattrib->iv_len;
+ payload = payload + pattrib->hdrlen +
+ pattrib->iv_len;
if ((curfragnum + 1) == pattrib->nr_frags) {
length = pattrib->last_txcmdsz -
pattrib->hdrlen -
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue
2017-03-29 18:33 [PATCH] staging: rtl8712: fixed multiple line derefence issue Prasant Jalan
@ 2017-04-03 4:13 ` Prasant Jalan
2017-04-03 4:57 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Prasant Jalan @ 2017-04-03 4:13 UTC (permalink / raw)
To: Larry.Finger
Cc: Florian Schilhabel, Greg KH, geliangtang, raphael.beamonte,
vijaikumar.kanagarajan, Souptick Joarder, driverdevel, LKML,
Prasant Jalan
On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
> Checkpatch emits WARNING: Avoid multiple line dereference.
>
> Trivial indentation improvement helps fix the checkpatch warning.
>
> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index de88819..10edf00 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt *pkt,
> if (padapter->pwrctrlpriv.pwr_mode !=
> padapter->registrypriv.power_mgnt) {
> del_timer_sync(&pmlmepriv->dhcp_timer);
> - r8712_set_ps_mode(padapter, padapter->registrypriv.
> - power_mgnt, padapter->registrypriv.smart_ps);
> + r8712_set_ps_mode(padapter,
> + padapter->registrypriv.power_mgnt,
> + padapter->registrypriv.smart_ps);
> }
> }
> }
> @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
> &pframe[10], 6);
> }
> if (pqospriv->qos_option == 1)
> - priority[0] = (u8)pxmitframe->
> - attrib.priority;
> + priority[0] = (u8)pxmitframe->attrib.priority;
> r8712_secmicappend(&micdata, &priority[0], 4);
> payload = pframe;
> for (curfragnum = 0; curfragnum < pattrib->nr_frags;
> curfragnum++) {
> payload = (u8 *)RND4((addr_t)(payload));
> - payload = payload + pattrib->
> - hdrlen + pattrib->iv_len;
> + payload = payload + pattrib->hdrlen +
> + pattrib->iv_len;
> if ((curfragnum + 1) == pattrib->nr_frags) {
> length = pattrib->last_txcmdsz -
> pattrib->hdrlen -
> --
> 2.7.4
>
Hi all,
A gentle reminder for my small patch. Some comments will be most helpful.
Regards, Prasant Jalan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue
2017-04-03 4:13 ` Prasant Jalan
@ 2017-04-03 4:57 ` Joe Perches
2017-04-03 6:08 ` Prasant Jalan
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-04-03 4:57 UTC (permalink / raw)
To: Prasant Jalan, Larry.Finger
Cc: Florian Schilhabel, Greg KH, geliangtang, raphael.beamonte,
vijaikumar.kanagarajan, Souptick Joarder, driverdevel, LKML
On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
> > Checkpatch emits WARNING: Avoid multiple line dereference.
> >
> > Trivial indentation improvement helps fix the checkpatch warning.
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
[]
> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
> > &pframe[10], 6);
> > }
> > if (pqospriv->qos_option == 1)
> > - priority[0] = (u8)pxmitframe->
> > - attrib.priority;
> > + priority[0] = (u8)pxmitframe->attrib.priority;
> > r8712_secmicappend(&micdata, &priority[0], 4);
> > payload = pframe;
> > for (curfragnum = 0; curfragnum < pattrib->nr_frags;
> > curfragnum++) {
> > payload = (u8 *)RND4((addr_t)(payload));
> > - payload = payload + pattrib->
> > - hdrlen + pattrib->iv_len;
> > + payload = payload + pattrib->hdrlen +
> > + pattrib->iv_len;
+= would be shorter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue
2017-04-03 4:57 ` Joe Perches
@ 2017-04-03 6:08 ` Prasant Jalan
0 siblings, 0 replies; 4+ messages in thread
From: Prasant Jalan @ 2017-04-03 6:08 UTC (permalink / raw)
To: Joe Perches
Cc: Larry.Finger, Florian Schilhabel, Greg KH, geliangtang,
raphael.beamonte, vijaikumar.kanagarajan, Souptick Joarder,
driverdevel, LKML
On Mon, Apr 3, 2017 at 10:27 AM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
>> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
>> > Checkpatch emits WARNING: Avoid multiple line dereference.
>> >
>> > Trivial indentation improvement helps fix the checkpatch warning.
> []
>> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> []
>> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
>> > &pframe[10], 6);
>> > }
>> > if (pqospriv->qos_option == 1)
>> > - priority[0] = (u8)pxmitframe->
>> > - attrib.priority;
>> > + priority[0] = (u8)pxmitframe->attrib.priority;
>> > r8712_secmicappend(&micdata, &priority[0], 4);
>> > payload = pframe;
>> > for (curfragnum = 0; curfragnum < pattrib->nr_frags;
>> > curfragnum++) {
>> > payload = (u8 *)RND4((addr_t)(payload));
>> > - payload = payload + pattrib->
>> > - hdrlen + pattrib->iv_len;
>> > + payload = payload + pattrib->hdrlen +
>> > + pattrib->iv_len;
>
> += would be shorter
Hi Joe,
Looks like back to school for me for overlooking such a trivial thing.
Thanks for the pointer, I will update the patch and resend.
Regards, Prasant
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-03 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 18:33 [PATCH] staging: rtl8712: fixed multiple line derefence issue Prasant Jalan
2017-04-03 4:13 ` Prasant Jalan
2017-04-03 4:57 ` Joe Perches
2017-04-03 6:08 ` Prasant Jalan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.