From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbdDCIhc (ORCPT ); Mon, 3 Apr 2017 04:37:32 -0400 Received: from mail-he1eur01on0104.outbound.protection.outlook.com ([104.47.0.104]:28716 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752212AbdDCIh1 (ORCPT ); Mon, 3 Apr 2017 04:37:27 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; From: Peter Rosin To: CC: Peter Rosin , Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , , , Subject: [PATCH 2/9] i2c: arb: gpio-challenge: stop double error reporting Date: Mon, 3 Apr 2017 10:38:31 +0200 Message-ID: <1491208718-32068-3-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491208718-32068-1-git-send-email-peda@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0091.eurprd07.prod.outlook.com (10.165.222.25) To VI1PR0202MB2559.eurprd02.prod.outlook.com (10.173.79.138) X-MS-Office365-Filtering-Correlation-Id: f80b8934-5147-4d29-cd68-08d47a6ca2db X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:P/LygXAI6DaGtYGMDxFzMD1aJCzjHvpMLymaQfH5ponXqR5T69vTj0+DyUCJbfquyVXwFnu6eEZBVeqFsZp5Chu96gmcrab6Iwo3gQYAOYZQRmq3IRdRqRvxko+IC5LHmil6ona8/rLE2TxQsFO0Yvm7dn7oS+XkrP5B8UGKHdxFzAXWUbXSvUfyvIEJPGBdt56EFyhM2MZUdgPh+y5fjYHMhavFye45LRvMMVxPdbTVVhKLb+KQIw1XJyK0VKtayKfGTWoJKkkT7wZXW8r1xvR1F0vbuEQdTA6T1B7gvZ1LZ2hB1YYYCZ8qGKE5aSOE;25:1VJMBIa8nAIrln/XzyNJJCiQ2ADUOmbNPZRPlwuTWK7+LMIqIa9oskiZpJEhcnti+xNoq8N0IAGdrHrOH/mfqlsTjkDIQtYNsgjLFyInZGIPFAk1kF4U4tmw8rAEk0tMbQnxSEiOn+AKZG9hD0/npJkFmRTgK0sD2EhqhFk7MZ13LtWmky+t7MPO4DPUQL2ZUbz/STK+LkvXLvDH1nLwieeLPIiW7ngVWXD8GpcIR68rCOSdypOruDvA/dzls/AoyQiA3Aef7wvSS0os/IBI1FRr7SJf7l7eI8K23vqxkt4O6XcbJfWPbx3VoCo43an7KD6aSWnmfUq/N8KdoUepJIYFUQvZLNVcrf/o9S6xu69xiMoeX6vxHq5nBKupjWbAIAxX+IiFpt0v9F7GOWRiO0QE5EDR/pgLLYj/K11OB002Rumyeg4b8gnBtM3cqi30 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:xa/O2rI5NEdHxdsOSCCgnRw+BUdKpDDNP+waEXAN9yJ3evu2Zb734OWz9AftixCqOHWXFmralY61aVII1FGcOBTpegyhFGqYOPB7i65lA1acMKvtdrSkdjONzXHf3MESKygMalq4ifCoBsZT87MsirzAli91nk1Q7W2Vnta1fTrsQXxQqZcqhft46IIEkZs9tS6p7fDGx91PlLzc6I6nsboHhcivvfLSmi6FD1Mr1ug= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(2016111802025)(6043046)(6072148);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;4:iJqryf93XC2iM2rSF7l+p9VfN9C5Ml9GRRORvMx8Z0jQ83bx6A5Ujca5RhMWDcBgJ5glzbji91QjTDF1EG7w3P18K5rk/edGfXSgWneFMPf283AOeiVANdti0zS0fyli0RKgqhjZVHkm6SOExR7LT5SXBSmzQ5KN0r3RSEzxyKpyKWzOj47QeE7rOu5DBHuo8eLNgw0biSoFxczhnQRB2cK5MOkJ1R5p2CWonqBnQeU+NyOy6vaT6NN6TdKAZoVUlIUi0uex5b7UwgiO2a9eewH77NQnSdxhRVM4T3j4GKZsFS8JWpOz4ugJLBwfIxIbf+dUnO7hHQdS4x1WqAcdGlqXz9a5UpujcSEgVDJV+QDKS+DqGZOokKv/E4rXwuICIvretDHSV+3Y3h1hy9yQ+iIaVTPZMj2XFrLiMk/kaXV++xc4bzLVZ17Ojczk5wEryOdSenNXuInZiStZGxRojKnNegBAzgvmMEQiilk20zRGwPrx5X7y13/qcJTMN2VlBEjjIt+fsfvy17OUGRwL+m20yzCG3/Bgy0QsrzCnHeSl2FCPU/dXe82XyInnsi+cEhqIGoNNAKdGXObI79Ca+RD2zSjAvmoYouujRcB2ofyD2/acsFlmCtZi/hvlJT7dDu3X72eC9JDSCWM+foAPYV7sWBqvZKaaDzcz80gwk+KJoYNagFpFOuAuZs+qOEqR29Sku7jWnSlo45Wcrby1Bm+PTw1zR4+fCZxV/+GfVW/J4BHcLSMm4fq6KZ22fi3zjtpbncobR8mDBAPq+gZafP6ey8DYHAyoKE82v9vsWq/2OceVzdhoT0rDXO/HT+Q1 X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6069001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(74482002)(6916009)(81166006)(6512007)(54906002)(7416002)(86362001)(47776003)(25786009)(50466002)(2950100002)(53936002)(8676002)(5660300001)(6666003)(8666007)(48376002)(6506006)(2351001)(5003940100001)(33646002)(42186005)(3846002)(6116002)(305945005)(6486002)(7736002)(50226002)(2906002)(50986999)(4326008)(189998001)(36756003)(38730400002)(110136004)(66066001)(76176999)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:localhost.localdomain;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0202MB2559;23:HtHR2xJ1mp+giNZp8QeBnWFccd2rLfyHh25R7JX?= =?us-ascii?Q?DBjY5XtzaieAvisdBF5lHcysR93fKum6eID2cqxawVzGWbkR8f7EvGYaIzpc?= =?us-ascii?Q?j1JorWFnfHm0KUre5y8i3BBx5ZbN4FqRyzyo5Lo1wmzEv7B6yj2yWVEskGFS?= =?us-ascii?Q?v2EH0Bqlh9fOeD4jnzCVGBxMFHNE95xN04E/zaIy5NzcNeQppfnqVCZ+Ajpa?= =?us-ascii?Q?YksqJP1ui4xpMt9JqpHSFR6SHXq0YOpEzOxr+HPmt3ChO5Vjc5DlI8/fMMJI?= =?us-ascii?Q?saWRiIRLzLYf3RLSITmgHnlnvpqvSiLnDjANrPG+daIqGvaYG46hnuKcMMcO?= =?us-ascii?Q?/MErytxEvHxbUfVP/jaJBD2rdqCOiimUXTo/+Jkr+kZ/2UNH2GVh9+KwYWAU?= =?us-ascii?Q?JQlqULyP1I4zh4Ow1pqAiMesH8jHTf/BA4ugUfgw7/aHwpbuqnJhjza0SvqG?= =?us-ascii?Q?SDMkUZfiiIY7fyrwblEPgCfliJELA9+ZCnrzRNKS8c7GGy87N5vwm6Egg1a3?= =?us-ascii?Q?ngLIKng4X8mGsNAevChfipF3pdjS1RHMw/tkgDpuqGAfjUP0lcDiCZwEFnZ5?= =?us-ascii?Q?CsWNTl/+CVthvNPBgT7U/1IJLVLdPZcCIBtCbfTYujbTd1mK9Fm3c6S4QqYv?= =?us-ascii?Q?4u9Dy6K3bXCvpzFcxUWlv9l29uzFpwzrH/Vs5x2UFr1EKjxUxL72mw6BCyup?= =?us-ascii?Q?LSYaigbC6gvLvXelsxEJthOX7Puy2HS68Qv5zUdHW+mUREz16YbxZJ68DStP?= =?us-ascii?Q?kjsjyxQANzFGr9aOt3/pEuFft2ap2x/20HsCi63/S2/JN6EgwFusKK8FPX9v?= =?us-ascii?Q?ytlNJm89OmpFGE3bwlRssKVnpH3OSALVlWF46MEhWlGlXeHDV/PcZjJ3qrjL?= =?us-ascii?Q?R5uLWQRhZ5OwriKlZ+O8fZ5X5GDDLGqMsmGxpI+DP/QxuCjrBnaRBUYh/GtJ?= =?us-ascii?Q?WdRm5P5nZ3QzOSq40909lN4/xNymwII1M4sdIZtfzU523R0YpoK9+fgb0Ehz?= =?us-ascii?Q?1oxFBveiw+sTGFoONLNwQc0xF4I2qK+JY/H+5ymXpYL2z6ZNKpRH//FGUdwT?= =?us-ascii?Q?FPWCP371gw5gdoa2Rorfxs9fqn8yDM+ZxcK+RwZC76D0S2caJGHIEiV8BE/t?= =?us-ascii?Q?QQ8iM6KCHM5bHAvHapV728c149lMhkOF12YbNMV2D1fM2NPXpKEwrr0dY8uN?= =?us-ascii?Q?XSsfSBzpGFQKR3UIkXfPJybnS3dlQrTLSDcJU?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:rLVff5TEdEy3y8b9Tv/3POrS8Mf9vaa3XFvSQTsjrRc5eNxgSVKaWKkNeAbdzPeD+4fMgqqM6MF60NQiV+g5V/tSbI/LbKfl+RHlARq8579wNq+bdEd6ARlfxRAUCC9dB4Zzb2JGFYDRcpwWGsYaVduO6drQCj0joLa1CpoOHkINcmcvA4f9d4pklO8qlGRh50z+r2JQfZpgjIfsKptTMQWhIdi79aTn6c2JPzb2m+k7EKgEFEneT9JlxG/WkydmuFaIjDl3hDWaEdOs7oD1HTqgQTofYB1d/8Fn65t4M6tTIsvq/ZVj2UF4VhxeoUBs3ekE2mxkqg2yW3pJEzi+N7dEWwzCYJHGxQqlcHMpyQyzwrizoQFF11O4gEqxBuFBSKnghY8njnvMP4M8AwmZUA==;5:ImalXV1fCgVcy3YCNcIp9S5be6d8WtMYBO/ibhZDKhovBr69ylNg8K+xX2acfPAokxnk1FMdNLwOp5jlkvLg9DjxnFXKy77J+jNLvcy96I3Zd3L0zVXm3RjbmdF9UC71UMcn4Hcuu/bFmQXrI9rIPA==;24:xkCukMSAprfICN9f23GdIdGwOQPszbQJxUEcS2vbHQN2SV0BJfFbUUi33j0s7zJVTr6r5Y+Nu18+OlwN7deEpEZXDvcNO8wj5HpSZ3/YAnY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:3LUT/tKwNSQ2CJjaqT5zkznnXBqmtQvvurvYdlclhOdiy63BvmDSekNL75Kv8pXR880oE2+821U/8xKzcUgqsxreu6taiZcsO26PMZG9+KlKnnw9ULvRRxkuj55N/atWtbYjamIaj8VzYkXzoi1f7YCvOcFetM3n1S7/3tfxjaHDSzcMvBEn4PImLCu71O7GIg+/mxPc57wnKaSprCAiriFtV6RestQSyXTDV6rj3t4XfYPi2HtRom60oggKS3DvrczxdKcrMo4SYoj6zJ4dvIDFsHgl8dnzw4XdwFNJVayBL+OSpPEQ48TmGoPTwLiRambpgRrmzinS+Bjkv+P6bw== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 08:37:16.0382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org i2c_mux_add_adapter already logs a message on failure. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c index 86fc2d4c081b..812b8cff265f 100644 --- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c +++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c @@ -202,10 +202,8 @@ static int i2c_arbitrator_probe(struct platform_device *pdev) /* Actually add the mux adapter */ ret = i2c_mux_add_adapter(muxc, 0, 0, 0); - if (ret) { - dev_err(dev, "Failed to add adapter\n"); + if (ret) i2c_put_adapter(muxc->parent); - } return ret; } -- 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Rosin Subject: [PATCH 2/9] i2c: arb: gpio-challenge: stop double error reporting Date: Mon, 3 Apr 2017 10:38:31 +0200 Message-ID: <1491208718-32068-3-git-send-email-peda@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1491208718-32068-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Peter Rosin , Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org i2c_mux_add_adapter already logs a message on failure. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c index 86fc2d4c081b..812b8cff265f 100644 --- a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c +++ b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c @@ -202,10 +202,8 @@ static int i2c_arbitrator_probe(struct platform_device *pdev) /* Actually add the mux adapter */ ret = i2c_mux_add_adapter(muxc, 0, 0, 0); - if (ret) { - dev_err(dev, "Failed to add adapter\n"); + if (ret) i2c_put_adapter(muxc->parent); - } return ret; } -- 2.1.4