From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdDCIic (ORCPT ); Mon, 3 Apr 2017 04:38:32 -0400 Received: from mail-he1eur01on0104.outbound.protection.outlook.com ([104.47.0.104]:28716 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752306AbdDCIhj (ORCPT ); Mon, 3 Apr 2017 04:37:39 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; From: Peter Rosin To: CC: Peter Rosin , Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , , , Subject: [PATCH 7/9] i2c: mux: reg: stop double error reporting Date: Mon, 3 Apr 2017 10:38:36 +0200 Message-ID: <1491208718-32068-8-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491208718-32068-1-git-send-email-peda@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0091.eurprd07.prod.outlook.com (10.165.222.25) To VI1PR0202MB2559.eurprd02.prod.outlook.com (10.173.79.138) X-MS-Office365-Filtering-Correlation-Id: cca67852-0690-440e-e5ba-08d47a6cad5b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:MVBTtnNCZIyXiPtsR/Jx86grJpF2sCm+J5fnNVdtJVtc5OQ1TGqIDJ+WrSS/PWnXpIFjd+zHspKgO88ZacUieTVaPxyZ0DfRN1z14yhv0RvQp1wYla6ZEm3RULoHy35t98nl2euihNHSz5PPYPqt9l/l0+p+QykdMRTovurAD9V9ZGU9q1ifw/9kQsYr6qNDHEsmsP6EZYmbBtCQad8hXb1J1of5BhH3H+Sjlyf2BiOOc5Vm74D0vfMYdpIof5vW//LV4LlXqO/kNObzebgI+I+Rbya2u+5aBcB9JyzRqp/TJ35H6LSAjufstezIpxvS;25:axO16q/UQuEBtRlFbEWKQYA7zwFtNjxwoRuSKdSZnXoDnLMgU4rcYXqaIH03kWIP9Q8Zqp2lA2qu6cSX9OyoI8eAuQnDhTMS4ftDRdCTspAoPZWo+ZG0pl7GZMyqaFXEiBDVth7W+pNsR2Z7cCDFCBf2ZHVykUsh/UAmIaTjwJ0OoTQTb/7h47ihK4Rw7DROoSq+1AnWQoIXuKX6OFMVHHi7Gzj4FrHIxp2z5bP/B9VxNpNZq9A2uqkwMxJ86HhwbgUO/MFJQ3CfzmxK3z8v9QmkzMBxOGWKXa1cKYwcQrE8YDA//aHlts7HL/AazemY2j0XhA3yeBHKSHsiXpuXDmq+ovAmw1ioKiMf39PEzdjHXwh26xBxq/Rb5qSQdWij8SfApIvoW/3HTG3RBYeNdtZ4VLRJoRM/lDMg0bFMwHuL0RcudH2qthmfy0my+84pwuw1xSHw6KRXAVVM20CYkw== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:nFxds9Up5io8ZgWM6igZw9VAZvvPvWK9WUxnB+3VS7wCiDNuyNbxaRTejN0gEAImNJqUbVWxEtEFT6kVxhOa4YvdTJv01GTuJzRAShVVbVftnuiH1AN14+H1/JHjQ5plBo9dp0O6ML0ESAID8nUaPPeYBOrVG5KcGhwaBfJ7Er0DMHWISNZYDmWkdnvg+q7sx6CKEPiqQwhz/7VBziQywrj2t6CdU5Ylk3/7XzpOsAsK7v3QBv16i59kLwu8RIgW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(2016111802025)(6043046)(6072148);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;4:TzrLDidwIrzInYSP4BJ6UUvPJhH8eD9A5Ma/ZqEMgui1GCJctG3M2RYoH7Bj3VC5A+hs6XpIXb+mg27BuVhWU6kyTbbeTEAS5BVVMXp4KbfWyrqXgkkBmF//sR2/mMyeblpbqjd8M7ey/6H7aGXYsqZhXQ5HBMF8pGELibcoB/Qk3uv1mnY2WBmzdUxQcii1WzSTxpZ+9yCx92aKOvMWBAYqKJkjOAxJG26fEM6KlY5SiwstUPzRD9STbIEfwHvlZ/sHYBv24QxpItb6g0a2Enf7D+JkOLvQXoKmLIvzQ0dnYnrJeLAo93Y8r4fihz4ZWA42kY6ErTOz7Ie33lVIyNUeohKZfj1DOb2EQvyNPDTK0rmumd0kTJeWTJhxGZ06tgvbXwWlc6BA9TxvaA4Wl5gMzajNBRGWhfdHNqOcE+PiZJmJZoV2AgwDgc6ATX+uqnbfm05TDtWSIODC+HLuPZcD/E+19KDZbNYgocuvUbtVe0Nb7YdEV4QBA6vjJjcZGrEq8YCsocxfzcfQlZfrKcDsmTQ0GlbDLmUog32eCjBrmejL7ehQ+p5iM809U/EAgPc7Q19vUIixDBdDjpoYBx2QfB/uO64Af9ubiWKh3L2XkbvKN5EF+F4vEhTH+p+DUTxQcLYLJhuAWUd2JDAdS9h/ZZ+fGt+gfg331+owEPH6Tu8/EZEAro4w2ImyU+x7IbScuQB7/oOhJDjy0Xxx6sdtQxiSbWvEqngF5vTsMYsczClSFRNs0ihM92xIgkABX7UWWYth1BgNBqXJEAV0OWorRnYRerXueRuKuf8VRy5rsV7SxaPeHIkbY5J/0NuV X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6069001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(74482002)(6916009)(81166006)(6512007)(54906002)(7416002)(86362001)(25786009)(2950100002)(53936002)(8676002)(5660300001)(8666007)(48376002)(2351001)(5003940100001)(33646002)(42186005)(3846002)(6116002)(305945005)(6486002)(7736002)(50226002)(2906002)(50986999)(4326008)(189998001)(36756003)(38730400002)(110136004)(66066001)(76176999)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0202MB2559;23:vKctDOPjl2c71RLVQxPkATJdjs1K3nwcv+2Rq5N?= =?us-ascii?Q?PcjEtlnHip5CIVvs5W6T+8cj2BYaRt2yjZkj2NJPadh24fWfNV3qidIDw1N6?= =?us-ascii?Q?DRaT2ihR+r25w12WPcRMPRQWREUSlqEUxji1UOPUL9xHRDJyGP+qTv2ueiO9?= =?us-ascii?Q?ITxVhx+6h1W6Ol4Tx7BLebEcPabp2qLjlt5uOunTeKwXqT1EE/EtYJjMn0bY?= =?us-ascii?Q?dIsJf49RPvVsVEAwVkPCSSHWsbPg2sTqWaHPb9LZj19zjI+1waINvr1lT6uY?= =?us-ascii?Q?31sgUwmjUMPhBSz3DRRSMVgsl3Uqllyr3gUKwcS243UyTFzuGV3cMXGpU4xx?= =?us-ascii?Q?Uji0MS/ndQJ8vfBRZuFghb1Obss8HhQh5O3iq1Zgh5RJjrjN04JIBQ6iYLKu?= =?us-ascii?Q?1UjaS+PNz+SP8xFCdRbzyRZfn1RXT1KdmricMHHzekbC3AOMrQe1P19sQbom?= =?us-ascii?Q?GKNQKkjHMcYKhEU3v3WiwDF8YAPtSpK8L15CDaneBGWjXUI6r9bg50JNX3qP?= =?us-ascii?Q?AD5CBqbvPX0Vh4dfc2YWEtwBr+CMV29vI4XKqMYtews/EXKX6LVFWaUwEw46?= =?us-ascii?Q?KBglGR25tMTv4dUf+KZBqmghVks0x1GA8KJi/HNn5KwTVOt9Iiw48ja48OzK?= =?us-ascii?Q?09xUbtzSGyvJhWpWPJTdRtdjI126569YGEpJdhPkbfr29HrnF3qwGQUZcFtZ?= =?us-ascii?Q?fzNTOkwUhV04qd9bgNMYxYIjBofaMn3Mkq7mslGaGuFsNnrWLPAhMlBDhPek?= =?us-ascii?Q?jSPZwaHk+fw+xJM4lRHRdv/Nb0qEJ94/ze18t3cYSkJtHQQSxWSSOhFLfUUF?= =?us-ascii?Q?12JwML0auKrSOr7asYibaXVo4jLFMIrLt6NGhznP5UdsEG/mCFqfeFnqP5Lw?= =?us-ascii?Q?/x9H6qBbUw1/lRw65dMjW2ZQsku9Bw9R5NsRgGfw9y93AUmdyozXLiOvxqiT?= =?us-ascii?Q?bV7DGw0G+tDUWiAjwWuybKAJ0QuhWL5kDB+nZVmU2mlhBk4Vjd6/OVhpii//?= =?us-ascii?Q?7spQUytTKnPcjfXphYBndwasrhlbl7ESzwptypCjoOBETTA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:vSMybMe1wSXdhFm8+FQYNcgDjVwd9zhLcLn4zvKL36zpeDgYLzq7RUB793uDezRgUyhPSn/U+l5xphmMXKi9YIP6b0+HiQtApacpi/AHPW96buNB9d3FZpA60eEUmDxySRVyevEfdLa0h6q1JLTPaFu9jv0LQ8XT5g8oT67ibrrwrK4/cK55gJiXvegRAU7n7EBM8Nge4E/WTd0Mnou+V8cIpuDKCkQMGTkaJtGuxRpu5FSFPZchbXzAQgYSBuX8B2BvuNjApwhLSVTL7hJLCh+RaLgencGgQe6+UANF+Wmkvmj9Yzpk74NYtusjylg4X0nO21t5cb+QaA6mF3Wi3nSR2ZhLWELBwJrqEv/yCYkmiYlYSahP9VmBa+NnNHbHEtDXk3ICJFsf/sQkDOkIBg==;5:M44wS32nSuKdjG6sHc1+uDc0TzeF9Vf8pwedjZlxvs7NNkXSMgEHElaqu7XevbsjVmL9T+q+v6uOy5urgTVp8SCJaf3opYxN2p+XYIlweZ2Qs7trZ5naMS5VpLEPpS+VLRypUbJ6JMgt0nhicN1z8Q==;24:CNwwHyqsn9mL0hvfl52Rl/WBmJYg6vKKCZCoQlsgoFZjdLfwImuTHX0W6hX+EtpQ1JpYp7fMHUo5fCkRC0gzXpFipJqSeqFs+eYE6sFaxoA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:godUGNDCSa9u/qAvaMFJsCTcuGB8tWFD+n3mURoVJqw6n5c0g5+lrQLowfOd8m83+Hr5kbkM6EHdbhzDJn4koY+YNzRv2c0seeNmdYRy713M+XkTyDQawmovpWPMkPTSa3IV0s6s8oZaSsRu8/b0yqXkrJIk4r/YYD5RsBTB6Q7cefnR5+fBc538XBcvGxRTzk12LieVjj338NNVniD4ZzhE3k7+xEdDQ43x4MdQxy5o0XusRvdXJqxU5l58dGxLR5aldPS1RFtKCyDa0SOlayIcrXc3IN7qGRTFWi2+G6U55bMLH5cH09OvAMDJZYeYCl2RR/Zgiu9meVDSZ9ZpNg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 08:37:33.6649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org i2c_mux_add_adapter already logs a message on failure. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-reg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c index c6a90b4a9c62..406d5059072c 100644 --- a/drivers/i2c/muxes/i2c-mux-reg.c +++ b/drivers/i2c/muxes/i2c-mux-reg.c @@ -222,10 +222,8 @@ static int i2c_mux_reg_probe(struct platform_device *pdev) class = mux->data.classes ? mux->data.classes[i] : 0; ret = i2c_mux_add_adapter(muxc, nr, mux->data.values[i], class); - if (ret) { - dev_err(&pdev->dev, "Failed to add adapter %d\n", i); + if (ret) goto add_adapter_failed; - } } dev_dbg(&pdev->dev, "%d port mux on %s adapter\n", -- 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Rosin Subject: [PATCH 7/9] i2c: mux: reg: stop double error reporting Date: Mon, 3 Apr 2017 10:38:36 +0200 Message-ID: <1491208718-32068-8-git-send-email-peda@axentia.se> References: <1491208718-32068-1-git-send-email-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1491208718-32068-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Peter Rosin , Wolfram Sang , Peter Korsgaard , Guenter Roeck , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mauro Carvalho Chehab , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org i2c_mux_add_adapter already logs a message on failure. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-reg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c index c6a90b4a9c62..406d5059072c 100644 --- a/drivers/i2c/muxes/i2c-mux-reg.c +++ b/drivers/i2c/muxes/i2c-mux-reg.c @@ -222,10 +222,8 @@ static int i2c_mux_reg_probe(struct platform_device *pdev) class = mux->data.classes ? mux->data.classes[i] : 0; ret = i2c_mux_add_adapter(muxc, nr, mux->data.values[i], class); - if (ret) { - dev_err(&pdev->dev, "Failed to add adapter %d\n", i); + if (ret) goto add_adapter_failed; - } } dev_dbg(&pdev->dev, "%d port mux on %s adapter\n", -- 2.1.4