From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdDCJCV convert rfc822-to-8bit (ORCPT ); Mon, 3 Apr 2017 05:02:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbdDCJCU (ORCPT ); Mon, 3 Apr 2017 05:02:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E933C03BD6E Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9E933C03BD6E Message-ID: <1491210135.17505.31.camel@redhat.com> Subject: Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create From: Gerd Hoffmann To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, lvivier@redhat.com, open list , "open list:VIRTIO GPU DRIVER" Date: Mon, 03 Apr 2017 11:02:15 +0200 In-Reply-To: <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local> References: <20170403070845.10793-1-kraxel@redhat.com> <20170403070845.10793-3-kraxel@redhat.com> <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 03 Apr 2017 09:02:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mo, 2017-04-03 at 09:53 +0200, Daniel Vetter wrote: > On Mon, Apr 03, 2017 at 09:08:45AM +0200, Gerd Hoffmann wrote: > > Lookup format using virtio_gpu_translate_format() > > instead of hardcoding it. Fixes xorg display on > > bigendian guests (i.e. ppc64). > > > > Signed-off-by: Gerd Hoffmann > > ow ... :( > > With what kind of client have you tested this? fbdev? kms native? text console (fbcon) is fine, xorg (modesetting driver) fails. > Should we patch drm_fourcc.h and essentially state that _all_ drm_fourcc > are in native endian, don't dare mixing things up? Well, I don't think this needs clarification. I never assumed that fourcc is something else than native endian. It really was just an oversight in the virtio driver. One code path (which creates the framebuffer for fbdev emulation) did proper drm_fourcc -> virtio format mapping, including endianness handling. Patch 1/2 of this series factors this code out into a helper function so we can easily reuse it. The other code path (for creating dumb buffers) had the virtio format hardcoded which happened to work correctly in the little endian case. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Date: Mon, 03 Apr 2017 11:02:15 +0200 Message-ID: <1491210135.17505.31.camel@redhat.com> References: <20170403070845.10793-1-kraxel@redhat.com> <20170403070845.10793-3-kraxel@redhat.com> <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32EE5891F8 for ; Mon, 3 Apr 2017 09:02:20 +0000 (UTC) In-Reply-To: <20170403075353.jqxrqshygfidn4f3@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: lvivier@redhat.com, open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gTW8sIDIwMTctMDQtMDMgYXQgMDk6NTMgKzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4g T24gTW9uLCBBcHIgMDMsIDIwMTcgYXQgMDk6MDg6NDVBTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiA+IExvb2t1cCBmb3JtYXQgdXNpbmcgdmlydGlvX2dwdV90cmFuc2xhdGVfZm9ybWF0 KCkKPiA+IGluc3RlYWQgb2YgaGFyZGNvZGluZyBpdC4gIEZpeGVzIHhvcmcgZGlzcGxheSBvbgo+ ID4gYmlnZW5kaWFuIGd1ZXN0cyAoaS5lLiBwcGM2NCkuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6 IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IAo+IG93IC4uLiA6KAo+IAo+IFdp dGggd2hhdCBraW5kIG9mIGNsaWVudCBoYXZlIHlvdSB0ZXN0ZWQgdGhpcz8gZmJkZXY/IGttcyBu YXRpdmU/Cgp0ZXh0IGNvbnNvbGUgKGZiY29uKSBpcyBmaW5lLCB4b3JnIChtb2Rlc2V0dGluZyBk cml2ZXIpIGZhaWxzLgoKPiBTaG91bGQgd2UgcGF0Y2ggZHJtX2ZvdXJjYy5oIGFuZCBlc3NlbnRp YWxseSBzdGF0ZSB0aGF0IF9hbGxfIGRybV9mb3VyY2MKPiBhcmUgaW4gbmF0aXZlIGVuZGlhbiwg ZG9uJ3QgZGFyZSBtaXhpbmcgdGhpbmdzIHVwPwoKV2VsbCwgSSBkb24ndCB0aGluayB0aGlzIG5l ZWRzIGNsYXJpZmljYXRpb24uICBJIG5ldmVyIGFzc3VtZWQgdGhhdApmb3VyY2MgaXMgc29tZXRo aW5nIGVsc2UgdGhhbiBuYXRpdmUgZW5kaWFuLiAgSXQgcmVhbGx5IHdhcyBqdXN0IGFuCm92ZXJz aWdodCBpbiB0aGUgdmlydGlvIGRyaXZlci4KCk9uZSBjb2RlIHBhdGggKHdoaWNoIGNyZWF0ZXMg dGhlIGZyYW1lYnVmZmVyIGZvciBmYmRldiBlbXVsYXRpb24pIGRpZApwcm9wZXIgZHJtX2ZvdXJj YyAtPiB2aXJ0aW8gZm9ybWF0IG1hcHBpbmcsIGluY2x1ZGluZyBlbmRpYW5uZXNzCmhhbmRsaW5n LiAgUGF0Y2ggMS8yIG9mIHRoaXMgc2VyaWVzIGZhY3RvcnMgdGhpcyBjb2RlIG91dCBpbnRvIGEg aGVscGVyCmZ1bmN0aW9uIHNvIHdlIGNhbiBlYXNpbHkgcmV1c2UgaXQuCgpUaGUgb3RoZXIgY29k ZSBwYXRoIChmb3IgY3JlYXRpbmcgZHVtYiBidWZmZXJzKSBoYWQgdGhlIHZpcnRpbyBmb3JtYXQK aGFyZGNvZGVkIHdoaWNoIGhhcHBlbmVkIHRvIHdvcmsgY29ycmVjdGx5IGluIHRoZSBsaXR0bGUg ZW5kaWFuIGNhc2UuCgpjaGVlcnMsCiAgR2VyZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==