From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0212.hostedemail.com ([216.40.44.212]:46511 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751932AbdDCJVI (ORCPT ); Mon, 3 Apr 2017 05:21:08 -0400 Message-ID: <1491211256.27353.58.camel@perches.com> (sfid-20170403_112143_201975_A4808E0A) Subject: Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' From: Joe Perches To: Colin King , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 03 Apr 2017 02:20:56 -0700 In-Reply-To: <20170403091530.18564-1-colin.king@canonical.com> References: <20170403091530.18564-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in wl1271_warning error message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/ti/wlcore/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c > index 58e148d7bc7b..416080adc181 100644 > --- a/drivers/net/wireless/ti/wlcore/debugfs.c > +++ b/drivers/net/wireless/ti/wlcore/debugfs.c > @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file, > } > > if (wl->conf.fwlog.output == 0) { > - wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf"); > + wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf"); Hi Colin. When you do these would you please fix all the typos on the same line? opperation -> operation Also, generally, invalid is a better word choice than illegal for these situations. Thanks and cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Date: Mon, 03 Apr 2017 02:20:56 -0700 Message-ID: <1491211256.27353.58.camel@perches.com> References: <20170403091530.18564-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Colin King , Kalle Valo , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <20170403091530.18564-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in wl1271_warning error message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/ti/wlcore/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c > index 58e148d7bc7b..416080adc181 100644 > --- a/drivers/net/wireless/ti/wlcore/debugfs.c > +++ b/drivers/net/wireless/ti/wlcore/debugfs.c > @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file, > } > > if (wl->conf.fwlog.output == 0) { > - wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf"); > + wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf"); Hi Colin. When you do these would you please fix all the typos on the same line? opperation -> operation Also, generally, invalid is a better word choice than illegal for these situations. Thanks and cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 03 Apr 2017 09:20:56 +0000 Subject: Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Message-Id: <1491211256.27353.58.camel@perches.com> List-Id: References: <20170403091530.18564-1-colin.king@canonical.com> In-Reply-To: <20170403091530.18564-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in wl1271_warning error message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/ti/wlcore/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c > index 58e148d7bc7b..416080adc181 100644 > --- a/drivers/net/wireless/ti/wlcore/debugfs.c > +++ b/drivers/net/wireless/ti/wlcore/debugfs.c > @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file, > } > > if (wl->conf.fwlog.output = 0) { > - wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf"); > + wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf"); Hi Colin. When you do these would you please fix all the typos on the same line? opperation -> operation Also, generally, invalid is a better word choice than illegal for these situations. Thanks and cheers, Joe