[PATCH] busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

[PATCH] busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

[Andre McCurdy]

EXTRA_OEMAKE no longer contains '-e MAKEFLAGS=' so the comment
explaining that it needs to be removed / over-ridden is obsolete.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-core/busybox/busybox.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 6246c95..375632d 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -18,7 +18,6 @@ BUSYBOX_SPLIT_SUID ?= "1"
 export EXTRA_CFLAGS = "${CFLAGS}"
 export EXTRA_LDFLAGS = "${LDFLAGS}"
 
-# We don't want '-e MAKEFLAGS=' in EXTRA_OEMAKE
 EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y HOSTCC='${BUILD_CC}' HOSTCPP='${BUILD_CPP}'"
 
 PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
-- 
1.9.1

Re: [PATCH] busybox.inc: drop comment explaining '-e MAKEFLAGS=' in EXTRA_OEMAKE

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Andre McCurdy
> Sent: den 4 april 2017 03:59
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] busybox.inc: drop comment explaining '-e
> MAKEFLAGS=' in EXTRA_OEMAKE
> 
> EXTRA_OEMAKE no longer contains '-e MAKEFLAGS=' so the comment
> explaining that it needs to be removed / over-ridden is obsolete.
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/recipes-core/busybox/busybox.inc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-
> core/busybox/busybox.inc
> index 6246c95..375632d 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -18,7 +18,6 @@ BUSYBOX_SPLIT_SUID ?= "1"
>  export EXTRA_CFLAGS = "${CFLAGS}"
>  export EXTRA_LDFLAGS = "${LDFLAGS}"
> 
> -# We don't want '-e MAKEFLAGS=' in EXTRA_OEMAKE
>  EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y HOSTCC='${BUILD_CC}' HOSTCPP='${BUILD_CPP}'"

Given that the comment presumably was there to explain why 
"EXTRA_OEMAKE = ..." is used rather than the customary 
"EXTRA_OEMAKE += ...", maybe the code should be changed to 
actually use += instead now that EXTRA_OEMAKE no longer 
contains -e by default.

>  PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
> --
> 1.9.1

//Peter