All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/sfc: do not dereference pointer before check vs NULL
@ 2017-04-04 12:49 Andrew Rybchenko
  2017-04-04 13:17 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2017-04-04 12:49 UTC (permalink / raw)
  To: dev

Coverity issue: 1423925
Fixes: e18dbbd3083a ("net/sfc: remove EvQ info array to simplify reconfigure")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Andy Moreton <amoreton@solarflare.com>
---
It may be squashed into e18dbbd3083a.

 drivers/net/sfc/sfc_ev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
index 26e6b2f..160d39f 100644
--- a/drivers/net/sfc/sfc_ev.c
+++ b/drivers/net/sfc/sfc_ev.c
@@ -673,11 +673,12 @@ sfc_ev_qstart(struct sfc_evq *evq, unsigned int hw_index)
 void
 sfc_ev_qstop(struct sfc_evq *evq)
 {
-	struct sfc_adapter *sa = evq->sa;
+	if (evq == NULL)
+		return;
 
-	sfc_log_init(sa, "hw_index=%u", evq->evq_index);
+	sfc_log_init(evq->sa, "hw_index=%u", evq->evq_index);
 
-	if (evq == NULL || evq->init_state != SFC_EVQ_STARTED)
+	if (evq->init_state != SFC_EVQ_STARTED)
 		return;
 
 	evq->init_state = SFC_EVQ_INITIALIZED;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/sfc: do not dereference pointer before check vs NULL
  2017-04-04 12:49 [PATCH] net/sfc: do not dereference pointer before check vs NULL Andrew Rybchenko
@ 2017-04-04 13:17 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-04-04 13:17 UTC (permalink / raw)
  To: Andrew Rybchenko, dev

On 4/4/2017 1:49 PM, Andrew Rybchenko wrote:
> Coverity issue: 1423925
> Fixes: e18dbbd3083a ("net/sfc: remove EvQ info array to simplify reconfigure")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Andy Moreton <amoreton@solarflare.com>
> ---
> It may be squashed into e18dbbd3083a.

Squashed into relevant commit in next-net, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-04 13:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 12:49 [PATCH] net/sfc: do not dereference pointer before check vs NULL Andrew Rybchenko
2017-04-04 13:17 ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.