Re: [PATCH libdrm 2/2] Add CRTC ID to vblank event

[Daniel Stone <daniels@collabora.com>]

Hi Emil,

On Tue, 2017-04-04 at 18:12 +0100, Emil Velikov wrote:
> On 4 April 2017 at 17:52, Daniel Stone <daniels@collabora.com> wrote:
> > @@ -846,7 +847,7 @@ struct drm_event_vblank {
> >         __u32 tv_sec;
> >         __u32 tv_usec;
> >         __u32 sequence;
> > -       __u32 reserved;
> > +       __u32 crtc_id;
> >  };
> > 
> 
> Please split these to a separate commit as mentioned in
> include/drm/README "When and how to update these files" ?

OK, will do.

> > @@ -728,7 +728,7 @@ extern void drmMsg(const char *format, ...)
> > DRM_PRINTFLIKE(1, 2);
> >  extern int drmSetMaster(int fd);
> >  extern int drmDropMaster(int fd);
> > 
> > -#define DRM_EVENT_CONTEXT_VERSION 2
> > +#define DRM_EVENT_CONTEXT_VERSION 3
> > 
> 
> We really want to fix weston to _not_ use this define, but to set the
> version it actually supports/implements.
> I'll send a patch for that in a minute.

One step ahead of you:
-       evctx.version = DRM_EVENT_CONTEXT_VERSION;
-       evctx.page_flip_handler = page_flip_handler;
+       evctx.version = 3;

https://lists.freedesktop.org/archives/wayland-devel/2017-April/033747.
html

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel