All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Chen <Wei.Chen@arm.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.chen@arm.com, steve.capper@arm.com,
	Kaly.Xin@arm.com, julien.grall@arm.com, nd@arm.com
Subject: [PATCH v4 19/19] xen/arm: Handle guest external abort as guest SError
Date: Wed, 5 Apr 2017 17:09:21 +0800	[thread overview]
Message-ID: <1491383361-22886-20-git-send-email-Wei.Chen@arm.com> (raw)
In-Reply-To: <1491383361-22886-1-git-send-email-Wei.Chen@arm.com>

The guest generated external data/instruction aborts can be treated
as guest SErrors. We already have a handler to handle the SErrors,
so we can reuse this handler to handle guest external aborts.

Signed-off-by: Wei Chen <Wei.Chen@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
 xen/arch/arm/traps.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index c8163db..3625e04 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -2583,12 +2583,12 @@ static void do_trap_instr_abort_guest(struct cpu_user_regs *regs,
 
     /*
      * If this bit has been set, it means that this instruction abort is caused
-     * by a guest external abort. Currently we crash the guest to protect the
-     * hypervisor. In future one can better handle this by injecting a virtual
-     * abort to the guest.
+     * by a guest external abort. We can handle this instruction abort as guest
+     * SError.
      */
     if ( hsr.iabt.eat )
-        domain_crash_synchronous();
+        return __do_trap_serror(regs, true);
+
 
     if ( hpfar_is_valid(hsr.iabt.s1ptw, fsc) )
         gpa = get_faulting_ipa(gva);
@@ -2715,12 +2715,10 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
 
     /*
      * If this bit has been set, it means that this data abort is caused
-     * by a guest external abort. Currently we crash the guest to protect the
-     * hypervisor. In future one can better handle this by injecting a virtual
-     * abort to the guest.
+     * by a guest external abort. We treat this data abort as guest SError.
      */
     if ( dabt.eat )
-        domain_crash_synchronous();
+        return __do_trap_serror(regs, true);
 
     info.dabt = dabt;
 #ifdef CONFIG_ARM_32
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-04-05  9:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  9:09 [PATCH v4 00/19] Provide a command line option to choose how to handle SErrors Wei Chen
2017-04-05  9:09 ` [PATCH v4 01/19] xen/arm: Save ESR_EL2 to avoid using mismatched value in syndrome check Wei Chen
2017-04-05  9:09 ` [PATCH v4 02/19] xen/arm: Introduce a helper to get default HCR_EL2 flags Wei Chen
2017-04-05  9:09 ` [PATCH v4 03/19] xen/arm: Set and restore HCR_EL2 register for each vCPU separately Wei Chen
2017-04-05  9:09 ` [PATCH v4 04/19] xen/arm: Avoid setting/clearing HCR_RW at every context switch Wei Chen
2017-04-05  9:09 ` [PATCH v4 05/19] xen/arm: Save HCR_EL2 when a guest took the SError Wei Chen
2017-04-05  9:09 ` [PATCH v4 06/19] xen/arm: Introduce a virtual abort injection helper Wei Chen
2017-04-05  9:09 ` [PATCH v4 07/19] xen/arm: Introduce a command line parameter for SErrors/Aborts Wei Chen
2017-04-05  9:09 ` [PATCH v4 08/19] xen/arm: Introduce a initcall to update cpu_hwcaps by serror_op Wei Chen
2017-04-05  9:09 ` [PATCH v4 09/19] xen/arm64: Use alternative to skip the check of pending serrors Wei Chen
2017-04-05  9:09 ` [PATCH v4 10/19] xen/arm32: " Wei Chen
2017-04-05  9:09 ` [PATCH v4 11/19] xen/arm: Move macro VABORT_GEN_BY_GUEST to common header Wei Chen
2017-04-05  9:09 ` [PATCH v4 12/19] xen/arm: Introduce new helpers to handle guest/hyp SErrors Wei Chen
2017-04-05  9:09 ` [PATCH v4 13/19] xen/arm: Replace do_trap_guest_serror with new helpers Wei Chen
2017-04-05  9:09 ` [PATCH v4 14/19] xen/arm: Unmask the Abort/SError bit in the exception entries Wei Chen
2017-04-05  9:09 ` [PATCH v4 15/19] xen/arm: Introduce a helper to check local abort is enabled Wei Chen
2017-04-05 11:14   ` Julien Grall
2017-04-05  9:09 ` [PATCH v4 16/19] xen/arm: Introduce a macro to synchronize SError Wei Chen
2017-04-05 11:15   ` Julien Grall
2017-04-05  9:09 ` [PATCH v4 17/19] xen/arm: Isolate the SError between the context switch of 2 vCPUs Wei Chen
2017-04-05  9:09 ` [PATCH v4 18/19] xen/arm: Prevent slipping hypervisor SError to guest Wei Chen
2017-04-05 11:17   ` Julien Grall
2017-04-05  9:09 ` Wei Chen [this message]
2017-04-05 19:18 ` [PATCH v4 00/19] Provide a command line option to choose how to handle SErrors Stefano Stabellini
2017-04-06  4:52   ` Wei Chen
2017-04-07 15:37   ` Julien Grall
2017-04-07 23:20     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491383361-22886-20-git-send-email-Wei.Chen@arm.com \
    --to=wei.chen@arm.com \
    --cc=Kaly.Xin@arm.com \
    --cc=julien.grall@arm.com \
    --cc=nd@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=steve.capper@arm.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.