All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Krummenacher <max.oss.09@gmail.com>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>,
	Fabio Estevam <festevam@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Timur Tabi <timur@tabi.org>, Caleb Crome <caleb@crome.org>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2] ASoC: fsl_ssi: Fix channel swap on playback start
Date: Wed, 05 Apr 2017 16:04:30 +0200	[thread overview]
Message-ID: <1491401070.1810.10.camel@gmail.com> (raw)
In-Reply-To: <2c31e502-4171-7426-1c24-c258a4d02c55@invoxia.com>

(resend from my alsa-devel registered email address)

On Wed, 2017-04-05 at 09:54 +0200, Arnaud Mouiche wrote:
> 
> 
> On 04/04/2017 22:28, Fabio Estevam wrote:
> > 
> > 
> > On Tue, Apr 4, 2017 at 5:09 PM, Arnaud Mouiche
> > <arnaud.mouiche@invoxia.com> wrote:
> > 
> > > 
> > > 
> > > SCR bit 3 (NET) is also set, so you should be in network mode with a long
> > > frame sync.
> > > In fact, you can entirely simulate a I2S behavior using Network mode. you
> > > should just be careful about the way everything is configured (eg. place of
> > > samples in the stream)
> > While debugging this issue I noticed that when I put the oscilloscope
> > probe in the LRCLK SGTL5000 pin the swap did not occur anymore.
> > 
> > After removing the probe the swap occurred frequently.
> > 
> > So decided to change the SGTL5000 LRCLK pin strength value:
> > 
> > --- a/sound/soc/codecs/sgtl5000.c
> > +++ b/sound/soc/codecs/sgtl5000.c
> > @@ -1118,7 +1118,7 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
> >                          SGTL5000_DAC_MUTE_RIGHT |
> >                          SGTL5000_DAC_MUTE_LEFT);
> > 
> > -       snd_soc_write(codec, SGTL5000_CHIP_PAD_STRENGTH, 0x015f);
> > +       snd_soc_write(codec, SGTL5000_CHIP_PAD_STRENGTH, 0x035f);
> > 
> >          snd_soc_write(codec, SGTL5000_CHIP_ANA_CTRL,
> >                          SGTL5000_HP_ZCD_EN |
> > 
> > and the swap does not happen.
> > 
> > So it seems that no change is needed on the imx-ssi side :-)
> Good catch. All of this makes sense.
> The SSI surely detect a glitch at the start of the stream and takes it 
> for a sync frame, but not followed by the expected 32x2 bits.
> It also explain why Caleb and I are not able to reproduce, since we 
> connect SSI internally using the audmux, leaving no place for such glitch.
> 
> If only Max can validate this fix...

Reverting the previous patch (setting TE and RE) and changing the drive
strenght to 0x035f fixes the channel swap on the Colibri iMX6DL.
e.g. 1000 playback starts do all have the correct channel assignment.

Looks like having the the LRCLK a bit earlier through the increased drive
strength changes the timing in a way that when the SSI samples that signal
with its correct state.
Probably the previous patch with TE and RE changes the sampling time in
the SSI which made it work in our use case.

Max

> 
> But what is strange is that writing TE and EN at once also avoid the 
> issue... or it means the issue was really timing dependent.
> 
> Do you know which one is started first ?
> - fsl_ssi_trigger(SNDRV_PCM_TRIGGER_START)
> or
> - stgl5000 PCM bus being turned on
> 
> We can expect that stgl5000 turns the PCM clocks first, and then SSI is 
> turned on. Otherwise anything can happened when the codec starts its 
> clocking.
> 
> Maybe we should look at the Fsync state when idle, and see how it behave 
> during the startup. Depending of pull-up /down-down configuration of the 
> pads, it may be leaved in a undefined state with undefined transitions 
> when stgl5000 turns its output on...
> 
> Another way to definitively fix this kind of issue is to use 
> SND_SOC_DAIFMT_CBS_CFS
> - the codec generates the N*8*64 kHz or 44.1*64 kHz precise bitclock 
> (something which is not flexible for the SSI who is connected to a fix 
> PLL output clock)
> - but the SSI generate the Sync, leaving no place for wrong detection.
> Unfortunately, stgl5000 doesn't seem to support this mode.
> 
> Arnaud
> 

  parent reply	other threads:[~2017-04-05 14:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 14:48 Fabio Estevam
2017-04-01 15:13 ` Arnaud Mouiche
2017-04-01 16:03   ` Fabio Estevam
2017-04-03  8:19 ` Max Krummenacher
2017-04-03 20:32 ` Caleb Crome
2017-04-03 20:50   ` Caleb Crome
2017-04-03 21:53   ` Fabio Estevam
2017-04-03 22:05     ` Arnaud Mouiche
2017-04-03 22:20       ` Nicolin Chen
2017-04-03 23:22     ` Caleb Crome
2017-04-03 23:40       ` Fabio Estevam
2017-04-03 23:42         ` Caleb Crome
2017-04-04  8:59           ` Arnaud Mouiche
2017-04-04  9:03             ` Arnaud Mouiche
2017-04-04 11:38             ` Fabio Estevam
2017-04-04 17:12               ` Fabio Estevam
2017-04-04 20:09                 ` Arnaud Mouiche
2017-04-04 20:28                   ` Fabio Estevam
2017-04-05  7:54                     ` Arnaud Mouiche
2017-04-05 13:43                       ` Fabio Estevam
2017-04-05 14:04                       ` Max Krummenacher [this message]
2017-04-03 22:08   ` Nicolin Chen
2017-04-03 23:31     ` Caleb Crome
2017-04-03 23:55       ` Nicolin Chen
2017-04-04  0:07         ` Timur Tabi
2017-04-04  0:39         ` Caleb Crome
2017-04-04  1:25           ` Nicolin Chen
2017-04-03 22:36 ` Nicolin Chen
2017-04-03 22:54   ` Fabio Estevam
2017-04-04  0:08     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491401070.1810.10.camel@gmail.com \
    --to=max.oss.09@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.mouiche@invoxia.com \
    --cc=broonie@kernel.org \
    --cc=caleb@crome.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=nicoleotsuka@gmail.com \
    --cc=timur@tabi.org \
    --subject='Re: [PATCH v2] ASoC: fsl_ssi: Fix channel swap on playback start' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.