* [PATCH] exynos: add C++ support to exynos_drmif header
@ 2017-04-05 14:22 Tobias Jakobi
2017-04-05 15:48 ` Eric Engestrom
0 siblings, 1 reply; 5+ messages in thread
From: Tobias Jakobi @ 2017-04-05 14:22 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: sw0312.kim, emil.l.velikov, dri-devel, Tobias Jakobi
Add the usual extern "C" when compiling in C++ mode.
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
exynos/exynos_drmif.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
index 626e399..154439b 100644
--- a/exynos/exynos_drmif.h
+++ b/exynos/exynos_drmif.h
@@ -31,6 +31,10 @@
#include <stdint.h>
#include "exynos_drm.h"
+#if defined(__cplusplus)
+extern "C" {
+#endif
+
struct exynos_device {
int fd;
};
@@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
struct exynos_event_context *ctx);
+#if defined(__cplusplus)
+}
+#endif
+
#endif /* EXYNOS_DRMIF_H_ */
--
2.7.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] exynos: add C++ support to exynos_drmif header
2017-04-05 14:22 [PATCH] exynos: add C++ support to exynos_drmif header Tobias Jakobi
@ 2017-04-05 15:48 ` Eric Engestrom
2017-04-05 16:23 ` Tobias Jakobi
0 siblings, 1 reply; 5+ messages in thread
From: Eric Engestrom @ 2017-04-05 15:48 UTC (permalink / raw)
To: Tobias Jakobi; +Cc: emil.l.velikov, linux-samsung-soc, sw0312.kim, dri-devel
On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
> Add the usual extern "C" when compiling in C++ mode.
Thanks, but why specifically this header? The other exynos/*.h headers
also lack the c++ mangling guard.
A quick grep shows that only 15/101 headers in libdrm have it.
Can I interest you in fixing a few more headers? :)
In any case, this patch is:
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
(I assume you'll push it yourself?)
Btw, can you run this in your local libdrm repo?
$ git config --local format.subjectPrefix "PATCH libdrm"
Cheers,
Eric
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> exynos/exynos_drmif.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
> index 626e399..154439b 100644
> --- a/exynos/exynos_drmif.h
> +++ b/exynos/exynos_drmif.h
> @@ -31,6 +31,10 @@
> #include <stdint.h>
> #include "exynos_drm.h"
>
> +#if defined(__cplusplus)
> +extern "C" {
> +#endif
> +
> struct exynos_device {
> int fd;
> };
> @@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
> struct exynos_event_context *ctx);
>
>
> +#if defined(__cplusplus)
> +}
> +#endif
> +
> #endif /* EXYNOS_DRMIF_H_ */
> --
> 2.7.3
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] exynos: add C++ support to exynos_drmif header
2017-04-05 15:48 ` Eric Engestrom
@ 2017-04-05 16:23 ` Tobias Jakobi
2017-04-08 20:45 ` Emil Velikov
0 siblings, 1 reply; 5+ messages in thread
From: Tobias Jakobi @ 2017-04-05 16:23 UTC (permalink / raw)
To: Eric Engestrom; +Cc: linux-samsung-soc, sw0312.kim, emil.l.velikov, dri-devel
Hello Eric,
Eric Engestrom wrote:
> On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
>> Add the usual extern "C" when compiling in C++ mode.
>
> Thanks, but why specifically this header? The other exynos/*.h headers
> also lack the c++ mangling guard.
I'm currently writing a small C++ project using the
exynos_bo_{create,destroy}() calls, and noticed this.
> A quick grep shows that only 15/101 headers in libdrm have it.
> Can I interest you in fixing a few more headers? :)
Not at the moment.
- Tobias
> In any case, this patch is:
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> (I assume you'll push it yourself?)
>
> Btw, can you run this in your local libdrm repo?
> $ git config --local format.subjectPrefix "PATCH libdrm"
>
> Cheers,
> Eric
>
>
>>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> exynos/exynos_drmif.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
>> index 626e399..154439b 100644
>> --- a/exynos/exynos_drmif.h
>> +++ b/exynos/exynos_drmif.h
>> @@ -31,6 +31,10 @@
>> #include <stdint.h>
>> #include "exynos_drm.h"
>>
>> +#if defined(__cplusplus)
>> +extern "C" {
>> +#endif
>> +
>> struct exynos_device {
>> int fd;
>> };
>> @@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
>> struct exynos_event_context *ctx);
>>
>>
>> +#if defined(__cplusplus)
>> +}
>> +#endif
>> +
>> #endif /* EXYNOS_DRMIF_H_ */
>> --
>> 2.7.3
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] exynos: add C++ support to exynos_drmif header
2017-04-05 16:23 ` Tobias Jakobi
@ 2017-04-08 20:45 ` Emil Velikov
2017-04-08 22:47 ` Tobias Jakobi
0 siblings, 1 reply; 5+ messages in thread
From: Emil Velikov @ 2017-04-08 20:45 UTC (permalink / raw)
To: Tobias Jakobi
Cc: Eric Engestrom, moderated list:ARM/S5P EXYNOS AR...,
Seung-Woo Kim, ML dri-devel
On 5 April 2017 at 17:23, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
> Hello Eric,
>
>
> Eric Engestrom wrote:
>> On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
>>> Add the usual extern "C" when compiling in C++ mode.
>>
>> Thanks, but why specifically this header? The other exynos/*.h headers
>> also lack the c++ mangling guard.
> I'm currently writing a small C++ project using the
> exynos_bo_{create,destroy}() calls, and noticed this.
>
>> A quick grep shows that only 15/101 headers in libdrm have it.
>> Can I interest you in fixing a few more headers? :)
> Not at the moment.
>
FTR, only the installed headers (~50) need the extern C guard.
None of that is not a blocker for this patch, so I've just pushed it to master.
Thanks!
Emil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] exynos: add C++ support to exynos_drmif header
2017-04-08 20:45 ` Emil Velikov
@ 2017-04-08 22:47 ` Tobias Jakobi
0 siblings, 0 replies; 5+ messages in thread
From: Tobias Jakobi @ 2017-04-08 22:47 UTC (permalink / raw)
To: Emil Velikov
Cc: Eric Engestrom, moderated list:ARM/S5P EXYNOS AR...,
Seung-Woo Kim, ML dri-devel
Emil Velikov wrote:
> FTR, only the installed headers (~50) need the extern C guard.
> None of that is not a blocker for this patch, so I've just pushed it to master.
Thanks Emil. I'll see what I can do about the other ones.
- Tobias
> Thanks!
> Emil
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-08 22:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 14:22 [PATCH] exynos: add C++ support to exynos_drmif header Tobias Jakobi
2017-04-05 15:48 ` Eric Engestrom
2017-04-05 16:23 ` Tobias Jakobi
2017-04-08 20:45 ` Emil Velikov
2017-04-08 22:47 ` Tobias Jakobi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.