* [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X
@ 2017-04-05 14:46 Tom Rini
2017-04-05 15:36 ` Stefano Babic
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2017-04-05 14:46 UTC (permalink / raw)
To: u-boot
When this board was switched to using more DM drivers we didn't disable
the legacy PCA953X driver. This in turn learn to a build time warning
about implicit functions as i2c.h would not say anything about
'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of
the legacy driver would be linked in either.
Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
include/configs/mx6sxsabreauto.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h
index 0742b4bf2ec9..448b575c2897 100644
--- a/include/configs/mx6sxsabreauto.h
+++ b/include/configs/mx6sxsabreauto.h
@@ -182,7 +182,4 @@
#define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/
#endif
-#define CONFIG_PCA953X
-#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} }
-
#endif /* __CONFIG_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X
2017-04-05 14:46 [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X Tom Rini
@ 2017-04-05 15:36 ` Stefano Babic
2017-04-05 17:43 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Babic @ 2017-04-05 15:36 UTC (permalink / raw)
To: u-boot
On 05/04/2017 16:46, Tom Rini wrote:
> When this board was switched to using more DM drivers we didn't disable
> the legacy PCA953X driver. This in turn learn to a build time warning
> about implicit functions as i2c.h would not say anything about
> 'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of
> the legacy driver would be linked in either.
>
> Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> include/configs/mx6sxsabreauto.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h
> index 0742b4bf2ec9..448b575c2897 100644
> --- a/include/configs/mx6sxsabreauto.h
> +++ b/include/configs/mx6sxsabreauto.h
> @@ -182,7 +182,4 @@
> #define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/
> #endif
>
> -#define CONFIG_PCA953X
> -#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} }
> -
> #endif /* __CONFIG_H */
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X
2017-04-05 15:36 ` Stefano Babic
@ 2017-04-05 17:43 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-05 17:43 UTC (permalink / raw)
To: u-boot
On Wed, Apr 05, 2017 at 05:36:42PM +0200, Stefano Babic wrote:
> On 05/04/2017 16:46, Tom Rini wrote:
> > When this board was switched to using more DM drivers we didn't disable
> > the legacy PCA953X driver. This in turn learn to a build time warning
> > about implicit functions as i2c.h would not say anything about
> > 'i2c_read' nor 'i2c_write'. But this was not a fatal error as none of
> > the legacy driver would be linked in either.
> >
> > Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers")
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > include/configs/mx6sxsabreauto.h | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h
> > index 0742b4bf2ec9..448b575c2897 100644
> > --- a/include/configs/mx6sxsabreauto.h
> > +++ b/include/configs/mx6sxsabreauto.h
> > @@ -182,7 +182,4 @@
> > #define CONFIG_SYS_MMC_ENV_DEV 0 /*USDHC3*/
> > #endif
> >
> > -#define CONFIG_PCA953X
> > -#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x30, 8}, {0x32, 8}, {0x34, 8} }
> > -
> > #endif /* __CONFIG_H */
> >
>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170405/76fdb44b/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-05 17:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 14:46 [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X Tom Rini
2017-04-05 15:36 ` Stefano Babic
2017-04-05 17:43 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.