* [PATCH net-next] mlx4: trust shinfo->gso_segs
@ 2017-04-05 15:49 Eric Dumazet
2017-04-05 15:58 ` Saeed Mahameed
2017-04-06 20:28 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2017-04-05 15:49 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Tariq Toukan, Saeed Mahameed
From: Eric Dumazet <edumazet@google.com>
mlx4 is the only driver in the tree making a point to recompute
shinfo->gso_segs.
Lets remove superfluous code.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index e0c5ffb3e3a6607456e1f191b0b8c8becfc71219..3ba89bc43d74d8c023776079bcd0bbadd70fb5c6 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -978,8 +978,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev)
ring->tso_packets++;
- i = ((skb->len - lso_header_size) / shinfo->gso_size) +
- !!((skb->len - lso_header_size) % shinfo->gso_size);
+ i = shinfo->gso_segs;
tx_info->nr_bytes = skb->len + (i - 1) * lso_header_size;
ring->packets += i;
} else {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlx4: trust shinfo->gso_segs
2017-04-05 15:49 [PATCH net-next] mlx4: trust shinfo->gso_segs Eric Dumazet
@ 2017-04-05 15:58 ` Saeed Mahameed
2017-04-06 20:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2017-04-05 15:58 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev, Tariq Toukan, Saeed Mahameed
On Wed, Apr 5, 2017 at 11:49 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> mlx4 is the only driver in the tree making a point to recompute
> shinfo->gso_segs.
>
> Lets remove superfluous code.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Tariq Toukan <tariqt@mellanox.com>
> Cc: Saeed Mahameed <saeedm@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> index e0c5ffb3e3a6607456e1f191b0b8c8becfc71219..3ba89bc43d74d8c023776079bcd0bbadd70fb5c6 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> @@ -978,8 +978,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev)
>
> ring->tso_packets++;
>
> - i = ((skb->len - lso_header_size) / shinfo->gso_size) +
> - !!((skb->len - lso_header_size) % shinfo->gso_size);
> + i = shinfo->gso_segs;
> tx_info->nr_bytes = skb->len + (i - 1) * lso_header_size;
> ring->packets += i;
> } else {
>
>
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlx4: trust shinfo->gso_segs
2017-04-05 15:49 [PATCH net-next] mlx4: trust shinfo->gso_segs Eric Dumazet
2017-04-05 15:58 ` Saeed Mahameed
@ 2017-04-06 20:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-06 20:28 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, tariqt, saeedm
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Apr 2017 08:49:02 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> mlx4 is the only driver in the tree making a point to recompute
> shinfo->gso_segs.
>
> Lets remove superfluous code.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 15:49 [PATCH net-next] mlx4: trust shinfo->gso_segs Eric Dumazet
2017-04-05 15:58 ` Saeed Mahameed
2017-04-06 20:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.