From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934153AbdDFHhi (ORCPT ); Thu, 6 Apr 2017 03:37:38 -0400 Received: from mout.gmx.net ([212.227.15.15]:60020 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbdDFHhb (ORCPT ); Thu, 6 Apr 2017 03:37:31 -0400 Message-ID: <1491464210.4718.82.camel@gmx.de> Subject: Re: [PATCH] sched: Fix numabalancing to work with isolated cpus From: Mike Galbraith To: Srikar Dronamraju , Ingo Molnar , Peter Zijlstra Cc: LKML , Mel Gorman , Rik van Riel Date: Thu, 06 Apr 2017 09:36:50 +0200 In-Reply-To: <1491326848-5748-1-git-send-email-srikar@linux.vnet.ibm.com> References: <1491326848-5748-1-git-send-email-srikar@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JAduVbb6Y24NvvWdIQYQ3VhN2C+5hDAaPOwgP89YbR4iaci93iG sNl6Wjj3hgJbe8nBisS/hx/lFJFsbP48BlVzl4izudBrVVrT++gHtM/hajiiJVHdg/pyWcD AjT9NqYx/0M/JruSFd0qZtnYG9S3A762SHDS2r/JjRJXvR1ATKuHIddJL9N0uLdzlmFRzGe gH2w17KS3fqv6oyTO6tzw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fv5o2lwFvnc=:og8biNip/NrUtSHFKuU8Fh 6+UH5HVFzk8O/oF7LjrfH0A00js1VpdG4FyvSFvuHqE+pjdZ26aaM8skysv1/A20YG8OtKjq1 UQWd1bJr8uYCPd6C4RIJtdfjhWUzSCkzoHxqyMF3rghlD+Xg+PioaMruiWHxP55p0NR8Kg4FL g6VGDZf21bMbpdg6BO/yvKfCr9SVxadoOrjyKnM+wlDegvub9jPObinPNAH3dTyE4xm1jyyhm LdbpSbcXXjfFFvoFxcrDK2eVZ4vRYtwHwCyAcVeF1XL5Ju0uVE+S2WL4C4eQWJzNn1UDJukr6 I+xP4AZPrN4ejlG/FzkNNP0iXxZYHiZj0jW5QNUvjLf/ny2AWCbahl6Nc+7MvifiQ5fXar/V1 VBwwaP2XdkWJ4KVJJxZDq+5c7eLZqlVEgOADYLTEK+g3BIIMfBGejuw+xX18dU2zwTyK+4hbf VFScL/dcpRfIikEO/xc3oh/LXBbitiRj/XlSQ1//Cim4P33iYxXUan8eca5NvQUI9ah3JMdJI f2skYUM0SGtfOPUDo/Tqx1x+97GWoQx4vsc6n6sd5esFuCYokHRHUzlZnJwr+hk9v7GeXr3Gi 5HJU/fqNh0VfIr0K7Nw3Ftmq5XwRNMlJ9q9YKGPiZ32pSLQjsbzWEsjO6FdmRYezdK6adKD/k 4/x9Z2tEfeeKUavGEJ+8VDNQ11h144/c2bIU7f1b0jee45NE5okd+UeEqsM1FZpRiYQDyvnld ilQTJ0h2fRli45kSrhtR7VyPEvN9JhEYjASKfR7wHAIfwCzys0RZv6/uFVyVbhCp9HvO0A2wY uSbeqNJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-04 at 22:57 +0530, Srikar Dronamraju wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index f045a35..f853dc0 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1666,6 +1666,10 @@ static void task_numa_find_cpu(struct task_numa_env *env, > > > > if (!cpumask_test_cpu(cpu, &env->p->cpus_allowed)) > > > > > continue; > > +> > > /* Skip isolated cpus */ > +> > > if (cpumask_test_cpu(cpu, cpu_isolated_map)) > +> > > > continue; Methinks that should check for !cpu_rq(cpu)->sd, so the thing doesn't screw up cpuset isolation either. -Mike