From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756717AbdDFHw2 (ORCPT ); Thu, 6 Apr 2017 03:52:28 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57444 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410AbdDFHwB (ORCPT ); Thu, 6 Apr 2017 03:52:01 -0400 From: Christian Borntraeger To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Hendrik Brueckner , Andreas Krebbel , Peter Zijlstra , Ingo Molnar , linux-s390 , Martin Schwidefsky , Christian Borntraeger Subject: [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10 regression) Date: Thu, 6 Apr 2017 09:51:51 +0200 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491465112-45819-1-git-send-email-borntraeger@de.ibm.com> References: <1491465112-45819-1-git-send-email-borntraeger@de.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17040607-0020-0000-0000-0000033D316C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040607-0021-0000-0000-00004126C37F Message-Id: <1491465112-45819-2-git-send-email-borntraeger@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-06_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704060067 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org since 4.10 perf annotate exits on s390 with an "unknown error -95". Turns out that commit 786c1b51844d ("perf annotate: Start supporting cross arch annotation") added a hard requirement for architecture support when objdump is used but only provided x86 and arm support. Meanwhile power was added so lets add s390 as well. While at it make sure to implement the branch and jump types. Signed-off-by: Christian Borntraeger Fixes: 786c1b51844 "perf annotate: Start supporting cross arch annotation" Cc: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 273f21f..7aa5722 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -130,6 +130,12 @@ static struct arch architectures[] = { .name = "powerpc", .init = powerpc__annotate_init, }, + { + .name = "s390", + .objdump = { + .comment_char = '#', + }, + }, }; static void ins__delete(struct ins_operands *ops) -- 2.7.4