From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jan Kara <jack@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/4] ovl: fix IS_APPEND() checks
Date: Thu, 6 Apr 2017 11:13:45 +0300 [thread overview]
Message-ID: <1491466429-30333-1-git-send-email-amir73il@gmail.com> (raw)
Miklos,
This series fixes the append-only violations found by the new
xfstest overlay/030.
I did it to see how bad it would be compared to propagating
the S_APPEND/S_IMMUTABLE flags to overlay inode.
IMO, the [f]truncate patches look ok, but the last vfs_open()
patch less so (?).
Do you think we can get away without propagating the flags?
If getflags()/setflags() were standard vfs ops, we could have
handled this nicer...
Those "fs specific flags" have long been a standard, so perhaps
its time to make the setflags/getflags a vfs api?
Amir.
Amir Goldstein (4):
vfs: ftruncate freeze protect backing inode
vfs: ftruncate check IS_APPEND() on backing inode
vfs: truncate check IS_APPEND() on backing inode
vfs: open check IS_APPEND() on backing inode
fs/open.c | 34 +++++++++++++++++++++-------------
1 file changed, 21 insertions(+), 13 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-06 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 8:13 Amir Goldstein [this message]
2017-04-06 8:13 ` [PATCH 1/4] vfs: ftruncate freeze protect backing inode Amir Goldstein
2017-04-06 15:42 ` Amir Goldstein
2017-04-06 8:13 ` [PATCH 2/4] vfs: ftruncate check IS_APPEND() on " Amir Goldstein
2017-04-06 8:13 ` [PATCH 3/4] vfs: truncate " Amir Goldstein
2017-04-06 8:13 ` [PATCH 4/4] vfs: open " Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491466429-30333-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.