From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [PATCH v3] mac80211: Dynamically set CoDel parameters per station
Date: Thu, 06 Apr 2017 03:51:55 -0700 [thread overview]
Message-ID: <1491475915.10124.75.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20170406093826.16626-1-toke@toke.dk>
On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote:
> +
> + if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
> + sta->cparams.target = MS2TIME(50);
> + sta->cparams.interval = MS2TIME(300);
> + sta->cparams.ecn = false;
> + } else {
> + sta->cparams.target = MS2TIME(20);
> + sta->cparams.interval = MS2TIME(100);
> + sta->cparams.ecn = true;
> + }
> +}
Why ECN is flipped on/off like that ? ECN really should be an admin
choice.
Also, this change in parameters looks suspect to me, adding a bimodal
behavior. I would consult Kathleen and Van on this possibility.
next prev parent reply other threads:[~2017-04-06 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 19:33 [PATCH] mac80211: Dynamically set CoDel parameters per station Toke Høiland-Jørgensen
2016-09-11 0:09 ` kbuild test robot
[not found] ` <CAGhGL2D8Hfed0VTsinnCbkK31dGTc=bYjzpPfrcLRnp+x6O3sA@mail.gmail.com>
2016-09-10 20:09 ` [Make-wifi-fast] " Toke Høiland-Jørgensen
2016-09-11 3:16 ` Loganaden Velvindron
2017-04-05 16:18 ` [PATCH v2] " Toke Høiland-Jørgensen
2017-04-06 7:56 ` kbuild test robot
2017-04-06 8:45 ` kbuild test robot
2017-04-06 9:38 ` [PATCH v3] " Toke Høiland-Jørgensen
2017-04-06 10:51 ` Eric Dumazet [this message]
2017-04-06 15:58 ` [Make-wifi-fast] " Toke Høiland-Jørgensen
2017-04-13 18:26 ` Dave Taht
2017-05-17 14:06 ` Johannes Berg
2017-05-19 9:27 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491475915.10124.75.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.