From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Use the right mapping_gfp_mask for final shmem allocation
Date: Thu, 06 Apr 2017 14:55:16 +0300 [thread overview]
Message-ID: <1491479716.3356.10.camel@linux.intel.com> (raw)
In-Reply-To: <20170405221514.23251-1-chris@chris-wilson.co.uk>
On ke, 2017-04-05 at 23:15 +0100, Chris Wilson wrote:
> Many sightings report the greater prevalence of allocation failures.
> This is all due to the incorrect use of mapping_gfp_constraint(), so
> remove it in favour of just querying the mapping_gfp_mask() which are
> the exact gfp_t we wanted in the first place.
>
> We still do expect a higher chance of reporting ENOMEM, as that is the
> intention of using __GFP_NORETRY -- to fail rather than oom after having
> reclaimed from our bo caches, and having done a direct|kswapd reclaim
> pass.
>
> Reported-by: Jason Ekstrand <jason.ekstrand@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100594
> Fixes: 24f8e00a8a2e ("drm/i915: Prefer to report ENOMEM rather than incur the oom for gfx allocations")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-06 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 22:15 [PATCH] drm/i915: Use the right mapping_gfp_mask for final shmem allocation Chris Wilson
2017-04-05 22:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-04-06 11:55 ` Joonas Lahtinen [this message]
2017-04-06 12:10 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491479716.3356.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.