From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935404AbdDFPCa (ORCPT ); Thu, 6 Apr 2017 11:02:30 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:38101 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934743AbdDFPCZ (ORCPT ); Thu, 6 Apr 2017 11:02:25 -0400 Message-ID: <1491490912.2392.74.camel@pengutronix.de> Subject: Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default From: Philipp Zabel To: Russell King - ARM Linux Cc: Steve Longerbeam , robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Steve Longerbeam Date: Thu, 06 Apr 2017 17:01:52 +0200 In-Reply-To: <20170406140533.GF17774@n2100.armlinux.org.uk> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <20170406140533.GF17774@n2100.armlinux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdformat->format.field = fmt->field; > > + > > + /* Retain current colorspace setting as default */ > > + if (sdformat->format.colorspace == V4L2_COLORSPACE_DEFAULT) { > > + sdformat->format.colorspace = fmt->colorspace; > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) > > + sdformat->format.xfer_func = fmt->xfer_func; > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) > > + sdformat->format.ycbcr_enc = fmt->ycbcr_enc; > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) > > + sdformat->format.quantization = fmt->quantization; > > + } else { > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) { > > + sdformat->format.xfer_func = > > + V4L2_MAP_XFER_FUNC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) { > > + sdformat->format.ycbcr_enc = > > + V4L2_MAP_YCBCR_ENC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) { > > + sdformat->format.quantization = > > + V4L2_MAP_QUANTIZATION_DEFAULT( > > + cc->cs != IPUV3_COLORSPACE_YUV, > > + sdformat->format.colorspace, > > + sdformat->format.ycbcr_enc); > > + } > > + } > > Would it make sense for this to be a helper function? Quite possible, the next subdev that has to set frame_interval on both pads manually because its upstream source pad doesn't suport frame_interval might want to do the same. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default Date: Thu, 06 Apr 2017 17:01:52 +0200 Message-ID: <1491490912.2392.74.camel@pengutronix.de> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <20170406140533.GF17774@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170406140533.GF17774@n2100.armlinux.org.uk> Sender: linux-media-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Steve Longerbeam , robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@v List-Id: devicetree@vger.kernel.org On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdformat->format.field = fmt->field; > > + > > + /* Retain current colorspace setting as default */ > > + if (sdformat->format.colorspace == V4L2_COLORSPACE_DEFAULT) { > > + sdformat->format.colorspace = fmt->colorspace; > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) > > + sdformat->format.xfer_func = fmt->xfer_func; > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) > > + sdformat->format.ycbcr_enc = fmt->ycbcr_enc; > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) > > + sdformat->format.quantization = fmt->quantization; > > + } else { > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) { > > + sdformat->format.xfer_func = > > + V4L2_MAP_XFER_FUNC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) { > > + sdformat->format.ycbcr_enc = > > + V4L2_MAP_YCBCR_ENC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) { > > + sdformat->format.quantization = > > + V4L2_MAP_QUANTIZATION_DEFAULT( > > + cc->cs != IPUV3_COLORSPACE_YUV, > > + sdformat->format.colorspace, > > + sdformat->format.ycbcr_enc); > > + } > > + } > > Would it make sense for this to be a helper function? Quite possible, the next subdev that has to set frame_interval on both pads manually because its upstream source pad doesn't suport frame_interval might want to do the same. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Thu, 06 Apr 2017 17:01:52 +0200 Subject: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default In-Reply-To: <20170406140533.GF17774@n2100.armlinux.org.uk> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <20170406140533.GF17774@n2100.armlinux.org.uk> Message-ID: <1491490912.2392.74.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdformat->format.field = fmt->field; > > + > > + /* Retain current colorspace setting as default */ > > + if (sdformat->format.colorspace == V4L2_COLORSPACE_DEFAULT) { > > + sdformat->format.colorspace = fmt->colorspace; > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) > > + sdformat->format.xfer_func = fmt->xfer_func; > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) > > + sdformat->format.ycbcr_enc = fmt->ycbcr_enc; > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) > > + sdformat->format.quantization = fmt->quantization; > > + } else { > > + if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) { > > + sdformat->format.xfer_func = > > + V4L2_MAP_XFER_FUNC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) { > > + sdformat->format.ycbcr_enc = > > + V4L2_MAP_YCBCR_ENC_DEFAULT( > > + sdformat->format.colorspace); > > + } > > + if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) { > > + sdformat->format.quantization = > > + V4L2_MAP_QUANTIZATION_DEFAULT( > > + cc->cs != IPUV3_COLORSPACE_YUV, > > + sdformat->format.colorspace, > > + sdformat->format.ycbcr_enc); > > + } > > + } > > Would it make sense for this to be a helper function? Quite possible, the next subdev that has to set frame_interval on both pads manually because its upstream source pad doesn't suport frame_interval might want to do the same. regards Philipp