From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933467AbdDFP6s (ORCPT ); Thu, 6 Apr 2017 11:58:48 -0400 Received: from smtprelay0029.hostedemail.com ([216.40.44.29]:50813 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933324AbdDFP6h (ORCPT ); Thu, 6 Apr 2017 11:58:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2376:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3873:3874:4321:5007:8695:9108:10004:10226:10400:10848:11026:11232:11658:11914:12043:12050:12438:12740:12760:12895:13069:13161:13229:13311:13357:13439:14096:14097:14659:14721:21080:30051:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: brass00_2d21c8a89fd05 X-Filterd-Recvd-Size: 2073 Message-ID: <1491494308.27353.99.camel@perches.com> Subject: Re: [PATCH -v6 05/13] futex: Change locking rules From: Joe Perches To: Peter Zijlstra , Darren Hart Cc: tglx@linutronix.de, mingo@kernel.org, juri.lelli@arm.com, rostedt@goodmis.org, xlpang@redhat.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, jdesfossez@efficios.com, bristot@redhat.com Date: Thu, 06 Apr 2017 08:58:28 -0700 In-Reply-To: <20170406122832.l3ll5mavtu7awavy@hirez.programming.kicks-ass.net> References: <20170322103547.756091212@infradead.org> <20170322104151.751993333@infradead.org> <20170405211843.GA13494@fury> <20170406122832.l3ll5mavtu7awavy@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-06 at 14:28 +0200, Peter Zijlstra wrote: > On Wed, Apr 05, 2017 at 02:18:43PM -0700, Darren Hart wrote: > > On Wed, Mar 22, 2017 at 11:35:52AM +0100, Peter Zijlstra wrote: > > > @@ -1336,6 +1418,7 @@ static int wake_futex_pi(u32 __user *uad > > > > > > if (cmpxchg_futex_value_locked(&curval, uaddr, uval, newval)) { > > > ret = -EFAULT; > > > + > > > > Stray whitespace addition? Not explicitly against coding-style, but I don't > > normally see a new line before the closing brace leading to an else... > > I found it more readable that way. Sod checkpatch and co ;-) The only good sod is the stuff you get to play games on. And this week's best sod is Augusta's immaculate carpet for the Masters Tournament. So no worries from me. checkpatch is a brainless script. Rules made to be broken, etc. afaict another way to write that would be to use gotos and that would be a lot more lines and less readable.