From: Eric Dumazet <eric.dumazet@gmail.com>
To: tndave <tushar.n.dave@oracle.com>
Cc: davem@davemloft.net, edumazet@google.com, brouer@redhat.com,
netdev@vger.kernel.org, sowmini.varadhan@oracle.com
Subject: Re: [PATCH] netpoll: Check for skb->queue_mapping
Date: Thu, 06 Apr 2017 12:14:16 -0700 [thread overview]
Message-ID: <1491506056.10124.81.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <5927b630-865e-b7af-33a1-1a6b772e3fb7@oracle.com>
On Thu, 2017-04-06 at 12:07 -0700, tndave wrote:
> > + q_index = q_index % dev->real_num_tx_queues;
> cpu interrupted here and dev->real_num_tx_queues has reduced!
> > + skb_set_queue_mapping(skb, q_index);
> > + }
> > + txq = netdev_get_tx_queue(dev, q_index);
> or cpu interrupted here and dev->real_num_tx_queues has reduced!
If dev->real_num_tx_queues can be changed while this code is running we
are in deep deep trouble.
Better make sure that when control path does this change, device (and/pr
netpoll) is frozen and no packet can be sent.
next prev parent reply other threads:[~2017-04-06 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 2:06 [PATCH] netpoll: Check for skb->queue_mapping Tushar Dave
2017-04-06 10:26 ` Eric Dumazet
2017-04-06 10:28 ` Eric Dumazet
2017-04-06 19:07 ` tndave
2017-04-06 19:14 ` Eric Dumazet [this message]
2017-04-12 22:37 ` tndave
2017-04-20 19:08 ` tndave
2017-04-20 19:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491506056.10124.81.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=tushar.n.dave@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.