From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756694AbdDGJxF (ORCPT ); Fri, 7 Apr 2017 05:53:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:62094 "EHLO epoutp02.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756592AbdDGJwt (ORCPT ); Fri, 7 Apr 2017 05:52:49 -0400 X-AuditID: b6c32a59-f79166d0000017ce-a5-58e7616ea9f8 Subject: Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder From: Smitha T Murthy To: Sylwester Nawrocki Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, pankaj.dubey@samsung.com, kamil@wypas.org, krzk@kernel.org, jtp.park@samsung.com, kyungmin.park@samsung.com, mchehab@kernel.org, m.szyprowski@samsung.com In-Reply-To: <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> Date: Fri, 07 Apr 2017 15:24:26 +0530 Message-ID: <1491558866.15698.1227.camel@smitha-fedora> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsWy7bCmhm5e4vMIgz075C1urTvHanFk7VUm i5kn2lktzp/fwG5xtukNu8Wmx9dYLS7vmsNm0bNhK6vF2iN32S2WbfrDZLFo6xd2i8Nv2lkd eDw2repk89i8pN6jb8sqRo/Pm+Q8rhxpZA9gjeKySUnNySxLLdK3S+DKaOizLHjFU/Hrz0+2 BsYVXF2MHBwSAiYSi547dTFyApliEhfurWfrYuTiEBJYyiix4etEJgjnE6PE7KdHGeGcnds/ s0G0mEjcX/OFBSKxk1Hi/OU+VgjnLaPE9nP7WECqhAWCJVZ1NLCC2GwCOhLf3p8G6xYR0JdY suoimM0sMItJYn032CGcAvYSbdN7wOIsAqoSt56eYQSxeQXMJf59BJnJAWQLSvzdIQxxhLbE uoYzLBBj5CW2v53DDHKDhMBvNontT+azQxS5SPz+/RXqamGJV8e3QMWlJD6/28sG0dDMKDF3 WzMLRGICo8TK1lII217iwJU5YIuZBTQl1u/ShwjbSlxvvcgICUc+iRtvBSFu4JPo/f2ECaJE SWLRmRPsECW8Eh1tQhBhD4kbzWdZJzAqzUJ4ZhaSB2YhrFrAyLyKUSy1oDg3PbXYtMBUrzgx t7g0L10vOT93EyM4JWlF7mC8MjPoEKMAB6MSD2/CrmcRQqyJZcWVuYcYJTiYlUR4BQOfRwjx piRWVqUW5ccXleakFh9ilOZgURLn1Vh5LUJIID2xJDU7NbUgtQgmy8TBKdXAWPmSX90p8+RR Z0lDwYBCdu5vNosNmZTrmtlfRDtmfQ2u99L9dOr+sUlceysWWPUeOizCtGWPTcnZrZOz22P5 5TSTNRMnLLx86PDPspXy0taTjP8JugfOkvu38r3+scRn1zJq39f73L2cG7D41NmHrDYNKfP3 mk0/9HiPA5dgb3TCokun7Cb/VWIpzkg01GIuKk4EAJPVzoFFAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42LZdlhJTlcz8XmEwf9Jgha31p1jtTiy9iqT xcwT7awW589vYLc42/SG3WLT42usFpd3zWGz6NmwldVi7ZG77BbLNv1hsli09Qu7xeE37awO PB6bVnWyeWxeUu/Rt2UVo8fnTXIeV440sgewRnHZpKTmZJalFunbJXBlNPRZFrziqfj15ydb A+MKri5GTg4JAROJ+2u+sEDYYhIX7q1n62Lk4hAS2M4osW3ebyaIhIrE5Cf32SBsYYmV/56z QxS9ZpR4tOw9WJGwQLDEqo4GVhCbTUBH4tv702ANIgL6EktWXQSbyiwwjUniw7etYEWcAvYS bdN7wIqEBD4ySby/5Q5iMwtoSrRu/80OYrMIqErcenqGEcTmFTCX+PdxH9CpHEC2oMTfHcIQ B2lLrGs4wwLRKi+x/e0c5gmMQrOQTJqF0DELSdUCRuZVjKKpBcW56bnFBUZ6xYm5xaV56XrJ +bmbGMExpJW0g3HTjPBDjAIcjEo8vBOePIsQYk0sK67MPcQowcGsJMIrGPg8Qog3JbGyKrUo P76oNCe1+BCjNAeLkjjv9uoNEUIC6YklqdmpqQWpRTBZJg5OqQbG5o6+muk7YnboKfe/3tKm uOVE1e3swg9pP35sYZhpsvtDSoVA2gpVLj/nn1wqV+uLbEzW9X1bMHuGUmhRUkW2zAGPojQj cUML7/czEh8ZeFacif1fVbhcarMAZ/j3z8Ip907GWfgq79tuk17mszHy5Kym3jmL2yOzY54y 7D6qvSo2/s3WDbVKLMUZiYZazEXFiQBaZxKsnQIAAA== X-CMS-MailID: 20170407095246epcas5p2d28e048eae23423b8ae2aa36faeb3eb8 X-Msg-Generator: CA X-Sender-IP: 182.195.40.14 X-Local-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG+yCvOyEseyghOyekBtMZWFkIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= Content-Type: text/plain; charset="utf-8" X-MTR: 20170407095246epcas5p2d28e048eae23423b8ae2aa36faeb3eb8 X-EPHeader: CA CMS-TYPE: 105P X-CMS-RootMailID: 20170406061023epcas5p2a3fa65c4254e17a58f71c68d413e6bfd X-RootMTR: 20170406061023epcas5p2a3fa65c4254e17a58f71c68d413e6bfd References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-11-git-send-email-smitha.t@samsung.com> <374939c7-241a-fcca-c87e-5c4290bdb6aa@samsung.com> <1491553894.15698.1142.camel@smitha-fedora> <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-07 at 11:25 +0200, Sylwester Nawrocki wrote: > On 04/07/2017 10:31 AM, Smitha T Murthy wrote: > > On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: > >> On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > >>> @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) > >>> case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP: return "VPX P-Frame QP Value"; > >>> case V4L2_CID_MPEG_VIDEO_VPX_PROFILE: return "VPX Profile"; > >>> > >>> + /* HEVC controls */ > >> [...] > >>> + case V4L2_CID_MPEG_VIDEO_HEVC_LF_SLICE_BOUNDARY: return "HEVC LF Across Slice Boundary or Not"; > >> Please make sure the names are no longer than 31 characters to avoid > >> truncation during control enumeration in user space. > >> Data structures like struct v4l2_queryctrl, struct v4l2_query_ext_ctrl > >> have only 32 bytes long array dedicated for the control name. > > > > I will try to make the names less than 31 characters long without losing > > the context. But there are many control names in this file which are > > longer than 31 characters like > > V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP, > > V4L2_CID_MPEG_VIDEO_VPX_GOLDEN_FRAME_REF_PERIOD etc so I assumed it was > > alright to have such long names. But I will shorten them as per your > > suggestion. > > Apologies if it wasn't clean enough but my comment referred to the > length of the character string being returned (e.g. "HEVC LF Across > Slice Boundary or Not") and not to the name of the enum. > > -- > Regards, > Sylwester > Sorry I misunderstood I will take care of it in the next version. Thank you, Smitha From mboxrd@z Thu Jan 1 00:00:00 1970 From: smitha.t@samsung.com (Smitha T Murthy) Date: Fri, 07 Apr 2017 15:24:26 +0530 Subject: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder In-Reply-To: <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-11-git-send-email-smitha.t@samsung.com> <374939c7-241a-fcca-c87e-5c4290bdb6aa@samsung.com> <1491553894.15698.1142.camel@smitha-fedora> <9f81ed3a-4adb-7827-6094-88847bc0787a@samsung.com> Message-ID: <1491558866.15698.1227.camel@smitha-fedora> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-04-07 at 11:25 +0200, Sylwester Nawrocki wrote: > On 04/07/2017 10:31 AM, Smitha T Murthy wrote: > > On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: > >> On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > >>> @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) > >>> case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP: return "VPX P-Frame QP Value"; > >>> case V4L2_CID_MPEG_VIDEO_VPX_PROFILE: return "VPX Profile"; > >>> > >>> + /* HEVC controls */ > >> [...] > >>> + case V4L2_CID_MPEG_VIDEO_HEVC_LF_SLICE_BOUNDARY: return "HEVC LF Across Slice Boundary or Not"; > >> Please make sure the names are no longer than 31 characters to avoid > >> truncation during control enumeration in user space. > >> Data structures like struct v4l2_queryctrl, struct v4l2_query_ext_ctrl > >> have only 32 bytes long array dedicated for the control name. > > > > I will try to make the names less than 31 characters long without losing > > the context. But there are many control names in this file which are > > longer than 31 characters like > > V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP, > > V4L2_CID_MPEG_VIDEO_VPX_GOLDEN_FRAME_REF_PERIOD etc so I assumed it was > > alright to have such long names. But I will shorten them as per your > > suggestion. > > Apologies if it wasn't clean enough but my comment referred to the > length of the character string being returned (e.g. "HEVC LF Across > Slice Boundary or Not") and not to the name of the enum. > > -- > Regards, > Sylwester > Sorry I misunderstood I will take care of it in the next version. Thank you, Smitha