From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbdDGNFk (ORCPT ); Fri, 7 Apr 2017 09:05:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754710AbdDGNFc (ORCPT ); Fri, 7 Apr 2017 09:05:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BC77763E2E Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BC77763E2E Message-ID: <1491570329.8850.163.camel@redhat.com> Subject: Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free From: Rik van Riel To: "Huang, Ying" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim Date: Fri, 07 Apr 2017 09:05:29 -0400 In-Reply-To: <20170407064901.25398-1-ying.huang@intel.com> References: <20170407064901.25398-1-ying.huang@intel.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 07 Apr 2017 13:05:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-07 at 14:49 +0800, Huang, Ying wrote: > To solve the issue, the per-CPU buffer is sorted according to the > swap > device before freeing the swap entries.  Test shows that the time > spent by swapcache_free_entries() could be reduced after the patch. > > Test the patch via measuring the run time of > swap_cache_free_entries() > during the exit phase of the applications use much swap space.  The > results shows that the average run time of swap_cache_free_entries() > reduced about 20% after applying the patch. > > Signed-off-by: Huang Ying > Acked-by: Tim Chen > Cc: Hugh Dickins > Cc: Shaohua Li > Cc: Minchan Kim > Cc: Rik van Riel Acked-by: Rik van Riel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f197.google.com (mail-qt0-f197.google.com [209.85.216.197]) by kanga.kvack.org (Postfix) with ESMTP id B1E9C6B0038 for ; Fri, 7 Apr 2017 09:05:33 -0400 (EDT) Received: by mail-qt0-f197.google.com with SMTP id b9so21330675qtg.4 for ; Fri, 07 Apr 2017 06:05:33 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id n41si4742893qtf.240.2017.04.07.06.05.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 06:05:32 -0700 (PDT) Message-ID: <1491570329.8850.163.camel@redhat.com> Subject: Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free From: Rik van Riel Date: Fri, 07 Apr 2017 09:05:29 -0400 In-Reply-To: <20170407064901.25398-1-ying.huang@intel.com> References: <20170407064901.25398-1-ying.huang@intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: "Huang, Ying" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim On Fri, 2017-04-07 at 14:49 +0800, Huang, Ying wrote: > To solve the issue, the per-CPU buffer is sorted according to the > swap > device before freeing the swap entries.A A Test shows that the time > spent by swapcache_free_entries() could be reduced after the patch. > > Test the patch via measuring the run time of > swap_cache_free_entries() > during the exit phase of the applications use much swap space.A A The > results shows that the average run time of swap_cache_free_entries() > reduced about 20% after applying the patch. > > Signed-off-by: Huang Ying > Acked-by: Tim Chen > Cc: Hugh Dickins > Cc: Shaohua Li > Cc: Minchan Kim > Cc: Rik van Riel Acked-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org