All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field
@ 2017-04-10 12:26 Ed Czeck
  2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Ed Czeck @ 2017-04-10 12:26 UTC (permalink / raw)
  To: dev; +Cc: john.miller, shepard.siegel, Ed Czeck

Time stamp was carried in the packet meta data, but not
place in the mbuf. The new time stamp field is the proper
destination.

Remove the setting of data offset since this is done by
rte_pktmbuf_free()

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
index 97bfba3..f39e6f6 100644
--- a/drivers/net/ark/ark_ethdev_rx.c
+++ b/drivers/net/ark/ark_ethdev_rx.c
@@ -292,7 +292,7 @@ eth_ark_recv_pkts(void *rx_queue,
 		mbuf->port = meta->port;
 		mbuf->pkt_len = meta->pkt_len;
 		mbuf->data_len = meta->pkt_len;
-		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
+		mbuf->timestamp = meta->timestamp;
 		mbuf->udata64 = meta->user_data;
 
 		if (ARK_RX_DEBUG) {	/* debug sanity checks */
@@ -322,6 +322,7 @@ eth_ark_recv_pkts(void *rx_queue,
 				mbuf->pkt_len = 63;
 				meta->pkt_len = 63;
 			}
+			/* seqn is only set under debug */
 			mbuf->seqn = cons_index;
 		}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] net/ark: report hardware status during PMD init
  2017-04-10 12:26 [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field Ed Czeck
@ 2017-04-10 12:26 ` Ed Czeck
  2017-04-10 15:01   ` Ferruh Yigit
  2017-04-11 15:41   ` [PATCH v2 " Ed Czeck
  2017-04-11 10:10 ` [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field john miller
  2017-04-11 15:41 ` [PATCH v2 " Ed Czeck
  2 siblings, 2 replies; 9+ messages in thread
From: Ed Czeck @ 2017-04-10 12:26 UTC (permalink / raw)
  To: dev; +Cc: john.miller, shepard.siegel, Ed Czeck

Expose additional fpga status registers and report
conditions during PMD init

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 9 +++++++++
 drivers/net/ark/ark_rqp.c    | 6 ++++++
 drivers/net/ark/ark_rqp.h    | 4 +++-
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 93721a0..1a6c71c 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -297,6 +297,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
 			    ark->sysctrl.t32[4], __func__);
 		return -1;
 	}
+	if (ark->sysctrl.t32[3] != 0) {
+		if (ark_rqp_lasped(ark->rqpacing))
+			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
+				    "Timer has Expired\n");
+		else
+			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
+				    "Timer is Running\n");
+	}
+
 
 	PMD_DRV_LOG(INFO,
 		    "HW Sanity test has PASSED, expected constant"
diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c
index 59d9b8a..41c497b 100644
--- a/drivers/net/ark/ark_rqp.c
+++ b/drivers/net/ark/ark_rqp.c
@@ -89,3 +89,9 @@ ark_rqp_dump(struct ark_rqpace_t *rqp)
 		      "cplh pending max", rqp->cplh_pending_max,
 		      "cpld pending max", rqp->cpld_pending_max);
 }
+
+int
+ark_rqp_lasped(struct ark_rqpace_t *rqp)
+{
+	return rqp->lasped;
+}
diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h
index 995fc20..0c38007 100644
--- a/drivers/net/ark/ark_rqp.h
+++ b/drivers/net/ark/ark_rqp.h
@@ -76,9 +76,11 @@ struct ark_rqpace_t {
 	volatile uint32_t cplh_pending_max;
 	volatile uint32_t cpld_pending_max;
 	volatile uint32_t err_count_other;
+	char eval[4];
+	volatile int lasped;
 };
 
 void ark_rqp_dump(struct ark_rqpace_t *rqp);
 void ark_rqp_stats_reset(struct ark_rqpace_t *rqp);
-
+int ark_rqp_lasped(struct ark_rqpace_t *rqp);
 #endif
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] net/ark: report hardware status during PMD init
  2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
@ 2017-04-10 15:01   ` Ferruh Yigit
  2017-04-11 15:26     ` Ed Czeck
  2017-04-11 15:41   ` [PATCH v2 " Ed Czeck
  1 sibling, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2017-04-10 15:01 UTC (permalink / raw)
  To: Ed Czeck, dev; +Cc: john.miller, shepard.siegel

On 4/10/2017 1:26 PM, Ed Czeck wrote:
> Expose additional fpga status registers and report
> conditions during PMD init
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> ---
>  drivers/net/ark/ark_ethdev.c | 9 +++++++++
>  drivers/net/ark/ark_rqp.c    | 6 ++++++
>  drivers/net/ark/ark_rqp.h    | 4 +++-
>  3 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 93721a0..1a6c71c 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -297,6 +297,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
>  			    ark->sysctrl.t32[4], __func__);
>  		return -1;
>  	}
> +	if (ark->sysctrl.t32[3] != 0) {
> +		if (ark_rqp_lasped(ark->rqpacing))
> +			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "

Is this should be "info" level or debug, is end user interested if timer
expired or not?

> +				    "Timer has Expired\n");
> +		else
> +			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "

btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
PMD_DEBUG_LOG?

> +				    "Timer is Running\n");
> +	}
> +
>  

Extra line.

>  	PMD_DRV_LOG(INFO,
>  		    "HW Sanity test has PASSED, expected constant"
<...>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field
  2017-04-10 12:26 [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field Ed Czeck
  2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
@ 2017-04-11 10:10 ` john miller
  2017-04-11 15:41 ` [PATCH v2 " Ed Czeck
  2 siblings, 0 replies; 9+ messages in thread
From: john miller @ 2017-04-11 10:10 UTC (permalink / raw)
  To: Ed Czeck; +Cc: dev, Shepard Siegel


> On Apr 10, 2017, at 8:26 AM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> 
> Time stamp was carried in the packet meta data, but not
> place in the mbuf. The new time stamp field is the proper
> destination.
> 
> Remove the setting of data offset since this is done by
> rte_pktmbuf_free()
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] net/ark: report hardware status during PMD init
  2017-04-10 15:01   ` Ferruh Yigit
@ 2017-04-11 15:26     ` Ed Czeck
  0 siblings, 0 replies; 9+ messages in thread
From: Ed Czeck @ 2017-04-11 15:26 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, John Miller, Shepard Siegel

On Mon, Apr 10, 2017 at 11:01 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/10/2017 1:26 PM, Ed Czeck wrote:
> > Expose additional fpga status registers and report
> > conditions during PMD init
> >
>
> > +     if (ark->sysctrl.t32[3] != 0) {
> > +             if (ark_rqp_lasped(ark->rqpacing))
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> Is this should be "info" level or debug, is end user interested if timer
> expired or not?
>
> These messages are intended for the user.  After internal discussion we
promoted them to warning and error.



> > +                                 "Timer has Expired\n");
> > +             else
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
> PMD_DEBUG_LOG?


The  PMD_DRV_LOG macro is a local wrapper on RTE_LOG, while the
PMD_DEBUG_LOG macro is a compile-time conditional macro to the same
RTE_LOG.  The DEBUG_LOG macro is conditionalize on the configuration
RTE_LIBRTE_ARK_DEBUG_TRACE.


> > +                                 "Timer is Running\n");
> > +     }
> > +
> >
>
> Extra line.
>
Removed.

Thank you

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2 1/2] net/ark: update packet Rx path to set mbuf time stamp field
  2017-04-10 12:26 [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field Ed Czeck
  2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
  2017-04-11 10:10 ` [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field john miller
@ 2017-04-11 15:41 ` Ed Czeck
  2017-04-11 15:54   ` Ferruh Yigit
  2 siblings, 1 reply; 9+ messages in thread
From: Ed Czeck @ 2017-04-11 15:41 UTC (permalink / raw)
  To: dev; +Cc: john.miller, shepard.siegel, ferruh.yigit, Ed Czeck

Time stamp was carried in the packet meta data, but not
place in the mbuf. The new time stamp field is the proper
destination.

Remove the setting of data offset since this is done by
rte_pktmbuf_free()

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
index 97bfba3..f39e6f6 100644
--- a/drivers/net/ark/ark_ethdev_rx.c
+++ b/drivers/net/ark/ark_ethdev_rx.c
@@ -292,7 +292,7 @@ eth_ark_recv_pkts(void *rx_queue,
 		mbuf->port = meta->port;
 		mbuf->pkt_len = meta->pkt_len;
 		mbuf->data_len = meta->pkt_len;
-		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
+		mbuf->timestamp = meta->timestamp;
 		mbuf->udata64 = meta->user_data;
 
 		if (ARK_RX_DEBUG) {	/* debug sanity checks */
@@ -322,6 +322,7 @@ eth_ark_recv_pkts(void *rx_queue,
 				mbuf->pkt_len = 63;
 				meta->pkt_len = 63;
 			}
+			/* seqn is only set under debug */
 			mbuf->seqn = cons_index;
 		}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 2/2] net/ark: report hardware status during PMD init
  2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
  2017-04-10 15:01   ` Ferruh Yigit
@ 2017-04-11 15:41   ` Ed Czeck
  2017-04-11 18:06     ` john miller
  1 sibling, 1 reply; 9+ messages in thread
From: Ed Czeck @ 2017-04-11 15:41 UTC (permalink / raw)
  To: dev; +Cc: john.miller, shepard.siegel, ferruh.yigit, Ed Czeck

Expose additional fpga status registers.
Report hardware status during PMD init.

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 9 +++++++++
 drivers/net/ark/ark_rqp.c    | 6 ++++++
 drivers/net/ark/ark_rqp.h    | 4 +++-
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 93721a0..651dd26 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -297,6 +297,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
 			    ark->sysctrl.t32[4], __func__);
 		return -1;
 	}
+	if (ark->sysctrl.t32[3] != 0) {
+		if (ark_rqp_lasped(ark->rqpacing)) {
+			PMD_DRV_LOG(ERR, "Arkville Evaluation System - "
+				    "Timer has Expired\n");
+			return -1;
+		}
+		PMD_DRV_LOG(WARNING, "Arkville Evaluation System - "
+			    "Timer is Running\n");
+	}
 
 	PMD_DRV_LOG(INFO,
 		    "HW Sanity test has PASSED, expected constant"
diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c
index 59d9b8a..41c497b 100644
--- a/drivers/net/ark/ark_rqp.c
+++ b/drivers/net/ark/ark_rqp.c
@@ -89,3 +89,9 @@ ark_rqp_dump(struct ark_rqpace_t *rqp)
 		      "cplh pending max", rqp->cplh_pending_max,
 		      "cpld pending max", rqp->cpld_pending_max);
 }
+
+int
+ark_rqp_lasped(struct ark_rqpace_t *rqp)
+{
+	return rqp->lasped;
+}
diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h
index 995fc20..0c38007 100644
--- a/drivers/net/ark/ark_rqp.h
+++ b/drivers/net/ark/ark_rqp.h
@@ -76,9 +76,11 @@ struct ark_rqpace_t {
 	volatile uint32_t cplh_pending_max;
 	volatile uint32_t cpld_pending_max;
 	volatile uint32_t err_count_other;
+	char eval[4];
+	volatile int lasped;
 };
 
 void ark_rqp_dump(struct ark_rqpace_t *rqp);
 void ark_rqp_stats_reset(struct ark_rqpace_t *rqp);
-
+int ark_rqp_lasped(struct ark_rqpace_t *rqp);
 #endif
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 1/2] net/ark: update packet Rx path to set mbuf time stamp field
  2017-04-11 15:41 ` [PATCH v2 " Ed Czeck
@ 2017-04-11 15:54   ` Ferruh Yigit
  0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2017-04-11 15:54 UTC (permalink / raw)
  To: Ed Czeck, dev; +Cc: john.miller, shepard.siegel

On 4/11/2017 4:41 PM, Ed Czeck wrote:
> Time stamp was carried in the packet meta data, but not
> place in the mbuf. The new time stamp field is the proper
> destination.
> 
> Remove the setting of data offset since this is done by
> rte_pktmbuf_free()
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/2] net/ark: report hardware status during PMD init
  2017-04-11 15:41   ` [PATCH v2 " Ed Czeck
@ 2017-04-11 18:06     ` john miller
  0 siblings, 0 replies; 9+ messages in thread
From: john miller @ 2017-04-11 18:06 UTC (permalink / raw)
  To: Ed Czeck; +Cc: dev, Shepard Siegel, ferruh.yigit


> On Apr 11, 2017, at 11:41 AM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> 
> Expose additional fpga status registers.
> Report hardware status during PMD init.
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-04-11 18:07 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 12:26 [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field Ed Czeck
2017-04-10 12:26 ` [PATCH 2/2] net/ark: report hardware status during PMD init Ed Czeck
2017-04-10 15:01   ` Ferruh Yigit
2017-04-11 15:26     ` Ed Czeck
2017-04-11 15:41   ` [PATCH v2 " Ed Czeck
2017-04-11 18:06     ` john miller
2017-04-11 10:10 ` [PATCH 1/2] net/ark: update packet Rx path to set mbuf time stamp field john miller
2017-04-11 15:41 ` [PATCH v2 " Ed Czeck
2017-04-11 15:54   ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.