From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:48132 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbdDJSLQ (ORCPT ); Mon, 10 Apr 2017 14:11:16 -0400 Message-ID: <1491847829.2409.62.camel@decadent.org.uk> Subject: Re: Patch "mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp" has been added to the 4.4-stable tree From: Ben Hutchings To: Greg KH Cc: keno@juliacomputing.com, akpm@linux-foundation.org, gthelen@google.com, hughd@google.com, keescook@chromium.org, kirill.shutemov@linux.intel.com, luto@kernel.org, mhocko@suse.com, npiggin@gmail.com, oleg@redhat.com, torvalds@linux-foundation.org, w@1wt.eu, stable@vger.kernel.org, stable-commits@vger.kernel.org Date: Mon, 10 Apr 2017 19:10:29 +0100 In-Reply-To: <20170410160451.GA5425@kroah.com> References: <14918369578070@kroah.com> <1491839297.2409.51.camel@decadent.org.uk> <20170410160451.GA5425@kroah.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-akU8n9bUWQiTse937CA2" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-akU8n9bUWQiTse937CA2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-04-10 at 18:04 +0200, Greg KH wrote: > On Mon, Apr 10, 2017 at 04:48:17PM +0100, Ben Hutchings wrote: > > > > On Mon, 2017-04-10 at 17:09 +0200, gregkh@linuxfoundation.org wrote= : > > > This is a note to let you know that I've just added the patch titled > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW= for thp > > >=20 > > > to the 4.4-stable tree which can be found at: > > > =C2=A0=C2=A0=C2=A0=C2=A0http://www.kernel.org/git/?p=3Dlinux/kernel/g= it/stable/stable-queue.git;a=3Dsummary > > >=20 > > > The filename of the patch is: > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mm-huge_memory.c-respect-foll_force-fol= l_cow-for-thp.patch > > > and it can be found in the queue-4.4 subdirectory. > > >=20 > > > If you, or anyone else, feels it should not be added to the stable tr= ee, > > > please let know about it. > > >=20 > > >=20 > > > From 303681d5d538d81b5e23754515202b5b9febd2e9 Mon Sep 17 00:00:00 200= 1 > > > From: Keno Fischer > > > Date: Tue, 24 Jan 2017 15:17:48 -0800 > > > Subject: mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp > > >=20 > > > From: Keno Fischer > > >=20 > > > commit 8310d48b125d19fcd9521d83b8293e63eb1646aa upstream. > >=20 > > [...] > > > =C2=A0- Drop change to follow_devmap_pmd() > > > =C2=A0- pmd_dirty() is not available; check the page flags as in olde= r > > > =C2=A0=C2=A0=C2=A0backports of can_follow_write_pte() > > > =C2=A0- Adjust context] > >=20 > > [...] > >=20 > > Aside from the fact that I got this backport wrong, I don't think you > > need the main change here.=C2=A0=C2=A0In 4.4, all arches that define > > CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE also define pmd_dirty(). >=20 > Hm, ok, but Keno said people are still hitting this issue on 4.4-stable. >=20 > So, what should I do?=C2=A0=C2=A0I'll go drop this from my queue for now,= but as I > don't know what to do to test this, I'm at a loss... I don't mean the fix isn't needed; I mean that I don't think you should use this backport. You should only need to drop the change to follow_devmap_pmd(). Ben. --=20 Ben Hutchings 73.46% of all statistics are made up. --=-akU8n9bUWQiTse937CA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAljrypUACgkQ57/I7JWG EQnWAw//eeswL/hbZzkXxioAFVgi0FRRq2ImFsANsj0N/HoOGCkUQsWvR84WrG+y UceFHZ7Vr7erfdirhJAOiz7Vq5VoxgjU5zln/wQ6YzcQyWdRHH30WhmAUbU3wI7d rlNy0URuxC5/+hkxWuUzK4mKmO+hgqBc4/MAuwmXa9pHEPfDSj0x2db4sw7WkFdh k9JCwkS4Z4BE2uTj22kQ7wEazEClr38Eu84vkqkPI2G5BwWY6V4Cnv+7H0DjJjnc j0sMNYKYqs2rL0Tfs9uH4qN6nOO53cQ7YVtwK8cE+nTD9j5nCjWinrdm4tyOVV4n Ga/za3zR3lNDOL+uwZDbhNvnI9jUURovJYT+OVb6Pjvwwl8R5kjOvlx/Sfgbw0YF LqbaPqFQZlVGdPkG7dIIvuMDvzriLOPMMsYMwUaH/Jbji88sVfmXCdHTsNwuiTn/ MFHVUgt2NqUuaIHebcub8S3Ynm/sSOq5X6QVrJbxLUTR+ZllLURH9nutwlbELTDo g808+NWXv50qiIQRjOpweB1rd9fitN/QFSAJbY93yKvrSbllaNFEtDhtZtgEpzXJ gAfjR8wJ/WqMDFS3ciD74KnR8LruAykMScjdnyN4xUDjhkEy7yaPVCTATM1rG5vU yCKp8Tp9iUZ72NJyJ0XYIOqihL6/o4uc8Bgd58+8dObwb6OX+Xk= =fe5V -----END PGP SIGNATURE----- --=-akU8n9bUWQiTse937CA2--