All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pushkar Jambhlekar <pushkar.iit@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Pushkar Jambhlekar <pushkar.iit@gmail.com>
Subject: [PATCH 1/2] drivers/dax: Avoiding potential deadlock
Date: Tue, 11 Apr 2017 10:56:44 +0530	[thread overview]
Message-ID: <1491888405-7772-1-git-send-email-pushkar.iit@gmail.com> (raw)

dax_dev_huge_fault returning without releasing lock. Making code change to avoid this situation

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
 drivers/dax/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
index 0d1ca24..fd9c4db 100644
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -590,7 +590,7 @@ static int dax_dev_huge_fault(struct vm_fault *vmf,
 		rc = __dax_dev_pud_fault(dax_dev, vmf);
 		break;
 	default:
-		return VM_FAULT_FALLBACK;
+		rc = VM_FAULT_FALLBACK;
 	}
 	rcu_read_unlock();
 
-- 
2.7.4

             reply	other threads:[~2017-04-11  5:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  5:26 Pushkar Jambhlekar [this message]
2017-04-11  5:26 ` [PATCH 2/2] drivers/dax: Changing RC value Pushkar Jambhlekar
2017-04-11 20:58   ` Andrew Morton
2017-04-12 16:27     ` Dan Williams
2017-04-11 16:17 ` [PATCH 1/2] drivers/dax: Avoiding potential deadlock Dan Williams
2017-04-12  4:19   ` Pushkar Jambhlekar
     [not found] <Dave Jiang <dave.jiang@intel.com>
2017-04-11  5:26 ` Pushkar Jambhlekar
  -- strict thread matches above, loose matches on Subject: below --
2017-04-11  5:24 Pushkar Jambhlekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491888405-7772-1-git-send-email-pushkar.iit@gmail.com \
    --to=pushkar.iit@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.