From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Wang Subject: [PATCH] net/virtio: fix queue notify Date: Tue, 11 Apr 2017 03:44:28 -0700 Message-ID: <1491907468-68207-1-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org, Xiao Wang , stable@dpdk.org To: yuanhan.liu@linux.intel.com Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" According to spec, we should write virtqueue index into the notify address, rather than 1. Besides, some HW backend may rely on the data written to identify which queue need to serve. Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") Cc: stable@dpdk.org Signed-off-by: Xiao Wang --- drivers/net/virtio/virtio_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index ce9a9d3..b767c03 100644 --- a/drivers/net/virtio/virtio_pci.c +++ b/drivers/net/virtio/virtio_pci.c @@ -504,7 +504,7 @@ static void modern_notify_queue(struct virtio_hw *hw __rte_unused, struct virtqueue *vq) { - rte_write16(1, vq->notify_addr); + rte_write16(vq->vq_queue_index, vq->notify_addr); } const struct virtio_pci_ops modern_ops = { -- 1.8.3.1