From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755080AbdDMKIV (ORCPT ); Thu, 13 Apr 2017 06:08:21 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:57343 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdDMKIS (ORCPT ); Thu, 13 Apr 2017 06:08:18 -0400 Message-ID: <1492078027.2383.19.camel@pengutronix.de> Subject: Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default From: Philipp Zabel To: Hans Verkuil Cc: Steve Longerbeam , robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, mchehab@kernel.org, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Steve Longerbeam Date: Thu, 13 Apr 2017 12:07:07 +0200 In-Reply-To: <6c22519f-64f8-7213-d458-23470bdd5ecd@xs4all.nl> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <0f9690f8-c7f6-59ff-9e3e-123af9972d4b@xs4all.nl> <1491490451.2392.70.camel@pengutronix.de> <59e72974-bfb0-6061-8b13-5f13f8723ba6@xs4all.nl> <1491494481.2392.102.camel@pengutronix.de> <6c22519f-64f8-7213-d458-23470bdd5ecd@xs4all.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git imx-media-staging-md-v14 > > > > I have uploaded a branch > > > > git://git.pengutronix.de/git/pza/linux imx-media-staging-md-v14+color > > > > with the patch applied on top. > > > >> I think one problem is that it is not clearly defined how subdevs and colorspace > >> information should work. > > Ah, having the full source helped. > > Ignore my previous review, it was incorrect. Ok. > I'll have to think about this some more. I'll get back to this, but it may take some > time since my vacation starts tomorrow. The spec is simply unclear about how to handle > this so we have to come up with some guidelines. Yes, please. Until then, have a nice vacation. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default Date: Thu, 13 Apr 2017 12:07:07 +0200 Message-ID: <1492078027.2383.19.camel@pengutronix.de> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <0f9690f8-c7f6-59ff-9e3e-123af9972d4b@xs4all.nl> <1491490451.2392.70.camel@pengutronix.de> <59e72974-bfb0-6061-8b13-5f13f8723ba6@xs4all.nl> <1491494481.2392.102.camel@pengutronix.de> <6c22519f-64f8-7213-d458-23470bdd5ecd@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6c22519f-64f8-7213-d458-23470bdd5ecd-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans Verkuil Cc: Steve Longerbeam , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, fabio.estevam-3arQi8VN3Tc@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nick-gcszYUEDH4VrovVCs/uTlw@public.gmane.org, markus.heiser-O6JHGLzbNUwb1SvskN2V4Q@public.gmane.org, laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, bparrot-l0cyMroinI0@public.gmane.org, geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, minghsiu.tsai-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, jean-christophe.trotin-qxv4g6HH51o@public.gmane.org, horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org, robert.jarzmik-GANU6spQydw@public.gmane.org, songjun.wu-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org, andrew-ct.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-medi List-Id: devicetree@vger.kernel.org On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git imx-media-staging-md-v14 > > > > I have uploaded a branch > > > > git://git.pengutronix.de/git/pza/linux imx-media-staging-md-v14+color > > > > with the patch applied on top. > > > >> I think one problem is that it is not clearly defined how subdevs and colorspace > >> information should work. > > Ah, having the full source helped. > > Ignore my previous review, it was incorrect. Ok. > I'll have to think about this some more. I'll get back to this, but it may take some > time since my vacation starts tomorrow. The spec is simply unclear about how to handle > this so we have to come up with some guidelines. Yes, please. Until then, have a nice vacation. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Thu, 13 Apr 2017 12:07:07 +0200 Subject: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default In-Reply-To: <6c22519f-64f8-7213-d458-23470bdd5ecd@xs4all.nl> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-22-git-send-email-steve_longerbeam@mentor.com> <1491486929.2392.29.camel@pengutronix.de> <0f9690f8-c7f6-59ff-9e3e-123af9972d4b@xs4all.nl> <1491490451.2392.70.camel@pengutronix.de> <59e72974-bfb0-6061-8b13-5f13f8723ba6@xs4all.nl> <1491494481.2392.102.camel@pengutronix.de> <6c22519f-64f8-7213-d458-23470bdd5ecd@xs4all.nl> Message-ID: <1492078027.2383.19.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git imx-media-staging-md-v14 > > > > I have uploaded a branch > > > > git://git.pengutronix.de/git/pza/linux imx-media-staging-md-v14+color > > > > with the patch applied on top. > > > >> I think one problem is that it is not clearly defined how subdevs and colorspace > >> information should work. > > Ah, having the full source helped. > > Ignore my previous review, it was incorrect. Ok. > I'll have to think about this some more. I'll get back to this, but it may take some > time since my vacation starts tomorrow. The spec is simply unclear about how to handle > this so we have to come up with some guidelines. Yes, please. Until then, have a nice vacation. regards Philipp