Re: [Qemu-devel] [PATCH] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply

[Michael Roth <mdroth@linux.vnet.ibm.com>]

Quoting Sameeh Jubran (2017-04-11 07:52:05)
> The QGA schema states:
> 
> @can-offline: Whether offlining the VCPU is possible. This member
>                is always filled in by the guest agent when the structure
>                is returned, and always ignored on input (hence it can be
>                omitted then).
> 
> Currently 'can-offline' is missing entirely from the reply. This causes
> errors in libvirt which is expecting the reply to be compliant with the
> schema docs.
> 
> BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735
> 
> Signed-off-by: Sameeh Jubran <sameeh@daynix.com>

Thanks, applied to qga tree:                                                                              

  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/commands-win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 19d72b2..f0d72a0 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp)
>                      vcpu = g_malloc0(sizeof *vcpu);
>                      vcpu->logical_id = current++;
>                      vcpu->online = true;
> -                    vcpu->has_can_offline = false;
> +                    vcpu->has_can_offline = true;
> 
>                      entry = g_malloc0(sizeof *entry);
>                      entry->value = vcpu;
> -- 
> 2.9.3
>