From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbdBHOuH (ORCPT ); Wed, 8 Feb 2017 09:50:07 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:47467 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754447AbdBHOtl (ORCPT ); Wed, 8 Feb 2017 09:49:41 -0500 X-AuditID: b6c32a2e-f79656d0000012f2-53-589b2f8c8590 From: Bartlomiej Zolnierkiewicz To: Dmitry Torokhov Cc: Tomi Valkeinen , Yongji Xie , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: offb: switch to using for_each_node_by_type Date: Wed, 08 Feb 2017 15:47:38 +0100 Message-id: <1492127.1iJfys0tjB@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170131182536.GA30076@dtor-ws> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZdlhTS7dHf3aEwYOJ1haHF71gtDjR94HV 4vKuOWwW6+ffYrP4cfESswOrx85Zd9k9HhzazOJx/MZ2Jo/Pm+QCWKK4bFJSczLLUov07RK4 MnbPDCr4xFlxrWE+awPjd/YuRk4OCQETiV8fG6FsMYkL99azdTFycQgJLGWUuDbtGiOE084k 0bLxPxNMx+f/WxhBbCGB5YwS895wQBR9ZZR4P/UMK0iCTcBKYmL7KrAiEQF9ie2zf4HZzAIT GSV+7rEEsYUFAiSmH7rADGKzCKhKzP7zEayXV0BTon3XNDYQW1TAS2LLvnawxZwCuhL933Yw QdQISvyYfI8FYqa8xL79U1khbB2Js8fWMUIcOpldYspUyS5GDiBbVmLTAWaIsIvExJ9z2CBs YYlXx7dAfS8t8XfpLajW6YwS239LgPwlIbCZUWLV7glQRdYSh49fhNrFJ9H7+wkTxHxeiY42 IYgSD4kJuw5AzXGUOHTjITMkfBoYJV5PPsY+gVF+FpIXZiF5YRaSFxYwMq9iFEstKM5NTy02 LTDWK07MLS7NS9dLzs/dxAhOGVp6Oxj/LfA+xCjAwajEw3sjcVaEEGtiWXFl7iFGCQ5mJRHe KNXZEUK8KYmVValF+fFFpTmpxYcYpTlYlMR5owwmRggJpCeWpGanphakFsFkmTg4pRoYQ98I CezhKOFgMzx2dP/6cpZe2zu8n+b2vy6KNHVRn3Fa51fYEhUOka81F5Z6iRuFiCzO3tbnOqWU dcK0X0lhKha9fDaJZ53CTyzobLzUuYJPPqvfcn3cep1dR+pavumwXovODc0SuSOsxJS5TvPP 0jWrhGZMnvZM6uyhYubjT/rWFP1eVO+nxFKckWioxVxUnAgAp+2rSxUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t9jAd0e/dkRBisXCFscXvSC0eJE3wdW i8u75rBZrJ9/i83ix8VLzA6sHjtn3WX3eHBoM4vH8RvbmTw+b5ILYIlys8lITUxJLVJIzUvO T8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bumUEFnzgr rjXMZ21g/M7excjJISFgIvH5/xZGCFtM4sK99WxdjFwcQgJLGSX6311mBUkICXxllHj11A7E ZhOwkpjYvgqsQURAX2L77F+MIA3MAhMZJT4famQGSQgL+ElMXTIZrJlFQFVi9p+PYDavgKZE +65pbCC2qICXxJZ97UwgNqeArkT/tx1MEMuaGCX2zA6FqBeU+DH5HguIzSwgL7Fv/1RWCFtL Yv3O40wTGAVmISmbhaRsFpKyBYzMqxglUguSC4qT0nON8lLL9YoTc4tL89L1kvNzNzGCo+iZ 9A7Gw7vcDzEKcDAq8fBWRMyKEGJNLCuuzD3EKMHBrCTCe1BvdoQQb0piZVVqUX58UWlOavEh RlOgBycyS4km5wMjPK8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6p BkaP587vI+SFVlTzHXzbcPX216nBT2b5bHjUY/h+rYjDiZqEIwZXuTeJHtH9pdISoFSs+PTe kZRt5dWucw3ci8LuvUhccCD+4Y7GmR8mqRduX7hd1NnZznv3foM/a6bc8TeZvWKxYML5YwsX KSvLJrFNdNHWTrZReCtk5TVbaKen5iaOdKP7CzOVWIozEg21mIuKEwHqg/o4uAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208144740epcas5p46ec6b41c94171d9d879d845c71f63738 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170131182541epcas1p402e498825d87444fda8a718daaa59374 X-RootMTR: 20170131182541epcas1p402e498825d87444fda8a718daaa59374 References: <20170131182536.GA30076@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, January 31, 2017 10:25:36 AM Dmitry Torokhov wrote: > Instead of open-coding loops let's switch to a nice macro. > > Signed-off-by: Dmitry Torokhov Patch queued for 4.11, thanks. > --- > drivers/video/fbdev/offb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c > index 906c6e75c260..9be884b0c778 100644 > --- a/drivers/video/fbdev/offb.c > +++ b/drivers/video/fbdev/offb.c > @@ -668,14 +668,14 @@ static int __init offb_init(void) > offb_init_nodriver(of_chosen, 1); > } > > - for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) { > + for_each_node_by_type(dp, "display") { > if (of_get_property(dp, "linux,opened", NULL) && > of_get_property(dp, "linux,boot-display", NULL)) { > boot_disp = dp; > offb_init_nodriver(dp, 0); > } > } > - for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) { > + for_each_node_by_type(dp, "display") { > if (of_get_property(dp, "linux,opened", NULL) && > dp != boot_disp) > offb_init_nodriver(dp, 0); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 08 Feb 2017 14:47:38 +0000 Subject: Re: [PATCH] video: fbdev: offb: switch to using for_each_node_by_type Message-Id: <1492127.1iJfys0tjB@amdc3058> List-Id: References: <20170131182536.GA30076@dtor-ws> In-Reply-To: <20170131182536.GA30076@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dmitry Torokhov Cc: Tomi Valkeinen , Yongji Xie , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hi, On Tuesday, January 31, 2017 10:25:36 AM Dmitry Torokhov wrote: > Instead of open-coding loops let's switch to a nice macro. > > Signed-off-by: Dmitry Torokhov Patch queued for 4.11, thanks. > --- > drivers/video/fbdev/offb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c > index 906c6e75c260..9be884b0c778 100644 > --- a/drivers/video/fbdev/offb.c > +++ b/drivers/video/fbdev/offb.c > @@ -668,14 +668,14 @@ static int __init offb_init(void) > offb_init_nodriver(of_chosen, 1); > } > > - for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) { > + for_each_node_by_type(dp, "display") { > if (of_get_property(dp, "linux,opened", NULL) && > of_get_property(dp, "linux,boot-display", NULL)) { > boot_disp = dp; > offb_init_nodriver(dp, 0); > } > } > - for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) { > + for_each_node_by_type(dp, "display") { > if (of_get_property(dp, "linux,opened", NULL) && > dp != boot_disp) > offb_init_nodriver(dp, 0); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics