[U-Boot] [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN

[U-Boot] [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN

[Heinrich Schuchardt]

A feature rich Kernel for Linux needs more than 8 MiB.
Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the Odroid C2.
As the Odroid C2 has has 2 GiB of RAM this poses no problem.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/configs/meson-gxbb-common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
index c3229ea..e993263 100644
--- a/include/configs/meson-gxbb-common.h
+++ b/include/configs/meson-gxbb-common.h
@@ -54,4 +54,6 @@
 	MESON_FDTFILE_SETTING \
 	BOOTENV
 
+#define CONFIG_SYS_BOOTM_LEN    (64 << 20)      /* 64 MiB */
+
 #endif /* __MESON_GXBB_COMMON_CONFIG_H */
-- 
2.1.4

[U-Boot] [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN

[Andreas Färber]

Hi,

Am 14.04.2017 um 14:17 schrieb Heinrich Schuchardt:
> A feature rich Kernel for Linux needs more than 8 MiB.

"Linux kernel"?

> Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the Odroid C2.
> As the Odroid C2 has has 2 GiB of RAM this poses no problem.

Duplicate "has", and "Odroid-C2".

You are touching a generic GXBB file but reason with Odroid-C2. I have
been chain-loading it on the Tronsmart Vega S95 Telos, for instance. I
believe your change is generally okay, but you should fix both lines
above and probably also the subject.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[U-Boot] [PATCH v2 1/1] meson: gxbb: increase CONFIG_SYS_BOOTM_LEN

[Heinrich Schuchardt]

A feature rich Linux kernel needs more than 8 MiB.
Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the GXBB systems.
As all known GXBB systems have at least 512 MiB of RAM this poses no problem.

Cc: Andreas Färber <afaerber@suse.de>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
v2:
  Title and commit message changed to reflect that this patch
  applies to all Meson GXBB systems.
v1:
  Initial patch
  [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN
  https://lists.denx.de/pipermail/u-boot/2017-April/287343.html
---
 include/configs/meson-gxbb-common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
index c3229ea..e993263 100644
--- a/include/configs/meson-gxbb-common.h
+++ b/include/configs/meson-gxbb-common.h
@@ -54,4 +54,6 @@
 	MESON_FDTFILE_SETTING \
 	BOOTENV
 
+#define CONFIG_SYS_BOOTM_LEN    (64 << 20)      /* 64 MiB */
+
 #endif /* __MESON_GXBB_COMMON_CONFIG_H */
-- 
2.1.4

[U-Boot] [U-Boot, v2, 1/1] meson: gxbb: increase CONFIG_SYS_BOOTM_LEN

[Heinrich Schuchardt]

On 04/14/2017 07:54 PM, xypron.glpk at gmx.de wrote:
> A feature rich Linux kernel needs more than 8 MiB.
> Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the GXBB systems.
> As all known GXBB systems have at least 512 MiB of RAM this poses no problem.
> 
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> v2:
>   Title and commit message changed to reflect that this patch
>   applies to all Meson GXBB systems.
> v1:
>   Initial patch
>   [PATCH 1/1] odroid-c2: increase CONFIG_SYS_BOOTM_LEN
>   https://lists.denx.de/pipermail/u-boot/2017-April/287343.html
> ---
>  include/configs/meson-gxbb-common.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
> index c3229ea..e993263 100644
> --- a/include/configs/meson-gxbb-common.h
> +++ b/include/configs/meson-gxbb-common.h
> @@ -54,4 +54,6 @@
>  	MESON_FDTFILE_SETTING \
>  	BOOTENV
>  
> +#define CONFIG_SYS_BOOTM_LEN    (64 << 20)      /* 64 MiB */
> +
>  #endif /* __MESON_GXBB_COMMON_CONFIG_H */
> 
Hello Tom,

could you, please, consider merging this patch.

Andreas already acknowledged the code change in version 1
(https://patchwork.ozlabs.org/patch/750826/) but requested updating the
commit message which is done with version 2.

I have been booting the Odroid C2 using bootm and booti with the patch
applied.

Best regards

Heinrich

[U-Boot] [U-Boot, v2, 1/1] meson: gxbb: increase CONFIG_SYS_BOOTM_LEN

[Tom Rini]

On Fri, Apr 14, 2017 at 07:54:40PM +0200, xypron.glpk at gmx.de wrote:

> A feature rich Linux kernel needs more than 8 MiB.
> Hence enlarge CONFIG_SYS_BOOTM_LEN to 64 MiB for the GXBB systems.
> As all known GXBB systems have at least 512 MiB of RAM this poses no problem.
> 
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170506/15df4dda/attachment.sig>