`all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)

[Paul Menzel <paulepanter@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

Dear GRUB folks,


When using GRUB as a coreboot payload, that means passing `--with-
platform=coreboot` to configure, and configuring it to load the GRUB
configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7
(Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by
the GNU/Linux distribution, I get a warning about the missing module
`all_video.mod`, and the enter key has to be pressed to continue
booting.

The function `load_video` in `/boot/grub/grub.cfg` is causing this.

```
function load_video {
  if [ x$feature_all_video_module = xy ]; then
    insmod all_video
  else
    insmod efi_gop
    insmod efi_uga
    insmod ieee1275_fb
    insmod vbe
    insmod vga
    insmod video_bochs
    insmod video_cirrus
  fi
}
```

This get added by `update-grub` from `/etc/grub.d/00_header`.

```
cat <<EOF
function load_video {
EOF
if [ -n "${GRUB_VIDEO_BACKEND}" ]; then
    cat <<EOF
  insmod ${GRUB_VIDEO_BACKEND}
EOF
else
# If all_video.mod isn't available load all modules available
# with versions prior to introduction of all_video.mod
cat <<EOF
  if [ x\$feature_all_video_module = xy ]; then
    insmod all_video
  else
    insmod efi_gop
    insmod efi_uga
    insmod ieee1275_fb
    insmod vbe
    insmod vga
    insmod video_bochs
    insmod video_cirrus
  fi
EOF
fi
```

Do you know of a way to make that compatible with grub-pc and GRUB
payload? That’s useful, as the hard disk can be connected to a system
running coreboot with SeaBIOS or GRUB as a payload, or a proprietary
vendor firmware.


Kind regards,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]