From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752551AbdDRIXA (ORCPT ); Tue, 18 Apr 2017 04:23:00 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54679 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752481AbdDRIV7 (ORCPT ); Tue, 18 Apr 2017 04:21:59 -0400 Message-ID: <1492503717.2432.33.camel@pengutronix.de> Subject: Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation From: Philipp Zabel To: Peter Rosin Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel@pengutronix.de Date: Tue, 18 Apr 2017 10:21:57 +0200 In-Reply-To: <5035ac59-c2ad-f1d8-b81c-2bdbc1b7581e@axentia.se> References: <20170413142439.24285-1-p.zabel@pengutronix.de> <5035ac59-c2ad-f1d8-b81c-2bdbc1b7581e@axentia.se> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-13 at 18:10 +0200, Peter Rosin wrote: > On 2017-04-13 16:24, Philipp Zabel wrote: > > According to the device tree binding documentation, the compatible > > should be "gpio-mux", not "mux-gpio". > > > > Signed-off-by: Philipp Zabel > > --- > > drivers/mux/mux-gpio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c > > index b304845c4812b..227d3572e6dbf 100644 > > --- a/drivers/mux/mux-gpio.c > > +++ b/drivers/mux/mux-gpio.c > > @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = { > > }; > > > > static const struct of_device_id mux_gpio_dt_ids[] = { > > - { .compatible = "mux-gpio", }, > > + { .compatible = "gpio-mux", }, > > { /* sentinel */ } > > }; > > MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids); > > > > Oh, crap, right you are. However, the mux patch series is not frozen yet, > and I think Greg KH will want this fixed before they are. So, I guess I'll > send a v11 of the mux series (shortly) instead of having this extra patch. Of course, I wasn't aware. regards Philipp