From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Tue, 18 Apr 2017 17:57:31 +0300 Subject: [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier In-Reply-To: <20170418164926.040301f7@jawa> References: <20170418135149.39798-1-andriy.shevchenko@linux.intel.com> <20170418164926.040301f7@jawa> Message-ID: <1492527451.24567.74.camel@linux.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote: > Hi Andy, > > > From: Felipe Balbi > > > > Add watchdog driver for Intel Tangier based platforms. > > > > Signed-off-by: Vincent Tinelli > > Signed-off-by: Felipe Balbi > > Signed-off-by: Andy Shevchenko > > --- > >  common/board_f.c               |  1 + > >  drivers/watchdog/Kconfig       |  8 ++++++ > >  drivers/watchdog/Makefile      |  1 + > >  drivers/watchdog/tangier_wdt.c | 63 > > ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 73 > > insertions(+) create mode 100644 drivers/watchdog/tangier_wdt.c > > > > diff --git a/common/board_f.c b/common/board_f.c > > index d9431ee79a..ad1eae98a5 100644 > > --- a/common/board_f.c > > +++ b/common/board_f.c > > @@ -91,6 +91,7 @@ static int init_func_watchdog_init(void) > >   (defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || \ > >   defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG) || > > \ > >   defined(CONFIG_DESIGNWARE_WATCHDOG) || \ > > + defined(CONFIG_TANGIER_WATCHDOG) || \ > >   defined(CONFIG_IMX_WATCHDOG)) > > I have stumbled upon similar patch... There should be new Kconfig > option created and enabled in required SoCs. I'm glad to use one if there is one. For now I prefer to have it functional. > The code seems OK, but recently patches to add wdt-uclass has been > posted: > > http://patchwork.ozlabs.org/patch/751448/ > http://patchwork.ozlabs.org/patch/751451/ > > Maybe it would be better to port this driver to the uclass from the > very beginning? Good point. Will do. -- Andy Shevchenko Intel Finland Oy