From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Message-ID: <1492555114.25766.93.camel@kernel.crashing.org> Subject: Re: [PATCH v3 00/32] PCI: fix config and I/O Address space memory mappings From: Benjamin Herrenschmidt To: Lorenzo Pieralisi Date: Wed, 19 Apr 2017 08:38:34 +1000 In-Reply-To: <20170418110350.GA1941@red-moon> References: <1491952371.7236.22.camel@kernel.crashing.org> <20170412113124.GZ17774@n2100.armlinux.org.uk> <1492005119.7236.62.camel@kernel.crashing.org> <20170412141654.GA17774@n2100.armlinux.org.uk> <20170412144109.GB6842@red-moon> <1492036240.7236.80.camel@kernel.crashing.org> <20170412224555.GB17774@n2100.armlinux.org.uk> <1492044780.7236.87.camel@kernel.crashing.org> <20170418085732.GA23882@red-moon> <1492511808.25766.91.camel@kernel.crashing.org> <20170418110350.GA1941@red-moon> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonas Bonn , Rich Felker , linux-pci@vger.kernel.org, Will Deacon , "James E.J. Bottomley" , David Howells , Max Filippov , Paul Mackerras , Huacai Chen , Guan Xuetao , Thomas Gleixner , Hans-Christian Egtvedt , linux-arch@vger.kernel.org, Jesper Nilsson , Yoshinori Sato , Michael Ellerman , Helge Deller , Russell King - ARM Linux , Ingo Molnar , Geert Uytterhoeven , Catalin Marinas , Matt Turner , Haavard Skinnemoen , Fenghua Yu , James Hogan , Chris Metcalf , Arnd Bergmann , Heiko Carstens , Stefan Kristiansson , Mikael Starvik , Ivan Kokshaysky , Bjorn Helgaas , Stafford Horne , linux-arm-kernel@lists.infradead.org, Richard Henderson , Chris Zankel , Michal Simek , Tony Luck , Vineet Gupta , linux-kernel@vger.kernel.org, Ralf Baechle , Richard Kuo , Niklas Cassel , "Luis R. Rodriguez" , Martin Schwidefsky , Ley Foon Tan , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Tue, 2017-04-18 at 12:03 +0100, Lorenzo Pieralisi wrote: > > The above would effectively disable mmap'ing of IO space for any > > architecture that doesn't have pgprot_nonposted... so everybody > > except > > ARM. Thus breaking a number of systems that have been working fine > > for > > years. > > pci_remap_iospace() is used on ARM/ARM64 only AFAICT I do not > understand > what I would actually break (and I am not sure at all how well PCI IO > space is tested on ARM/ARM64 machines anyway). My bad, I incorrectly assumed you were hacking the generic sysfs PCI mapping. Cheers, Ben. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v3 00/32] PCI: fix config and I/O Address space memory mappings Date: Wed, 19 Apr 2017 08:38:34 +1000 Message-ID: <1492555114.25766.93.camel@kernel.crashing.org> References: <1491952371.7236.22.camel@kernel.crashing.org> <20170412113124.GZ17774@n2100.armlinux.org.uk> <1492005119.7236.62.camel@kernel.crashing.org> <20170412141654.GA17774@n2100.armlinux.org.uk> <20170412144109.GB6842@red-moon> <1492036240.7236.80.camel@kernel.crashing.org> <20170412224555.GB17774@n2100.armlinux.org.uk> <1492044780.7236.87.camel@kernel.crashing.org> <20170418085732.GA23882@red-moon> <1492511808.25766.91.camel@kernel.crashing.org> <20170418110350.GA1941@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170418110350.GA1941@red-moon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lorenzo Pieralisi Cc: Jonas Bonn , Rich Felker , linux-pci@vger.kernel.org, Will Deacon , "James E.J. Bottomley" , David Howells , Max Filippov , Paul Mackerras , Huacai Chen , Guan Xuetao , Thomas Gleixner , Hans-Christian Egtvedt , linux-arch@vger.kernel.org, Jesper Nilsson , Yoshinori Sato , Michael Ellerman , Helge Deller , Russell King - ARM Linux , Ingo Molnar , Geert Uytterhoeven , Catalin Marinas , Matt Turner , Haavard Skinnemoen , Fenghua Yu List-Id: linux-arch.vger.kernel.org On Tue, 2017-04-18 at 12:03 +0100, Lorenzo Pieralisi wrote: > > The above would effectively disable mmap'ing of IO space for any > > architecture that doesn't have pgprot_nonposted... so everybody > > except > > ARM. Thus breaking a number of systems that have been working fine > > for > > years. > > pci_remap_iospace() is used on ARM/ARM64 only AFAICT I do not > understand > what I would actually break (and I am not sure at all how well PCI IO > space is tested on ARM/ARM64 machines anyway). My bad, I incorrectly assumed you were hacking the generic sysfs PCI mapping. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: benh@kernel.crashing.org (Benjamin Herrenschmidt) Date: Wed, 19 Apr 2017 08:38:34 +1000 Subject: [PATCH v3 00/32] PCI: fix config and I/O Address space memory mappings In-Reply-To: <20170418110350.GA1941@red-moon> References: <1491952371.7236.22.camel@kernel.crashing.org> <20170412113124.GZ17774@n2100.armlinux.org.uk> <1492005119.7236.62.camel@kernel.crashing.org> <20170412141654.GA17774@n2100.armlinux.org.uk> <20170412144109.GB6842@red-moon> <1492036240.7236.80.camel@kernel.crashing.org> <20170412224555.GB17774@n2100.armlinux.org.uk> <1492044780.7236.87.camel@kernel.crashing.org> <20170418085732.GA23882@red-moon> <1492511808.25766.91.camel@kernel.crashing.org> <20170418110350.GA1941@red-moon> Message-ID: <1492555114.25766.93.camel@kernel.crashing.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-04-18 at 12:03 +0100, Lorenzo Pieralisi wrote: > > The above would effectively disable mmap'ing of IO space for any > > architecture that doesn't have pgprot_nonposted... so everybody > > except > > ARM. Thus breaking a number of systems that have been working fine > > for > > years. > > pci_remap_iospace() is used on ARM/ARM64 only AFAICT I do not > understand > what I would actually break (and I am not sure at all how well PCI IO > space is tested on ARM/ARM64 machines anyway). My bad, I incorrectly assumed you were hacking the generic sysfs PCI mapping. Cheers, Ben.