From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/3] examples/distributor: fix build for non-x86 arch
Date: Fri, 05 Feb 2016 16:55:28 +0100 [thread overview]
Message-ID: <1492687.rAoTrH7ulh@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B0465D@irsmsx105.ger.corp.intel.com>
2016-02-05 15:15, Ananyev, Konstantin:
> From: Pattan, Reshma
> > From: Thomas Monjalon
> > > _mm_prefetch is defined only in x86 compilers.
> > > rte_prefetch functions are defined in EAL for each arch, and must be preferred
> > > over compiler intrinsics.
[...]
> > > - _mm_prefetch((void *)bufs[0], 0);
> > > - _mm_prefetch((void *)bufs[1], 0);
> > > - _mm_prefetch((void *)bufs[2], 0);
> > > + rte_prefetch0((void *)bufs[0]);
> > > + rte_prefetch0((void *)bufs[1]);
> > > + rte_prefetch0((void *)bufs[2]);
> >
> > Some time back Jerin Jacob has sent patch for replacing the _mm_prefetch with rte_prefetch_non_temporal. This is FYI.
>
> Yep:
> http://dpdk.org/dev/patchwork/patch/9369/
> http://dpdk.org/dev/patchwork/patch/9370/
>
> And on IA _mm_prefetch(p, 0) != rte_prefetch0(p).
> I think, as in Jacob implementation, it should be PREFETCHNTA.
Oh yes, you're right. Thanks
patch rejected
next prev parent reply other threads:[~2016-02-05 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 14:54 [PATCH 0/3] fix compilation of examples for ARM Thomas Monjalon
2016-02-05 14:54 ` [PATCH 1/3] examples/distributor: fix build for non-x86 arch Thomas Monjalon
2016-02-05 15:07 ` Pattan, Reshma
2016-02-05 15:15 ` Ananyev, Konstantin
2016-02-05 15:55 ` Thomas Monjalon [this message]
2016-02-05 14:54 ` [PATCH 2/3] examples/ethtool: fix build Thomas Monjalon
2016-02-15 11:15 ` Remy Horton
2016-02-05 14:54 ` [PATCH 3/3] examples: fix build dependencies Thomas Monjalon
2016-02-16 6:50 ` [PATCH 0/3] fix compilation of examples for ARM Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492687.rAoTrH7ulh@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.