From: Jamal Hadi Salim <jhs@mojatatu.com>
To: davem@davemloft.net
Cc: jiri@resnulli.us, xiyou.wangcong@gmail.com,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: [PATCH net-next v5 0/2] net sched actions: improve action dump performance
Date: Thu, 20 Apr 2017 09:06:20 -0400 [thread overview]
Message-ID: <1492693582-26810-1-git-send-email-jhs@emojatatu.com> (raw)
From: Jamal Hadi Salim <jhs@mojatatu.com>
Changes since v4:
1) Eric D.
pointed out that when all skb space is used up by the dump
there will be no space to insert the TCAA_ACT_COUNT attribute.
2) Jiri:
i) Change:
enum {
TCAA_UNSPEC,
TCAA_ACT_TAB,
TCAA_ACT_FLAGS,
TCAA_ACT_COUNT,
TCAA_ACT_TIME_FILTER,
__TCAA_MAX
};
#define TCAA_MAX (__TCAA_MAX - 1)
#define ACT_LARGE_DUMP_ON (1 << 0)
to:
enum {
TCAA_UNSPEC,
TCAA_ACT_TAB,
#define TCA_ACT_TAB TCAA_ACT_TAB
TCAA_ACT_FLAGS,
TCAA_ACT_COUNT,
__TCAA_MAX,
#define TCAA_MAX (__TCAA_MAX - 1)
};
#define ACT_LARGE_DUMP_ON BIT(0)
Jiri plans to followup with the rest of the code to make the
style consistent.
ii) Rename attribute TCAA_ACT_TIME_FILTER --> TCAA_ACT_TIME_DELTA
iii) Rename variable jiffy_filter --> jiffy_since
iv) Rename msecs_filter --> msecs_since
v) get rid of unused cb->args[0] and rename cb->args[4] to cb->args[0]
Jamal Hadi Salim (2):
net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
net sched actions: add time filter for action dumping
include/uapi/linux/rtnetlink.h | 22 ++++++++++++--
net/sched/act_api.c | 66 +++++++++++++++++++++++++++++++++++-------
2 files changed, 75 insertions(+), 13 deletions(-)
--
1.9.1
next reply other threads:[~2017-04-20 13:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 13:06 Jamal Hadi Salim [this message]
2017-04-20 13:06 ` [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-20 13:59 ` Jiri Pirko
2017-04-20 14:18 ` Jamal Hadi Salim
2017-04-20 14:24 ` Jiri Pirko
2017-04-24 9:14 ` Simon Horman
2017-04-24 12:49 ` Jamal Hadi Salim
2017-04-24 14:20 ` Pablo Neira Ayuso
2017-04-24 14:42 ` Jamal Hadi Salim
2017-04-24 20:30 ` David Miller
2017-04-24 22:18 ` Jamal Hadi Salim
2017-04-24 22:24 ` David Miller
2017-04-24 22:58 ` Jamal Hadi Salim
2017-04-20 14:25 ` Jamal Hadi Salim
2017-04-20 14:33 ` Jiri Pirko
2017-04-20 15:08 ` Jamal Hadi Salim
2017-04-20 15:13 ` Jiri Pirko
2017-04-20 16:09 ` Eric Dumazet
2017-04-20 17:39 ` Jamal Hadi Salim
2017-04-20 13:06 ` [PATCH net-next v5 2/2] net sched actions: add time filter for action dumping Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492693582-26810-1-git-send-email-jhs@emojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.