Re: [Qemu-devel] [PATCH v3 00/18] crypto: add afalg-backend support

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1492845627-4384-1-git-send-email-longpeng2@huawei.com
Type: series
Subject: [Qemu-devel] [PATCH v3 00/18] crypto: add afalg-backend support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
661f423 tests: crypto: add hmac speed benchmark support
5171494 tests: crypto: add hash speed benchmark support
13c3e03 tests: crypto: add cipher speed benchmark support
961a401 crypto: hmac: add af_alg hmac support
063286b crypto: hash: add afalg-backend hash support
b5355c4 crypto: cipher: add afalg-backend cipher support
2d2350b crypto: introduce some common functions for af_alg backend
cd954fa crypto: hmac: add hmac driver framework
a1fd00b crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend
9db6301 crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend
f1ed9b7 crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend
c024c50 crypto: hmac: move crypto/hmac.h into include/crypto/
6c9afb6 crypto: hash: add hash driver framework
e3e9bc0 crypto: cipher: add cipher driver framework
df0cae3 crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend
44bbb18 crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend
8089468 crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend
7b46541 crypto: cipher: introduce context free function

=== OUTPUT BEGIN ===
Checking PATCH 1/18: crypto: cipher: introduce context free function...
Checking PATCH 2/18: crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend...
Checking PATCH 3/18: crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend...
Checking PATCH 4/18: crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend...
Checking PATCH 5/18: crypto: cipher: add cipher driver framework...
Checking PATCH 6/18: crypto: hash: add hash driver framework...
Checking PATCH 7/18: crypto: hmac: move crypto/hmac.h into include/crypto/...
Checking PATCH 8/18: crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend...
Checking PATCH 9/18: crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend...
Checking PATCH 10/18: crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend...
Checking PATCH 11/18: crypto: hmac: add hmac driver framework...
Checking PATCH 12/18: crypto: introduce some common functions for af_alg backend...
ERROR: g_free(NULL) is safe this check is probably not required
#175: FILE: crypto/afalg.c:105:
+        if (afalg->name) {
+            g_free(afalg->name);

total: 1 errors, 0 warnings, 217 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/18: crypto: cipher: add afalg-backend cipher support...
Checking PATCH 14/18: crypto: hash: add afalg-backend hash support...
Checking PATCH 15/18: crypto: hmac: add af_alg hmac support...
Checking PATCH 16/18: tests: crypto: add cipher speed benchmark support...
Checking PATCH 17/18: tests: crypto: add hash speed benchmark support...
Checking PATCH 18/18: tests: crypto: add hmac speed benchmark support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org