Hi, Le jeudi 20 avril 2017 à 10:55 +0100, Daniel Thompson a écrit : > On 18/04/17 09:46, Paul Kocialkowski wrote: > > Hi, > > > > Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit : > > > On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski > > > wrote: > > > > Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit : > > > > > On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski > > > > > wrote: > > > > > > The move to a dedicated pwm_backlight_initial_power_state function > > > > > > in > > > > > > commit 7613c922315e308a6486d802abed2eb74443dffd modified the > > > > > > condition > > > > > > to set the enable gpio as output. This breaks specific use cases > > > > > > using > > > > > > that GPIO, such as tegra124-based nyan Chromebooks where backlight > > > > > > stopped working. > > > > > > > > > > > > This puts the condition back to the way it was before the move. > > > > > > > > > > > > Signed-off-by: Paul Kocialkowski > > > > > > > > > > Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented > > > > > .get_direction()" > > > > > (https://lkml.org/lkml/2017/4/4/225) fix your issue? > > > > > > > > This definitely solves the issue! > > > > > > > > Since this fixes broken backlight (that, in turn, makes systems > > > > unusable), > > > > perhaps this should be included in the next rc cycle? > > > > > > You mean v4.11 final, as there probably won't be another rc? > > > Yes! > > > > I'm all for it! > > Thanks for keeping our attention on this. I sent a PR yesterday (and  > hope my GPG key has attracted enough signatures). Thanks for acting fast and getting this merged already. This is greatly appreciated! Cheers, -- Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/