All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: david@gibson.dropbear.id.au
Cc: famz@redhat.com, peter.maydell@linaro.org,
	mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
	agraf@suse.de, qemu-ppc@nongnu.org, clg@kaod.org
Subject: Re: [Qemu-devel] [PULL 00/47] ppc-for-2.10 queue 20170424
Date: Sun, 23 Apr 2017 20:08:23 -0700 (PDT)	[thread overview]
Message-ID: <149300330317.69.15437780800942889841@c05f1edc8ed1> (raw)
In-Reply-To: <20170424015927.8933-1-david@gibson.dropbear.id.au>

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20170424015927.8933-1-david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PULL 00/47] ppc-for-2.10 queue 20170424
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
94bea6a target/ppc: Style fixes
d23eac0 e500, book3s: mfspr 259: Register mapped/aliased SPRG3 user read
3a5bd96 target/ppc: Flush TLB on write to PIDR
3240e33 spapr-cpu-core: Release ICPState object during CPU unrealization
ea6341d ppc/pnv: generate an OEM SEL event on shutdown
130cf1f ppc/pnv: add initial IPMI sensors for the BMC simulator
7e24b32 ppc/pnv: populate device tree for IPMI BT devices
6575717 ppc/pnv: populate device tree for serial devices
836d562 ppc/pnv: populate device tree for RTC devices
dca8231 ppc/pnv: scan ISA bus to populate device tree
4d631b7 ppc/pnv: enable only one LPC bus
af22372 ppc/pnv: Add support for POWER8+ LPC Controller
2d79b40 spapr: remove the 'nr_servers' field from the machine
8fa3c09 target/ppc: Fix size of struct PPCElfPrstatus
212f4d7 ipmi: introduce an ipmi_bmc_gen_event() API
240da02 ipmi: introduce an ipmi_bmc_sdr_find() API
3607ef7 ipmi: provide support for FRUs
aa873a2 ipmi: use a file to load SDRs
ef1ce62 ppc: add IPMI support
1a8fffd ppc/pnv: Add OCC model stub with interrupt support
828bcfa ppc/pnv: Add cut down PSI bridge model and hookup external interrupt
ac8392a ppc/pnv: add memory regions for the ICP registers
d90ca95 ppc/pnv: add a helper to calculate MMIO addresses registers
a5a614b ppc/pnv: create the ICP object under PnvCore
5f43b5e ppc/pnv: extend the machine with a InterruptStatsProvider interface
04dfecf ppc/pnv: extend the machine with a XICSFabric interface
5b94a0f ppc/pnv: add a PnvICPState object
96c645e ppc/xics: add a realize() handler to ICPStateClass
4569615 spapr: allocate the ICPState object from under sPAPRCPUCore
8257d1e spapr: move the IRQ server number mapping under the machine
56d6f91 ppc/xics: introduce an 'intc' backlink under PowerPCCPU
f024a9a target/ppc: Add ibm, processor-radix-AP-encodings for TCG
a0d8df3 spapr_pci: Removed unused include
7cc7952 spapr_pci: Warn when RAM page size is not enabled in IOMMU page mask
2093121 target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce
26538ee spapr: Workaround for broken radix guests
d2da420 spapr: Enable ISA 3.0 MMU mode selection via CAS
50fe08d spapr: move spapr_populate_pa_features()
d667f21 target/ppc: Implement H_REGISTER_PROCESS_TABLE H_CALL
129c199 target/ppc: Add new H-CALL shells for in memory table translation
d033285 target-ppc: support KVM_CAP_PPC_MMU_RADIX, KVM_CAP_PPC_MMU_HASH_V3
38c395b spapr: Add ibm, processor-radix-AP-encodings to the device tree
4fe232c target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64
90f87ad hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices
c98837a ppc/spapr: QOM'ify sPAPRRTCState
1bc37a7 pseries: Add pseries-2.10 machine type
40a726e target/ppc: Improve accuracy of guest HTM availability on P8s

=== OUTPUT BEGIN ===
Checking PATCH 1/47: target/ppc: Improve accuracy of guest HTM availability on P8s...
Checking PATCH 2/47: pseries: Add pseries-2.10 machine type...
Checking PATCH 3/47: ppc/spapr: QOM'ify sPAPRRTCState...
Checking PATCH 4/47: hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices...
Checking PATCH 5/47: target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64...
Checking PATCH 6/47: spapr: Add ibm, processor-radix-AP-encodings to the device tree...
Checking PATCH 7/47: target-ppc: support KVM_CAP_PPC_MMU_RADIX, KVM_CAP_PPC_MMU_HASH_V3...
Checking PATCH 8/47: target/ppc: Add new H-CALL shells for in memory table translation...
Checking PATCH 9/47: target/ppc: Implement H_REGISTER_PROCESS_TABLE H_CALL...
Checking PATCH 10/47: spapr: move spapr_populate_pa_features()...
Checking PATCH 11/47: spapr: Enable ISA 3.0 MMU mode selection via CAS...
Checking PATCH 12/47: spapr: Workaround for broken radix guests...
Checking PATCH 13/47: target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce...
Checking PATCH 14/47: spapr_pci: Warn when RAM page size is not enabled in IOMMU page mask...
Checking PATCH 15/47: spapr_pci: Removed unused include...
Checking PATCH 16/47: target/ppc: Add ibm, processor-radix-AP-encodings for TCG...
Checking PATCH 17/47: ppc/xics: introduce an 'intc' backlink under PowerPCCPU...
Checking PATCH 18/47: spapr: move the IRQ server number mapping under the machine...
Checking PATCH 19/47: spapr: allocate the ICPState object from under sPAPRCPUCore...
Checking PATCH 20/47: ppc/xics: add a realize() handler to ICPStateClass...
Checking PATCH 21/47: ppc/pnv: add a PnvICPState object...
Checking PATCH 22/47: ppc/pnv: extend the machine with a XICSFabric interface...
Checking PATCH 23/47: ppc/pnv: extend the machine with a InterruptStatsProvider interface...
Checking PATCH 24/47: ppc/pnv: create the ICP object under PnvCore...
Checking PATCH 25/47: ppc/pnv: add a helper to calculate MMIO addresses registers...
Checking PATCH 26/47: ppc/pnv: add memory regions for the ICP registers...
Checking PATCH 27/47: ppc/pnv: Add cut down PSI bridge model and hookup external interrupt...
Checking PATCH 28/47: ppc/pnv: Add OCC model stub with interrupt support...
Checking PATCH 29/47: ppc: add IPMI support...
Checking PATCH 30/47: ipmi: use a file to load SDRs...
Checking PATCH 31/47: ipmi: provide support for FRUs...
Checking PATCH 32/47: ipmi: introduce an ipmi_bmc_sdr_find() API...
Checking PATCH 33/47: ipmi: introduce an ipmi_bmc_gen_event() API...
Checking PATCH 34/47: target/ppc: Fix size of struct PPCElfPrstatus...
Checking PATCH 35/47: spapr: remove the 'nr_servers' field from the machine...
Checking PATCH 36/47: ppc/pnv: Add support for POWER8+ LPC Controller...
Checking PATCH 37/47: ppc/pnv: enable only one LPC bus...
Checking PATCH 38/47: ppc/pnv: scan ISA bus to populate device tree...
Checking PATCH 39/47: ppc/pnv: populate device tree for RTC devices...
Checking PATCH 40/47: ppc/pnv: populate device tree for serial devices...
Checking PATCH 41/47: ppc/pnv: populate device tree for IPMI BT devices...
Checking PATCH 42/47: ppc/pnv: add initial IPMI sensors for the BMC simulator...
Checking PATCH 43/47: ppc/pnv: generate an OEM SEL event on shutdown...
Checking PATCH 44/47: spapr-cpu-core: Release ICPState object during CPU unrealization...
Checking PATCH 45/47: target/ppc: Flush TLB on write to PIDR...
Checking PATCH 46/47: e500, book3s: mfspr 259: Register mapped/aliased SPRG3 user read...
ERROR: space prohibited between function name and open parenthesis '('
#51: FILE: target/ppc/translate_init.c:1643:
+static void gen_spr_usprg3 (CPUPPCState *env)

total: 1 errors, 0 warnings, 28 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 47/47: target/ppc: Style fixes...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2017-04-24  3:09 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  1:58 [Qemu-devel] [PULL 00/47] ppc-for-2.10 queue 20170424 David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 01/47] target/ppc: Improve accuracy of guest HTM availability on P8s David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 02/47] pseries: Add pseries-2.10 machine type David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 03/47] ppc/spapr: QOM'ify sPAPRRTCState David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 04/47] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 05/47] target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64 David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 06/47] spapr: Add ibm, processor-radix-AP-encodings to the device tree David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 07/47] target-ppc: support KVM_CAP_PPC_MMU_RADIX, KVM_CAP_PPC_MMU_HASH_V3 David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 08/47] target/ppc: Add new H-CALL shells for in memory table translation David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 09/47] target/ppc: Implement H_REGISTER_PROCESS_TABLE H_CALL David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 10/47] spapr: move spapr_populate_pa_features() David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 11/47] spapr: Enable ISA 3.0 MMU mode selection via CAS David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 12/47] spapr: Workaround for broken radix guests David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 13/47] target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 14/47] spapr_pci: Warn when RAM page size is not enabled in IOMMU page mask David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 15/47] spapr_pci: Removed unused include David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 16/47] target/ppc: Add ibm, processor-radix-AP-encodings for TCG David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 17/47] ppc/xics: introduce an 'intc' backlink under PowerPCCPU David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 18/47] spapr: move the IRQ server number mapping under the machine David Gibson
2017-04-24  1:58 ` [Qemu-devel] [PULL 19/47] spapr: allocate the ICPState object from under sPAPRCPUCore David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 20/47] ppc/xics: add a realize() handler to ICPStateClass David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 21/47] ppc/pnv: add a PnvICPState object David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 22/47] ppc/pnv: extend the machine with a XICSFabric interface David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 23/47] ppc/pnv: extend the machine with a InterruptStatsProvider interface David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 24/47] ppc/pnv: create the ICP object under PnvCore David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 25/47] ppc/pnv: add a helper to calculate MMIO addresses registers David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 26/47] ppc/pnv: add memory regions for the ICP registers David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 27/47] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 28/47] ppc/pnv: Add OCC model stub with interrupt support David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 29/47] ppc: add IPMI support David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 30/47] ipmi: use a file to load SDRs David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 31/47] ipmi: provide support for FRUs David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 32/47] ipmi: introduce an ipmi_bmc_sdr_find() API David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 33/47] ipmi: introduce an ipmi_bmc_gen_event() API David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 34/47] target/ppc: Fix size of struct PPCElfPrstatus David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 35/47] spapr: remove the 'nr_servers' field from the machine David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 36/47] ppc/pnv: Add support for POWER8+ LPC Controller David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 37/47] ppc/pnv: enable only one LPC bus David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 38/47] ppc/pnv: scan ISA bus to populate device tree David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 39/47] ppc/pnv: populate device tree for RTC devices David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 40/47] ppc/pnv: populate device tree for serial devices David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 41/47] ppc/pnv: populate device tree for IPMI BT devices David Gibson
2017-06-05 14:33   ` Peter Maydell
2017-06-05 15:36     ` Cédric Le Goater
2017-04-24  1:59 ` [Qemu-devel] [PULL 42/47] ppc/pnv: add initial IPMI sensors for the BMC simulator David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 43/47] ppc/pnv: generate an OEM SEL event on shutdown David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 44/47] spapr-cpu-core: Release ICPState object during CPU unrealization David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 45/47] target/ppc: Flush TLB on write to PIDR David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 46/47] e500, book3s: mfspr 259: Register mapped/aliased SPRG3 user read David Gibson
2017-04-24  1:59 ` [Qemu-devel] [PULL 47/47] target/ppc: Style fixes David Gibson
2017-04-24  3:08 ` no-reply [this message]
2017-04-24  4:25   ` [Qemu-devel] [Qemu-ppc] [PULL 00/47] ppc-for-2.10 queue 20170424 David Gibson
2017-04-24 13:12 ` [Qemu-devel] " Peter Maydell
2017-04-24 14:38   ` Cédric Le Goater
2017-04-25  6:55     ` Cédric Le Goater
2017-04-26  2:38   ` David Gibson
2017-04-26  6:11     ` Cédric Le Goater
2017-04-26 10:46       ` Peter Maydell
2017-04-26 13:15         ` Peter Maydell
2017-04-26 13:32           ` Cédric Le Goater
2017-04-26 13:56             ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149300330317.69.15437780800942889841@c05f1edc8ed1 \
    --to=no-reply@patchew.org \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=famz@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.