From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonard.crestez@nxp.com (Leonard Crestez) Date: Tue, 25 Apr 2017 22:39:54 +0300 Subject: [PATCH] [RFC] ARM: dts: imx6sx-sdb: Drop OPP hackery In-Reply-To: References: <20170425164224.26537-1-marex@denx.de> Message-ID: <1493149194.20997.3.camel@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-04-25 at 21:30 +0200, Marek Vasut wrote: > On 04/25/2017 06:42 PM, Marek Vasut wrote: > > The imx6sx-sdb has one power supply that drives both VDDARM_IN > > and VDDSOC_IN, which is the sw1a regulator on the PFUZE PMIC. > > Connect both inputs to the sw1a regulator on the PMIC and drop > > the OPP hackery which is no longer needed as the power framework > > will take care of the regulator configuration as needed. > > > > Signed-off-by: Marek Vasut > > Cc: Fabio Estevam > > Cc: Shawn Guo > > +CC Leonard Tested-by: Leonard Crestez The OPP hack only applies to LDO bypass mode and that is not in upstream. When LDOs are enabled the effect is to use higher voltages than necessary for no good reason. Setting these higher voltages can make some boards (for example Rev B) fail to boot with ugly semi-random crashes reminiscent of memory corruption. These failures happen the first time the lowest idle state is used. This patch fixes those crashes. It's not clear exactly why the crashes happen. Perhaps waking up from idle draws more power than is available? I don't think it matters. I sent a very similar patch a few minutes after this one: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-April/503241 .html > > @@ -145,3 +128,11 @@ > > reg = <1>; > > }; > > }; > > + > > +®_arm { > > + vin-supply = <&sw1a_reg>; > > +}; > > + > > +®_soc { > > + vin-supply = <&sw1a_reg>; > > +}; This is also good, it will result in lower voltages will result in lower voltages on VDD_ARM_SOC_IN rather than a fixed 1375 mV. -- Regards, Leonard